Gentoo Archives: gentoo-commits

From: Matt Turner <mattst88@×××××.com>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/catalyst:master commit in: modules/
Date: Sat, 23 Feb 2013 02:02:41
Message-Id: 1361584935.d2edff3599ac66053f1c801e090009278a82eaea.mattst88@gentoo
1 commit: d2edff3599ac66053f1c801e090009278a82eaea
2 Author: W. Trevor King <wking <AT> tremily <DOT> us>
3 AuthorDate: Sat Feb 9 20:45:37 2013 +0000
4 Commit: Matt Turner <mattst88 <AT> gmail <DOT> com>
5 CommitDate: Sat Feb 23 02:02:15 2013 +0000
6 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/catalyst.git;a=commit;h=d2edff35
7
8 generic_stage_target: Handle unspecified boot/kernel/<kname>/config
9
10 If boot/kernel/<kname>/config is not set, make _copy_kernel_config a
11 no-op.
12
13 Reviewed-by: Matt Turner <mattst88 <AT> gmail.com>
14
15 ---
16 modules/generic_stage_target.py | 27 +++++++++++----------------
17 1 files changed, 11 insertions(+), 16 deletions(-)
18
19 diff --git a/modules/generic_stage_target.py b/modules/generic_stage_target.py
20 index e741fcd..31cb025 100644
21 --- a/modules/generic_stage_target.py
22 +++ b/modules/generic_stage_target.py
23 @@ -1426,7 +1426,6 @@ class generic_stage_target(generic_target):
24 +"build_kernel_"+kname):
25 print "Resume point detected, skipping build_kernel for "+kname+" operation..."
26 return
27 - # TODO: make this not require a kernel config
28 self._copy_kernel_config(kname=kname)
29
30 """
31 @@ -1478,7 +1477,7 @@ class generic_stage_target(generic_target):
32 "Runscript post-kmerge failed",env=self.env)
33
34 def _copy_kernel_config(self, kname):
35 - try:
36 + if "boot/kernel/"+kname+"/config" in self.settings:
37 if not os.path.exists(self.settings["boot/kernel/"+kname+"/config"]):
38 self.unbind()
39 raise CatalystError,\
40 @@ -1486,21 +1485,17 @@ class generic_stage_target(generic_target):
41 self.settings["boot/kernel/"+kname+\
42 "/config"]
43
44 - except TypeError:
45 - raise CatalystError,\
46 - "Required value boot/kernel/config not specified"
47 + try:
48 + cmd("cp "+self.settings["boot/kernel/"+kname+\
49 + "/config"]+" "+\
50 + self.settings["chroot_path"]+"/var/tmp/"+\
51 + kname+".config",\
52 + "Couldn't copy kernel config: "+\
53 + self.settings["boot/kernel/"+kname+\
54 + "/config"],env=self.env)
55
56 - try:
57 - cmd("cp "+self.settings["boot/kernel/"+kname+\
58 - "/config"]+" "+\
59 - self.settings["chroot_path"]+"/var/tmp/"+\
60 - kname+".config",\
61 - "Couldn't copy kernel config: "+\
62 - self.settings["boot/kernel/"+kname+\
63 - "/config"],env=self.env)
64 -
65 - except CatalystError:
66 - self.unbind()
67 + except CatalystError:
68 + self.unbind()
69
70 def _copy_initramfs_overlay(self, kname):
71 if "boot/kernel/"+kname+"/initramfs_overlay" in self.settings: