Gentoo Archives: gentoo-commits

From: Sam James <sam@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: app-office/gnumeric/files/, app-office/gnumeric/
Date: Fri, 13 May 2022 20:21:39
Message-Id: 1652473284.aa6d4b689b0bff4e42acf9acd038637b5bd6199b.sam@gentoo
1 commit: aa6d4b689b0bff4e42acf9acd038637b5bd6199b
2 Author: orbea <orbea <AT> riseup <DOT> net>
3 AuthorDate: Tue May 10 23:36:20 2022 +0000
4 Commit: Sam James <sam <AT> gentoo <DOT> org>
5 CommitDate: Fri May 13 20:21:24 2022 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aa6d4b68
7
8 app-office/gnumeric: Fix build with slibtool
9
10 Bug: https://bugs.gentoo.org/791610
11 Upstream-PR: https://gitlab.gnome.org/GNOME/gnumeric/-/merge_requests/25
12 Signed-off-by: orbea <orbea <AT> riseup.net>
13 Closes: https://github.com/gentoo/gentoo/pull/25432
14 Signed-off-by: Sam James <sam <AT> gentoo.org>
15
16 .../gnumeric/files/gnumeric-1.12.52-slibtool.patch | 36 ++++++++++++++++++++++
17 app-office/gnumeric/gnumeric-1.12.52.ebuild | 10 ++++--
18 2 files changed, 44 insertions(+), 2 deletions(-)
19
20 diff --git a/app-office/gnumeric/files/gnumeric-1.12.52-slibtool.patch b/app-office/gnumeric/files/gnumeric-1.12.52-slibtool.patch
21 new file mode 100644
22 index 000000000000..43e869afa7a9
23 --- /dev/null
24 +++ b/app-office/gnumeric/files/gnumeric-1.12.52-slibtool.patch
25 @@ -0,0 +1,36 @@
26 +Upstream-PR: https://gitlab.gnome.org/GNOME/gnumeric/-/merge_requests/25
27 +From 3031cc85718dde12a34be46330ef3b8c885f4f9e Mon Sep 17 00:00:00 2001
28 +From: orbea <orbea@××××××.net>
29 +Date: Tue, 10 May 2022 15:52:57 -0700
30 +Subject: [PATCH] plugins/excelplugins: Remove erroneous .libs
31 +
32 +The .libs directory is for internal usage by the libtool
33 +implementation only.
34 +
35 +When build gnumeric with slibtool instead of GNU libtool this
36 +will be a failure where slibtool is far more strict about user
37 +errors.
38 +
39 +rdlibtool: error logged in slbt_exec_link_create_dep_file(), line 1091: path not found: ../../src/.libs/.libs/libspreadsheet.a.disabled.
40 +
41 +Gentoo Bug: https://bugs.gentoo.org/791610
42 +---
43 + plugins/excelplugins/Makefile.am | 2 +-
44 + 1 file changed, 1 insertion(+), 1 deletion(-)
45 +
46 +diff --git a/plugins/excelplugins/Makefile.am b/plugins/excelplugins/Makefile.am
47 +index 3bc8f70b0..91e2fa765 100644
48 +--- a/plugins/excelplugins/Makefile.am
49 ++++ b/plugins/excelplugins/Makefile.am
50 +@@ -7,7 +7,7 @@ gnumeric_plugin_excelpluginsdir = $(gnumeric_plugindir)/excelplugins
51 + xmldir = $(gnumeric_plugin_excelpluginsdir)
52 + gnumeric_plugin_excelplugins_LTLIBRARIES = plugin.la xlcall32.la
53 + plugin_la_LDFLAGS = -module $(GNUMERIC_PLUGIN_LDFLAGS)
54 +-plugin_la_LIBADD = ../../src/.libs/libspreadsheet.la
55 ++plugin_la_LIBADD = ../../src/libspreadsheet.la
56 + plugin_la_SOURCES = excelplugins.c
57 + xlcall32_la_LDFLAGS = -module $(GNUMERIC_PLUGIN_LDFLAGS)
58 + xlcall32_la_SOURCES = xlcall32_emulation.c win32replacements.h xlcall.h
59 +--
60 +GitLab
61 +
62
63 diff --git a/app-office/gnumeric/gnumeric-1.12.52.ebuild b/app-office/gnumeric/gnumeric-1.12.52.ebuild
64 index b11b523b71ae..9d77d7085a44 100644
65 --- a/app-office/gnumeric/gnumeric-1.12.52.ebuild
66 +++ b/app-office/gnumeric/gnumeric-1.12.52.ebuild
67 @@ -4,7 +4,7 @@
68 EAPI=8
69 PYTHON_COMPAT=( python3_{7..10} )
70
71 -inherit gnome.org libtool python-r1 xdg
72 +inherit autotools gnome.org python-r1 xdg
73
74 DESCRIPTION="The GNOME Spreadsheet"
75 HOMEPAGE="http://www.gnumeric.org/"
76 @@ -56,12 +56,18 @@ BDEPEND="
77 >=dev-util/intltool-0.35.0
78 virtual/pkgconfig"
79
80 +PATCHES=(
81 + "${FILESDIR}/${P}-slibtool.patch" # 791610
82 +)
83 +
84 src_prepare() {
85 default
86
87 # Manage gi overrides ourselves
88 sed '/SUBDIRS/ s/introspection//' -i Makefile.{am,in} || die
89 - elibtoolize
90 +
91 + # Changed from 'elibtoolize' for bug # 791610
92 + eautoreconf
93 }
94
95 src_configure() {