Gentoo Archives: gentoo-commits

From: Sebastien Fabbro <bicatali@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/sci:master commit in: /
Date: Tue, 28 Jan 2014 19:46:30
Message-Id: 1390387119.6a671b25edf542c6c9efdcdc4a9b318feaa4a99e.bicatali@gentoo
1 commit: 6a671b25edf542c6c9efdcdc4a9b318feaa4a99e
2 Author: Justin <jlec <AT> users <DOT> noreply <DOT> github <DOT> com>
3 AuthorDate: Wed Jan 22 10:38:39 2014 +0000
4 Commit: Sebastien Fabbro <bicatali <AT> gentoo <DOT> org>
5 CommitDate: Wed Jan 22 10:38:39 2014 +0000
6 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/sci.git;a=commit;h=6a671b25
7
8 Add Maintainer section
9
10 ---
11 CONTRIBUTING.md | 43 ++++++++++++++++++++++++++++++++++++++++++-
12 1 file changed, 42 insertions(+), 1 deletion(-)
13
14 diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
15 index f4e7e95..b156ca0 100644
16 --- a/CONTRIBUTING.md
17 +++ b/CONTRIBUTING.md
18 @@ -38,8 +38,12 @@ First clone the overlay
19 hub clone gentoo-science/sci
20
21
22 +In order to send pull request and ask for inclusion of your changes you need to have your own fork of the overlay on github. You can do this by
23 +
24 cd sci
25 + hub fork
26
27 +Now you are ready to start your work.
28
29 It is always convenient for development as well as for the review and merging process, if the development is done in branches.
30
31 @@ -56,13 +60,50 @@ Once *all* reported problems are resolved, you can commit it
32 echangelog "Here we write a comprehensible ChangeLog message"
33 repoman -m "Here we write a comprehensible commit message" commit
34
35 +Next we push back the changes to our fork and send a pull-request to the overlay maintainers.
36 +
37 + hub push YOUR_GITHUB_USER
38 + hub pull-request
39
40 +Lastly you need to wait for review comments and the merge of your work. In case you need to include some improvements, just commit your work again using repoman and push it again to your fork.
41
42 ----
43 ##For Maintainers
44
45 +**The merging of pull request should only be done by gentoo developers.**
46 +
47 +If you feel that they are slacking, don't bother to ping them again.
48 +
49 +###Prerequisite
50 +
51 +Make sure you have both repos (github & gentoo.org) as remotes defined.
52 +
53 + git remote -v
54 +
55 +should give
56 +
57 +> github git@××××××.com:gentoo-science/sci.git (fetch)
58 +>
59 +> github git@××××××.com:gentoo-science/sci.git (push)
60 +>
61 +> origin git+ssh://git@×××××××××××××××××××.org/proj/sci.git (fetch)
62 +>
63 +> origin git+ssh://git@×××××××××××××××××××.org/proj/sci.git (push)
64 +
65 +In the beginning you should review the pull request on github directly and recommend as much improvements as possible. Once everything is fine or you like to fix the rest yourself, you can use the follow command to get the pull-request in a new branch in you repo.
66 +
67 + hub checkout https://github.com/gentoo-science/sci/pull/176
68 +
69 +Now check the package by building and installing it, and run *repoman* in the package dir. If this is also fine, merge the branch into the master
70 +
71 + git checkout master
72 + git merge USER-BRANCH
73 +
74 +Finally use the script **merge-dualHEAD** from the *scripts* directory to merge the github and gentoo.org remote repo.
75 +
76
77 ---
78 +####.
79 This document is available under [Creative Commons Attribution ShareAlike 4.0](http://creativecommons.org/licenses/by-sa/4.0)
80
81 -![ccsa-4 icon](http://i.creativecommons.org/l/by-sa/4.0/88x31.png)
82 \ No newline at end of file
83 +![ccsa-4 icon](http://i.creativecommons.org/l/by-sa/4.0/88x31.png)