Gentoo Archives: gentoo-commits

From: Sam James <sam@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/apr-util/files/
Date: Mon, 20 Mar 2023 05:36:14
Message-Id: 1679290332.fcf8c8b1a3b361a0e5ddfa887c6fc02d2558a753.sam@gentoo
1 commit: fcf8c8b1a3b361a0e5ddfa887c6fc02d2558a753
2 Author: Michael Mair-Keimberger <mmk <AT> levelnine <DOT> at>
3 AuthorDate: Sun Mar 19 10:43:35 2023 +0000
4 Commit: Sam James <sam <AT> gentoo <DOT> org>
5 CommitDate: Mon Mar 20 05:32:12 2023 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fcf8c8b1
7
8 dev-libs/apr-util: remove unused patches
9
10 Signed-off-by: Michael Mair-Keimberger <mmk <AT> levelnine.at>
11 Closes: https://github.com/gentoo/gentoo/pull/30230
12 Signed-off-by: Sam James <sam <AT> gentoo.org>
13
14 .../apr-util-1.6.1-fix-gdbm-error-handling.patch | 79 --------------
15 .../files/apr-util-1.6.1-mariadb-support.patch | 116 ---------------------
16 2 files changed, 195 deletions(-)
17
18 diff --git a/dev-libs/apr-util/files/apr-util-1.6.1-fix-gdbm-error-handling.patch b/dev-libs/apr-util/files/apr-util-1.6.1-fix-gdbm-error-handling.patch
19 deleted file mode 100644
20 index 92a4738e66a5..000000000000
21 --- a/dev-libs/apr-util/files/apr-util-1.6.1-fix-gdbm-error-handling.patch
22 +++ /dev/null
23 @@ -1,79 +0,0 @@
24 -# https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=889170
25 -# needs to be submitted upstream
26 ---- apr-util.orig/dbm/apr_dbm_gdbm.c
27 -+++ apr-util/dbm/apr_dbm_gdbm.c
28 -@@ -36,13 +36,22 @@
29 - static apr_status_t g2s(int gerr)
30 - {
31 - if (gerr == -1) {
32 -- /* ### need to fix this */
33 -- return APR_EGENERAL;
34 -+ return APR_OS_START_USEERR + gdbm_errno;
35 - }
36 -
37 - return APR_SUCCESS;
38 - }
39 -
40 -+static apr_status_t gdat2s(datum d)
41 -+{
42 -+ if (d.dptr == NULL) {
43 -+ return APR_OS_START_USEERR + gdbm_errno;
44 -+ }
45 -+
46 -+ return APR_SUCCESS;
47 -+}
48 -+
49 -+
50 - static apr_status_t datum_cleanup(void *dptr)
51 - {
52 - if (dptr)
53 -@@ -55,19 +64,15 @@ static apr_status_t set_error(apr_dbm_t
54 - {
55 - apr_status_t rv = APR_SUCCESS;
56 -
57 -- /* ### ignore whatever the DBM said (dbm_said); ask it explicitly */
58 --
59 -- if ((dbm->errcode = gdbm_errno) == GDBM_NO_ERROR) {
60 -+ if (dbm_said == APR_SUCCESS) {
61 -+ dbm->errcode = GDBM_NO_ERROR;
62 - dbm->errmsg = NULL;
63 - }
64 - else {
65 -+ dbm->errcode = dbm_said;
66 - dbm->errmsg = gdbm_strerror(gdbm_errno);
67 -- rv = APR_EGENERAL; /* ### need something better */
68 - }
69 -
70 -- /* captured it. clear it now. */
71 -- gdbm_errno = GDBM_NO_ERROR;
72 --
73 - return rv;
74 - }
75 -
76 -@@ -144,7 +149,7 @@ static apr_status_t vt_gdbm_fetch(apr_db
77 -
78 - /* store the error info into DBM, and return a status code. Also, note
79 - that *pvalue should have been cleared on error. */
80 -- return set_error(dbm, APR_SUCCESS);
81 -+ return set_error(dbm, gdat2s(rd));
82 - }
83 -
84 - static apr_status_t vt_gdbm_store(apr_dbm_t *dbm, apr_datum_t key,
85 -@@ -203,7 +208,7 @@ static apr_status_t vt_gdbm_firstkey(apr
86 - apr_pool_cleanup_null);
87 -
88 - /* store any error info into DBM, and return a status code. */
89 -- return set_error(dbm, APR_SUCCESS);
90 -+ return set_error(dbm, gdat2s(rd));
91 - }
92 -
93 - static apr_status_t vt_gdbm_nextkey(apr_dbm_t *dbm, apr_datum_t *pkey)
94 -@@ -223,7 +228,7 @@ static apr_status_t vt_gdbm_nextkey(apr_
95 - apr_pool_cleanup_null);
96 -
97 - /* store any error info into DBM, and return a status code. */
98 -- return set_error(dbm, APR_SUCCESS);
99 -+ return set_error(dbm, gdat2s(rd));
100 - }
101 -
102 - static void vt_gdbm_freedatum(apr_dbm_t *dbm, apr_datum_t data)
103
104 diff --git a/dev-libs/apr-util/files/apr-util-1.6.1-mariadb-support.patch b/dev-libs/apr-util/files/apr-util-1.6.1-mariadb-support.patch
105 deleted file mode 100644
106 index 137e99f97637..000000000000
107 --- a/dev-libs/apr-util/files/apr-util-1.6.1-mariadb-support.patch
108 +++ /dev/null
109 @@ -1,116 +0,0 @@
110 -Backport of http://svn.apache.org/viewvc?rev=1872060&view=rev
111 -
112 ---- a/build/dbd.m4
113 -+++ b/build/dbd.m4
114 -@@ -163,10 +163,15 @@ AC_DEFUN([APU_CHECK_DBD_MYSQL], [
115 - old_cppflags="$CPPFLAGS"
116 - old_ldflags="$LDFLAGS"
117 -
118 -+ my_library="mysqlclient"
119 -+
120 - AC_ARG_WITH([mysql], APR_HELP_STRING([--with-mysql=DIR], [enable MySQL DBD driver]),
121 - [
122 - if test "$withval" = "yes"; then
123 - AC_PATH_PROG([MYSQL_CONFIG],[mysql_config])
124 -+ if test "x$MYSQL_CONFIG" = "x"; then
125 -+ AC_PATH_TOOL([MYSQL_CONFIG],[mariadb_config])
126 -+ fi
127 - if test "x$MYSQL_CONFIG" != 'x'; then
128 - mysql_CPPFLAGS="`$MYSQL_CONFIG --include`"
129 - mysql_LDFLAGS="`$MYSQL_CONFIG --libs_r | sed -e 's/-l[[^ ]]\+//g'`"
130 -@@ -174,29 +179,37 @@ AC_DEFUN([APU_CHECK_DBD_MYSQL], [
131 -
132 - APR_ADDTO(CPPFLAGS, [$mysql_CPPFLAGS])
133 - APR_ADDTO(LIBS, [$mysql_LIBS])
134 -+
135 -+ if $MYSQL_CONFIG --libs_r | grep -q mariadb; then
136 -+ my_library="mariadb"
137 -+ fi
138 - fi
139 -
140 -- AC_CHECK_HEADERS([mysql.h my_global.h my_sys.h],
141 -- AC_CHECK_LIB(mysqlclient, mysql_init, [apu_have_mysql=1]),
142 -- [apu_have_mysql=0; break],
143 -- [#include <my_global.h>])
144 -- if test "$apu_have_mysql" = "0"; then
145 -- AC_CHECK_HEADERS([mysql/mysql.h mysql/my_global.h mysql/my_sys.h],
146 -- AC_CHECK_LIB(mysqlclient, mysql_init, [apu_have_mysql=1]),
147 -- [apu_have_mysql=0; break],
148 -- [#include <mysql/my_global.h>])
149 -+ AC_CHECK_HEADERS([mysql.h errmsg.h], [apu_have_mysql=1], [apu_have_mysql=0; break])
150 -+ if test "$apr_have_mysql" = "0"; then
151 -+ AC_CHECK_HEADERS([mysql/mysql.h mysql/errmsg.h], [apu_have_mysql=1], [apu_have_mysql=0; break])
152 - fi
153 -- if test "$apu_have_mysql" != "0" && test "x$MYSQL_CONFIG" != 'x'; then
154 -+ if test "$apr_have_mysql" = "1"; then
155 -+ AC_CHECK_HEADERS([my_global.h my_sys.h mysql/my_global.h mysql/my_sys.h])
156 -+ AC_CHECK_LIB($my_library, mysql_init,, [apu_have_mysql=0])
157 -+ fi
158 -+ if test "$apu_have_mysql" = "1" && test "x$MYSQL_CONFIG" != 'x'; then
159 - APR_ADDTO(APRUTIL_PRIV_INCLUDES, [$mysql_CPPFLAGS])
160 - fi
161 - elif test "$withval" = "no"; then
162 - :
163 - else
164 - AC_PATH_PROG([MYSQL_CONFIG],[mysql_config],,[$withval/bin])
165 -+ if test "x$MYSQL_CONFIG" = "x"; then
166 -+ AC_PATH_TOOL([MYSQL_CONFIG],[mariadb_config],,[$withval/bin])
167 -+ fi
168 - if test "x$MYSQL_CONFIG" != 'x'; then
169 - mysql_CPPFLAGS="`$MYSQL_CONFIG --include`"
170 - mysql_LDFLAGS="`$MYSQL_CONFIG --libs_r | sed -e 's/-l[[^ ]]\+//g'`"
171 - mysql_LIBS="`$MYSQL_CONFIG --libs_r`"
172 -+ if $MYSQL_CONFIG --libs_r | grep -q mariadb; then
173 -+ my_library="mariadb"
174 -+ fi
175 - else
176 - mysql_CPPFLAGS="-I$withval/include"
177 - mysql_LDFLAGS="-L$withval/lib "
178 -@@ -207,18 +220,15 @@ AC_DEFUN([APU_CHECK_DBD_MYSQL], [
179 - APR_ADDTO(LIBS, [$mysql_LIBS])
180 -
181 - AC_MSG_NOTICE(checking for mysql in $withval)
182 -- AC_CHECK_HEADERS([mysql.h my_global.h my_sys.h],
183 -- AC_CHECK_LIB(mysqlclient, mysql_init, [apu_have_mysql=1]),
184 -- [apu_have_mysql=0; break],
185 -- [#include <my_global.h>])
186 --
187 -- if test "$apu_have_mysql" != "1"; then
188 -- AC_CHECK_HEADERS([mysql/mysql.h mysql/my_global.h mysql/my_sys.h],
189 -- AC_CHECK_LIB(mysqlclient, mysql_init, [apu_have_mysql=1]),
190 -- [apu_have_mysql=0; break],
191 -- [#include <mysql/my_global.h>])
192 -+ AC_CHECK_HEADERS([mysql.h errmsg.h], [apu_have_mysql=1], [apu_have_mysql=0; break])
193 -+ if test "$apr_have_mysql" = "0"; then
194 -+ AC_CHECK_HEADERS([mysql/mysql.h mysql/errmsg.h], [apu_have_mysql=1], [apu_have_mysql=0; break])
195 -+ fi
196 -+ if test "$apr_have_mysql" = "1"; then
197 -+ AC_CHECK_HEADERS([my_global.h my_sys.h mysql/my_global.h mysql/my_sys.h])
198 -+ AC_CHECK_LIB($my_library, mysql_init,, [apu_have_mysql=0])
199 - fi
200 -- if test "$apu_have_mysql" != "0"; then
201 -+ if test "$apu_have_mysql" = "1"; then
202 - APR_ADDTO(APRUTIL_PRIV_INCLUDES, [$mysql_CPPFLAGS])
203 - fi
204 - fi
205 -@@ -229,7 +239,7 @@ AC_DEFUN([APU_CHECK_DBD_MYSQL], [
206 - dnl Since we have already done the AC_CHECK_LIB tests, if we have it,
207 - dnl we know the library is there.
208 - if test "$apu_have_mysql" = "1"; then
209 -- APR_ADDTO(LDADD_dbd_mysql, [$mysql_LDFLAGS -lmysqlclient $mysql_LIBS])
210 -+ APR_ADDTO(LDADD_dbd_mysql, [$mysql_LDFLAGS -l$my_library $mysql_LIBS])
211 - fi
212 - AC_SUBST(LDADD_dbd_mysql)
213 -
214 ---- a/dbd/apr_dbd_mysql.c
215 -+++ b/dbd/apr_dbd_mysql.c
216 -@@ -1262,7 +1262,9 @@ static apr_status_t thread_end(void *data)
217 -
218 - static void dbd_mysql_init(apr_pool_t *pool)
219 - {
220 -+#if MYSQL_VERSION_ID < 100000
221 - my_init();
222 -+#endif
223 - mysql_thread_init();
224 -
225 - /* FIXME: this is a guess; find out what it really does */