Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-frameworks/extra-cmake-modules/files/
Date: Sun, 07 Aug 2022 15:52:03
Message-Id: 1659887496.c1238783ac0a950fe2db564358064d860af000e1.asturm@gentoo
1 commit: c1238783ac0a950fe2db564358064d860af000e1
2 Author: Michael Mair-Keimberger <mmk <AT> levelnine <DOT> at>
3 AuthorDate: Sun Aug 7 09:56:47 2022 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Sun Aug 7 15:51:36 2022 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1238783
7
8 kde-frameworks/extra-cmake-modules: remove unused patches
9
10 Signed-off-by: Michael Mair-Keimberger <mmk <AT> levelnine.at>
11 Portage 3.0.34 / pkgdev 0.2.1 / pkgcheck 0.10.12
12 Closes: https://github.com/gentoo/gentoo/pull/26769
13 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
14
15 ...ke-modules-5.72.0-skip-ecm_add_test-early.patch | 54 ---------------
16 ...make-modules-5.91.0-disable-qmlplugindump.patch | 76 ----------------------
17 2 files changed, 130 deletions(-)
18
19 diff --git a/kde-frameworks/extra-cmake-modules/files/extra-cmake-modules-5.72.0-skip-ecm_add_test-early.patch b/kde-frameworks/extra-cmake-modules/files/extra-cmake-modules-5.72.0-skip-ecm_add_test-early.patch
20 deleted file mode 100644
21 index 72541d73e72e..000000000000
22 --- a/kde-frameworks/extra-cmake-modules/files/extra-cmake-modules-5.72.0-skip-ecm_add_test-early.patch
23 +++ /dev/null
24 @@ -1,54 +0,0 @@
25 -From ad3aec71ed7f8820e69fe55489368a19d0735ab5 Mon Sep 17 00:00:00 2001
26 -From: Andreas Sturmlechner <asturm@g.o>
27 -Date: Sat, 11 Jul 2020 23:04:16 +0200
28 -Subject: [PATCH] ECMAddTests.cmake: Skip ecm_add_test early if Qt5::Test is not available
29 -
30 -Signed-off-by: Andreas Sturmlechner <asturm@g.o>
31 ----
32 - modules/ECMAddTests.cmake | 9 +++++++++
33 - tests/ECMAddTests/CMakeLists.txt | 5 +++++
34 - 2 files changed, 14 insertions(+)
35 -
36 -diff --git a/modules/ECMAddTests.cmake b/modules/ECMAddTests.cmake
37 -index 4bc7fb8..12825aa 100644
38 ---- a/modules/ECMAddTests.cmake
39 -+++ b/modules/ECMAddTests.cmake
40 -@@ -81,6 +81,10 @@ function(ecm_add_test)
41 - message(FATAL_ERROR "ecm_add_test() called with multiple source files but without setting \"TEST_NAME\"")
42 - endif()
43 -
44 -+ if(NOT TARGET Qt5::Test)
45 -+ return()
46 -+ endif()
47 -+
48 - set(_testname ${ARG_NAME_PREFIX}${_targetname})
49 - set(gui_args)
50 - if(ARG_GUI)
51 -@@ -122,6 +126,11 @@ function(ecm_add_tests)
52 - endif()
53 - set(test_names)
54 - set(target_names)
55 -+
56 -+ if(NOT TARGET Qt5::Test)
57 -+ return()
58 -+ endif()
59 -+
60 - foreach(_test_source ${ARG_UNPARSED_ARGUMENTS})
61 - ecm_add_test(${_test_source}
62 - NAME_PREFIX ${ARG_NAME_PREFIX}
63 -diff --git a/tests/ECMAddTests/CMakeLists.txt b/tests/ECMAddTests/CMakeLists.txt
64 -index e77b33f..4e191fe 100644
65 ---- a/tests/ECMAddTests/CMakeLists.txt
66 -+++ b/tests/ECMAddTests/CMakeLists.txt
67 -@@ -1,3 +1,8 @@
68 -+if(NOT TARGET Qt5::Test)
69 -+ message(STATUS "WARNING: skipping tests that require Qt5::Test")
70 -+ return()
71 -+endif()
72 -+
73 - macro(add_check NAME)
74 - string(REPLACE "." "/" dir "${NAME}")
75 - string(REGEX REPLACE "[^.]*\\." "" proj "${NAME}")
76 ---
77 -2.27.0
78 -
79
80 diff --git a/kde-frameworks/extra-cmake-modules/files/extra-cmake-modules-5.91.0-disable-qmlplugindump.patch b/kde-frameworks/extra-cmake-modules/files/extra-cmake-modules-5.91.0-disable-qmlplugindump.patch
81 deleted file mode 100644
82 index fbec9a441e37..000000000000
83 --- a/kde-frameworks/extra-cmake-modules/files/extra-cmake-modules-5.91.0-disable-qmlplugindump.patch
84 +++ /dev/null
85 @@ -1,76 +0,0 @@
86 -From 76ee984d5094990c2bd79c71b84ba9f82b3bf3da Mon Sep 17 00:00:00 2001
87 -From: Andreas Sturmlechner <asturm@g.o>
88 -Date: Sun, 8 Dec 2019 15:01:33 +0100
89 -Subject: [PATCH] ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to
90 - avoid sandbox violations
91 -
92 -See also: https://phabricator.kde.org/D25812
93 -
94 -Backstory: https://bugzilla.gnome.org/show_bug.cgi?id=744135
95 -BUG: 387753
96 ----
97 - modules/ECMFindQmlModule.cmake.in | 45 ++++++++++++++++++-------------
98 - 1 file changed, 27 insertions(+), 18 deletions(-)
99 -
100 -diff --git a/modules/ECMFindQmlModule.cmake.in b/modules/ECMFindQmlModule.cmake.in
101 -index 6c054bf0..1c17c981 100644
102 ---- a/modules/ECMFindQmlModule.cmake.in
103 -+++ b/modules/ECMFindQmlModule.cmake.in
104 -@@ -7,27 +7,36 @@
105 - include(FindPackageHandleStandardArgs)
106 - include("${ECM_MODULE_DIR}/QtVersionOption.cmake")
107 -
108 --if (QT_MAJOR_VERSION EQUAL "5")
109 -- include("${ECM_MODULE_DIR}/ECMQueryQmake.cmake")
110 -- query_qmake(qt_binaries_dir QT_HOST_BINS)
111 -- find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
112 --elseif (QT_MAJOR_VERSION EQUAL "6")
113 -- find_package(Qt6 COMPONENTS QmlTools REQUIRED)
114 -- get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
115 --endif()
116 --
117 --if(NOT QMLPLUGINDUMP_PROGRAM)
118 -- message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
119 --endif()
120 -+option (ECM_DISABLE_QMLPLUGINDUMP "Do not use qmlplugindump which may segfault in some sandboxed environments" OFF)
121 -
122 --execute_process(COMMAND "${QMLPLUGINDUMP_PROGRAM}" "@MODULE_NAME@" "@VERSION@" ERROR_VARIABLE ERRORS_OUTPUT OUTPUT_VARIABLE DISREGARD_VARIABLE RESULT_VARIABLE ExitCode TIMEOUT 30)
123 --
124 --if(ExitCode EQUAL 0)
125 -+if(ECM_DISABLE_QMLPLUGINDUMP)
126 -+ message(NOTICE "@GENMODULE@: qmlplugindump disabled - assuming dependency is available as >= @VERSION@.")
127 - set(@GENMODULE@_FOUND TRUE)
128 -- set(@GENMODULE@_VERSION "${PACKAGE_FIND_VERSION}")
129 -+ set(@GENMODULE@_VERSION @VERSION@)
130 - else()
131 -- message(STATUS "qmlplugindump failed for @MODULE_NAME@.")
132 -- set(@GENMODULE@_FOUND FALSE)
133 -+
134 -+ if (QT_MAJOR_VERSION EQUAL "5")
135 -+ include("${ECM_MODULE_DIR}/ECMQueryQmake.cmake")
136 -+ query_qmake(qt_binaries_dir QT_HOST_BINS)
137 -+ find_program(QMLPLUGINDUMP_PROGRAM NAMES qmlplugindump HINTS ${qt_binaries_dir})
138 -+ elseif (QT_MAJOR_VERSION EQUAL "6")
139 -+ find_package(Qt6 COMPONENTS QmlTools REQUIRED)
140 -+ get_target_property(QMLPLUGINDUMP_PROGRAM Qt6::qmlplugindump LOCATION)
141 -+ endif()
142 -+
143 -+ if(NOT QMLPLUGINDUMP_PROGRAM)
144 -+ message(WARNING "Could not find qmlplugindump. It is necessary to look up qml module dependencies.")
145 -+ endif()
146 -+
147 -+ execute_process(COMMAND "${QMLPLUGINDUMP_PROGRAM}" "@MODULE_NAME@" "@VERSION@" ERROR_VARIABLE ERRORS_OUTPUT OUTPUT_VARIABLE DISREGARD_VARIABLE RESULT_VARIABLE ExitCode TIMEOUT 30)
148 -+
149 -+ if(ExitCode EQUAL 0)
150 -+ set(@GENMODULE@_FOUND TRUE)
151 -+ set(@GENMODULE@_VERSION "${PACKAGE_FIND_VERSION}")
152 -+ else()
153 -+ message(STATUS "qmlplugindump failed for @MODULE_NAME@.")
154 -+ set(@GENMODULE@_FOUND FALSE)
155 -+ endif()
156 - endif()
157 -
158 - find_package_handle_standard_args(@GENMODULE@
159 ---
160 -2.34.1
161 -