Gentoo Archives: gentoo-commits

From: "Pacho Ramos (pacho)" <pacho@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] gentoo-x86 commit in net-misc/selfdhcp/files: selfdhcp-0.2a-buffer-overflow.patch
Date: Sat, 03 Mar 2012 15:44:39
Message-Id: 20120303154430.DC3B72004C@flycatcher.gentoo.org
1 pacho 12/03/03 15:44:30
2
3 Added: selfdhcp-0.2a-buffer-overflow.patch
4 Log:
5 Fix overflow, bug #337520 by flameeyes and fix by Kevin McCarthy.
6
7 (Portage version: 2.1.10.49/cvs/Linux x86_64)
8
9 Revision Changes Path
10 1.1 net-misc/selfdhcp/files/selfdhcp-0.2a-buffer-overflow.patch
11
12 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-misc/selfdhcp/files/selfdhcp-0.2a-buffer-overflow.patch?rev=1.1&view=markup
13 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/net-misc/selfdhcp/files/selfdhcp-0.2a-buffer-overflow.patch?rev=1.1&content-type=text/plain
14
15 Index: selfdhcp-0.2a-buffer-overflow.patch
16 ===================================================================
17 --- selfdhcp-0.2a.orig/src/selfdhcp_profiles.c 2004-08-02 18:10:36.000000000 -0400
18 +++ selfdhcp-0.2a/src/selfdhcp_profiles.c 2011-01-29 11:54:29.132199679 -0500
19 @@ -345,7 +345,7 @@
20 {
21 key = xmlNodeListGetString (doc, cur->xmlChildrenNode, 1);
22 err_msg (DBG_PROG, "xml element \"%s\"", (char *) key);
23 - strncpy (netconf_buff.domainname, (char *) key, 49);
24 + strncpy (netconf_buff.domainname, (char *) key, sizeof(netconf_buff.domainname)-1);
25 netconf_buff.what_is_set &= NETADDR;
26 err_msg (DBG_INFO, "read domain name \"%s\"",
27 netconf_buff.domainname);