Gentoo Archives: gentoo-commits

From: "Davide Pesavento (pesa)" <pesa@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] gentoo-x86 commit in dev-qt/qtgui/files: qtgui-4.8.5-disable-gtk-theme-check.patch qtgui-4.8.5-qclipboard-delay.patch qtgui-4.8.5-cleanlooks-floating-point-exception.patch
Date: Thu, 03 Jul 2014 23:20:31
Message-Id: 20140703232026.984732004E@flycatcher.gentoo.org
1 pesa 14/07/03 23:20:26
2
3 Added: qtgui-4.8.5-disable-gtk-theme-check.patch
4 qtgui-4.8.5-qclipboard-delay.patch
5 qtgui-4.8.5-cleanlooks-floating-point-exception.patch
6 Log:
7 Apply various patches wrt bugs #491226, #503880, #507124, and #514968.
8
9 (Portage version: 2.2.10/cvs/Linux x86_64, signed Manifest commit with key 0xDADED6B2671CB57D!)
10
11 Revision Changes Path
12 1.1 dev-qt/qtgui/files/qtgui-4.8.5-disable-gtk-theme-check.patch
13
14 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-qt/qtgui/files/qtgui-4.8.5-disable-gtk-theme-check.patch?rev=1.1&view=markup
15 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-qt/qtgui/files/qtgui-4.8.5-disable-gtk-theme-check.patch?rev=1.1&content-type=text/plain
16
17 Index: qtgui-4.8.5-disable-gtk-theme-check.patch
18 ===================================================================
19 diff -up qt-everywhere-opensource-src-4.8.5/src/gui/styles/qgtkstyle_p.cpp.qgtkstyle_disable_gtk_theme_check qt-everywhere-opensource-src-4.8.5/src/gui/styles/qgtkstyle_p.cpp
20 --- qt-everywhere-opensource-src-4.8.5/src/gui/styles/qgtkstyle_p.cpp.qgtkstyle_disable_gtk_theme_check 2013-06-09 16:28:22.938840346 -0500
21 +++ qt-everywhere-opensource-src-4.8.5/src/gui/styles/qgtkstyle_p.cpp 2013-06-09 17:03:01.781125479 -0500
22 @@ -503,18 +503,6 @@ void QGtkStylePrivate::initGtkWidgets()
23 return;
24 }
25
26 - static QString themeName;
27 - if (!gtkWidgetMap()->contains("GtkWindow") && themeName.isEmpty()) {
28 - themeName = getThemeName();
29 -
30 - if (themeName == QLS("Qt") || themeName == QLS("Qt4")) {
31 - // Due to namespace conflicts with Qt3 and obvious recursion with Qt4,
32 - // we cannot support the GTK_Qt Gtk engine
33 - qWarning("QGtkStyle cannot be used together with the GTK_Qt engine.");
34 - return;
35 - }
36 - }
37 -
38 if (QGtkStylePrivate::gtk_init) {
39 // Gtk will set the Qt error handler so we have to reset it afterwards
40 x11ErrorHandler qt_x_errhandler = XSetErrorHandler(0);
41
42
43
44 1.1 dev-qt/qtgui/files/qtgui-4.8.5-qclipboard-delay.patch
45
46 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-qt/qtgui/files/qtgui-4.8.5-qclipboard-delay.patch?rev=1.1&view=markup
47 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-qt/qtgui/files/qtgui-4.8.5-qclipboard-delay.patch?rev=1.1&content-type=text/plain
48
49 Index: qtgui-4.8.5-qclipboard-delay.patch
50 ===================================================================
51 From a83ddc5212736f89a0b94667c495494fe6861d63 Mon Sep 17 00:00:00 2001
52 From: Michael Palimaka <kensington@g.o>
53 Date: Mon, 16 Jun 2014 23:52:24 +1000
54 Subject: Fix delay with QClipboard and useEventLoop.
55
56 This manifests when using LibreOffice with KDE integration. When KFileDialog is
57 open, the clipboard is repeatedly polled causing a visible delay since using
58 QClipboard in "useEventLoop" mode adds 50ms delay to every single clipboard
59 fetch.
60
61 Change-Id: Id30cda7b983ae7c949fa270d04f772fa44fc21cd
62 Task-number: QTBUG-38585
63 ---
64 src/gui/kernel/qclipboard_x11.cpp | 3 ++-
65 1 file changed, 2 insertions(+), 1 deletion(-)
66
67 diff --git a/src/gui/kernel/qclipboard_x11.cpp b/src/gui/kernel/qclipboard_x11.cpp
68 index 14bf088..5f442b9 100644
69 --- a/src/gui/kernel/qclipboard_x11.cpp
70 +++ b/src/gui/kernel/qclipboard_x11.cpp
71 @@ -548,7 +548,8 @@ bool QX11Data::clipboardWaitForEvent(Window win, int type, XEvent *event, int ti
72 return false;
73
74 XSync(X11->display, false);
75 - usleep(50000);
76 + if (!XPending(X11->display))
77 + usleep(5000);
78
79 now.start();
80
81 --
82 2.0.0
83
84
85
86
87 1.1 dev-qt/qtgui/files/qtgui-4.8.5-cleanlooks-floating-point-exception.patch
88
89 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-qt/qtgui/files/qtgui-4.8.5-cleanlooks-floating-point-exception.patch?rev=1.1&view=markup
90 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-qt/qtgui/files/qtgui-4.8.5-cleanlooks-floating-point-exception.patch?rev=1.1&content-type=text/plain
91
92 Index: qtgui-4.8.5-cleanlooks-floating-point-exception.patch
93 ===================================================================
94 From 0db65e148dcb4d5e5b98475f207d41a287c401a1 Mon Sep 17 00:00:00 2001
95 From: Alexandre Rostovtsev <tetromino@g.o>
96 Date: Wed, 28 May 2014 00:22:55 -0400
97 Subject: [PATCH] Cleanlooks style: Fix floating point exception
98
99 In QCleanlooksStyle::drawControl, if indeterminate == true and
100 rect.width() == 4, we will end up with slideWidth of zero, and
101 take a mod by zero when calculating the value of step.
102
103 This causes a crash in Quassel 0.10; see
104 https://bugs.gentoo.org/show_bug.cgi?id=507124
105
106 Instead, calculate slideWidth based on max(width, minWidth) where
107 minWidth was already set as 4, ensuring that slideWidth >= 2.
108
109 Change-Id: I6678789105e359fa26c99409f449cad0ba3bd0ae
110 (cherry picked from qtstyleplugins/8ff2ac6035fb1d01f5c0054ba14afb949410e3a7)
111 Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@××××.com>
112 ---
113 src/gui/styles/qcleanlooksstyle.cpp | 2 +-
114 1 file changed, 1 insertion(+), 1 deletion(-)
115
116 diff --git a/src/gui/styles/qcleanlooksstyle.cpp b/src/gui/styles/qcleanlooksstyle.cpp
117 index 504734a..3f665ca 100644
118 --- a/src/gui/styles/qcleanlooksstyle.cpp
119 +++ b/src/gui/styles/qcleanlooksstyle.cpp
120 @@ -1773,7 +1773,7 @@ void QCleanlooksStyle::drawControl(ControlElement element, const QStyleOption *o
121 }
122 } else {
123 Q_D(const QCleanlooksStyle);
124 - int slideWidth = ((rect.width() - 4) * 2) / 3;
125 + int slideWidth = (qMax(rect.width() - 4, minWidth) * 2) / 3;
126 int step = ((d->animateStep * slideWidth) / d->animationFps) % slideWidth;
127 if ((((d->animateStep * slideWidth) / d->animationFps) % (2 * slideWidth)) >= slideWidth)
128 step = slideWidth - step;
129 --
130 2.0.0