1 |
commit: aefd51cd66b73a46463563aa2a11410a93061b0d |
2 |
Author: Viorel Munteanu <ceamac.paragon <AT> gmail <DOT> com> |
3 |
AuthorDate: Sat May 21 15:14:40 2022 +0000 |
4 |
Commit: Sam James <sam <AT> gentoo <DOT> org> |
5 |
CommitDate: Thu Jun 30 21:40:16 2022 +0000 |
6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aefd51cd |
7 |
|
8 |
sys-apps/busybox: fix bugs reported by shellcheck |
9 |
|
10 |
Closes: https://bugs.gentoo.org/839171 |
11 |
Signed-off-by: Viorel Munteanu <ceamac.paragon <AT> gmail.com> |
12 |
Closes: https://github.com/gentoo/gentoo/pull/25062 |
13 |
Signed-off-by: Sam James <sam <AT> gentoo.org> |
14 |
|
15 |
sys-apps/busybox/files/mdev/dvbdev | 8 +++--- |
16 |
sys-apps/busybox/files/mdev/ide_links | 20 +++++++-------- |
17 |
sys-apps/busybox/files/mdev/usbdev | 42 ++++++++++++++++---------------- |
18 |
sys-apps/busybox/files/mdev/usbdisk_link | 36 +++++++++++++++------------ |
19 |
4 files changed, 55 insertions(+), 51 deletions(-) |
20 |
|
21 |
diff --git a/sys-apps/busybox/files/mdev/dvbdev b/sys-apps/busybox/files/mdev/dvbdev |
22 |
index f0186c176cd8..971b0efc9096 100644 |
23 |
--- a/sys-apps/busybox/files/mdev/dvbdev |
24 |
+++ b/sys-apps/busybox/files/mdev/dvbdev |
25 |
@@ -8,11 +8,11 @@ DVB_DEV=${MDEV#*.} |
26 |
|
27 |
case "$ACTION" in |
28 |
add|"") |
29 |
- mkdir -p dvb/adapter${N} |
30 |
- mv ${MDEV} dvb/adapter${N}/${DVB_DEV} |
31 |
+ mkdir -p "dvb/adapter${N}" |
32 |
+ mv "${MDEV}" "dvb/adapter${N}/${DVB_DEV}" |
33 |
;; |
34 |
remove) |
35 |
- rm -f dvb/adapter${N}/${DVB_DEV} |
36 |
- rmdir dvb/adapter${N} 2>/dev/null |
37 |
+ rm -f "dvb/adapter${N}/${DVB_DEV}" |
38 |
+ rmdir "dvb/adapter${N}" 2>/dev/null |
39 |
rmdir dvb/ 2>/dev/null |
40 |
esac |
41 |
|
42 |
diff --git a/sys-apps/busybox/files/mdev/ide_links b/sys-apps/busybox/files/mdev/ide_links |
43 |
index be0c95aa9c0e..dfb7c9cb46d5 100644 |
44 |
--- a/sys-apps/busybox/files/mdev/ide_links |
45 |
+++ b/sys-apps/busybox/files/mdev/ide_links |
46 |
@@ -1,23 +1,23 @@ |
47 |
#!/bin/sh |
48 |
|
49 |
-[ -f /proc/ide/$MDEV/media ] || exit |
50 |
+[ -f /proc/ide/"${MDEV}"/media ] || exit |
51 |
|
52 |
-media=`cat /proc/ide/$MDEV/media` |
53 |
-for i in $media $media[0-9]* ; do |
54 |
- if [ "`readlink $i 2>/dev/null`" = $MDEV ] ; then |
55 |
- LINK=$i |
56 |
+media=$(cat /proc/ide/"${MDEV}"/media) |
57 |
+for i in "${media}" "${media}"[0-9]* ; do |
58 |
+ if [ "$(readlink "$i" 2>/dev/null)" = "${MDEV}" ] ; then |
59 |
+ LINK="$i" |
60 |
break |
61 |
fi |
62 |
done |
63 |
|
64 |
# link exist, remove if necessary and exit |
65 |
-if [ "$LINK" ] ; then |
66 |
- [ "$ACTION" = remove ] && rm $LINK |
67 |
+if [ "${LINK}" ] ; then |
68 |
+ [ "${ACTION}" = remove ] && rm "${LINK}" |
69 |
exit |
70 |
fi |
71 |
|
72 |
# create a link |
73 |
-num=`ls $media[0-9]* 2>/dev/null | wc -l` |
74 |
-ln -sf $MDEV "$media`echo $num`" |
75 |
-[ -e "$media" ] || ln -sf $MDEV "$media" |
76 |
+num=$(ls "${media}"[0-9]* 2>/dev/null | wc -l) |
77 |
+ln -sf "${MDEV}" "${media}${num}" |
78 |
+[ -e "${media}" ] || ln -sf "${MDEV}" "${media}" |
79 |
|
80 |
|
81 |
diff --git a/sys-apps/busybox/files/mdev/usbdev b/sys-apps/busybox/files/mdev/usbdev |
82 |
index ea5b9155736c..eda3825df287 100644 |
83 |
--- a/sys-apps/busybox/files/mdev/usbdev |
84 |
+++ b/sys-apps/busybox/files/mdev/usbdev |
85 |
@@ -5,7 +5,7 @@ |
86 |
|
87 |
# add zeros to device or bus |
88 |
add_zeros () { |
89 |
- case "$(echo $1 | wc -L)" in |
90 |
+ case "$(echo "$1" | wc -L)" in |
91 |
1) echo "00$1" ;; |
92 |
2) echo "0$1" ;; |
93 |
*) echo "$1" |
94 |
@@ -15,48 +15,48 @@ add_zeros () { |
95 |
|
96 |
|
97 |
# bus and device dirs in /sys |
98 |
-USB_PATH=$(echo $MDEV | sed -e 's/usbdev\([0-9]\).[0-9]/usb\1/') |
99 |
-USB_PATH=$(find /sys/devices -type d -name "$USB_PATH") |
100 |
-USB_DEV_DIR=$(echo $MDEV | sed -e 's/usbdev\([0-9]\).\([0-9]\)/\1-\2/') |
101 |
+USB_PATH=$(echo "${MDEV}" | sed -e 's/usbdev\([0-9]\).[0-9]/usb\1/') |
102 |
+USB_PATH=$(find /sys/devices -type d -name "${USB_PATH}") |
103 |
+USB_DEV_DIR=$(echo "${MDEV}" | sed -e 's/usbdev\([0-9]\).\([0-9]\)/\1-\2/') |
104 |
|
105 |
# dir names in /dev |
106 |
-BUS=$(add_zeros $(echo $MDEV | sed -e 's/^usbdev\([0-9]\).[0-9]/\1/')) |
107 |
-USB_DEV=$(add_zeros $(echo $MDEV | sed -e 's/^usbdev[0-9].\([0-9]\)/\1/')) |
108 |
+BUS=$(add_zeros "$(echo "${MDEV}" | sed -e 's/^usbdev\([0-9]\).[0-9]/\1/')") |
109 |
+USB_DEV=$(add_zeros "$(echo "${MDEV}" | sed -e 's/^usbdev[0-9].\([0-9]\)/\1/')") |
110 |
|
111 |
|
112 |
# try to load the proper driver for usb devices |
113 |
-case "$ACTION" in |
114 |
+case "${ACTION}" in |
115 |
add|"") |
116 |
# load usb bus driver |
117 |
- for i in $USB_PATH/*/modalias ; do |
118 |
- modprobe `cat $i` 2>/dev/null |
119 |
+ for i in "${USB_PATH}"/*/modalias ; do |
120 |
+ modprobe "$(cat "$i")" 2>/dev/null |
121 |
done |
122 |
# load usb device driver if existent |
123 |
- if [ -d $USB_PATH/$USB_DEV_DIR ]; then |
124 |
- for i in $USB_PATH/$USB_DEV_DIR/*/modalias ; do |
125 |
- modprobe `cat $i` 2>/dev/null |
126 |
+ if [ -d "${USB_PATH}/${USB_DEV_DIR}" ]; then |
127 |
+ for i in "${USB_PATH}/${USB_DEV_DIR}"/*/modalias ; do |
128 |
+ modprobe "$(cat "$i")" 2>/dev/null |
129 |
done |
130 |
fi |
131 |
# move usb device file |
132 |
- mkdir -p bus/usb/$BUS |
133 |
- mv $MDEV bus/usb/$BUS/$USB_DEV |
134 |
+ mkdir -p "bus/usb/${BUS}" |
135 |
+ mv "${MDEV}" "bus/usb/${BUS}/${USB_DEV}" |
136 |
;; |
137 |
remove) |
138 |
# unload device driver, if device dir is existent |
139 |
- if [ -d $USB_PATH/$USB_DEV_DIR ]; then |
140 |
- for i in $USB_PATH/$USB_DEV_DIR/*/modalias ; do |
141 |
- modprobe -r `cat $i` 2>/dev/null |
142 |
+ if [ -d "${USB_PATH}/${USB_DEV_DIR}" ]; then |
143 |
+ for i in "${USB_PATH}/${USB_DEV_DIR}"/*/modalias ; do |
144 |
+ modprobe -r "$(cat "$i")" 2>/dev/null |
145 |
done |
146 |
fi |
147 |
# unload usb bus driver. Does this make sense? |
148 |
# what happens, if two usb devices are plugged in |
149 |
# and one is removed? |
150 |
- for i in $USB_PATH/*/modalias ; do |
151 |
- modprobe -r `cat $i` 2>/dev/null |
152 |
+ for i in "${USB_PATH}"/*/modalias ; do |
153 |
+ modprobe -r "$(cat "$i")" 2>/dev/null |
154 |
done |
155 |
# remove device file and possible empty dirs |
156 |
- rm -f bus/usb/$BUS/$USB_DEV |
157 |
- rmdir bus/usb/$BUS/ 2>/dev/null |
158 |
+ rm -f "bus/usb/${BUS}/${USB_DEV}" |
159 |
+ rmdir "bus/usb/${BUS}/" 2>/dev/null |
160 |
rmdir bus/usb/ 2>/dev/null |
161 |
rmdir bus/ 2>/dev/null |
162 |
esac |
163 |
|
164 |
diff --git a/sys-apps/busybox/files/mdev/usbdisk_link b/sys-apps/busybox/files/mdev/usbdisk_link |
165 |
index 6bb069243f4c..e42cc8bc9085 100644 |
166 |
--- a/sys-apps/busybox/files/mdev/usbdisk_link |
167 |
+++ b/sys-apps/busybox/files/mdev/usbdisk_link |
168 |
@@ -4,31 +4,35 @@ |
169 |
|
170 |
current=$(readlink usbdisk) |
171 |
|
172 |
-if [ "$current" = "$MDEV" ] && [ "$ACTION" = "remove" ]; then |
173 |
+if [ "${current}" = "${MDEV}" ] && [ "${ACTION}" = "remove" ]; then |
174 |
rm -f usbdisk usba1 |
175 |
fi |
176 |
-[ -n "$current" ] && exit |
177 |
+[ -n "${current}" ] && exit |
178 |
|
179 |
-if [ -e /sys/block/$MDEV ]; then |
180 |
- SYSDEV=$(readlink -f /sys/block/$MDEV/device) |
181 |
+if [ -e /sys/block/"${MDEV}" ]; then |
182 |
+ SYSDEV=$(readlink -f /sys/block/"${MDEV}"/device) |
183 |
# if /sys device path contains '/usb[0-9]' then we assume its usb |
184 |
# also, if it's a usb without partitions we require FAT |
185 |
- if [ "${SYSDEV##*/usb[0-9]}" != "$SYSDEV" ]; then |
186 |
+ if [ "${SYSDEV##*/usb[0-9]}" != "${SYSDEV}" ]; then |
187 |
# do not create link if there is not FAT |
188 |
- dd if=/dev/$MDEV bs=512 count=1 2>/dev/null | strings | grep FAT >/dev/null || exit 0 |
189 |
+ dd if=/dev/"${MDEV}" bs=512 count=1 2>/dev/null | strings | grep FAT >/dev/null || exit 0 |
190 |
|
191 |
- ln -sf $MDEV usbdisk |
192 |
+ ln -sf "${MDEV}" usbdisk |
193 |
# keep this for compat. people have it in fstab |
194 |
- ln -sf $MDEV usba1 |
195 |
+ ln -sf "${MDEV}" usba1 |
196 |
fi |
197 |
|
198 |
-elif [ -e /sys/block/*/$MDEV ] ; then |
199 |
- PARENT=$(dirname /sys/block/*/$MDEV) |
200 |
- SYSDEV=$(readlink -f $PARENT/device) |
201 |
- if [ "${SYSDEV##*/usb[0-9]}" != "$SYSDEV" ]; then |
202 |
- ln -sf $MDEV usbdisk |
203 |
- # keep this for compat. people have it in fstab |
204 |
- ln -sf $MDEV usba1 |
205 |
- fi |
206 |
+else |
207 |
+ for i in /sys/block/*/"${MDEV}"; do |
208 |
+ if [ -e "$i" ]; then |
209 |
+ PARENT=$(dirname "$i") |
210 |
+ SYSDEV=$(readlink -f "${PARENT}"/device) |
211 |
+ if [ "${SYSDEV##*/usb[0-9]}" != "${SYSDEV}" ]; then |
212 |
+ ln -sf "${MDEV}" usbdisk |
213 |
+ # keep this for compat. people have it in fstab |
214 |
+ ln -sf "${MDEV}" usba1 |
215 |
+ fi |
216 |
+ fi |
217 |
+ done |
218 |
fi |