1 |
commit: 5e28fe97e67ab4f3e2d8410a8704156b6bb08555 |
2 |
Author: Zac Medico <zmedico <AT> gentoo <DOT> org> |
3 |
AuthorDate: Thu Aug 30 05:54:51 2012 +0000 |
4 |
Commit: Zac Medico <zmedico <AT> gentoo <DOT> org> |
5 |
CommitDate: Thu Aug 30 05:54:51 2012 +0000 |
6 |
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=5e28fe97 |
7 |
|
8 |
Remove FEATURES=parse-eapi-ebuild-head |
9 |
|
10 |
It's already been enabled by default in stable portage for awhile now, |
11 |
so it should be safe to enable it unconditionally. The PMS eapi-5 |
12 |
branch also says that it's mandatory to parse the EAPI: |
13 |
|
14 |
http://git.overlays.gentoo.org/gitweb/?p=proj/pms.git;a=commit;h=91d1e1e39b034bde7e5b981a5616a127135f37fa |
15 |
|
16 |
--- |
17 |
cnf/make.globals | 2 +- |
18 |
man/make.conf.5 | 5 ----- |
19 |
pym/_emerge/EbuildMetadataPhase.py | 6 ++---- |
20 |
pym/portage/const.py | 1 - |
21 |
pym/portage/package/ebuild/_eapi_invalid.py | 13 ------------- |
22 |
pym/portage/tests/emerge/test_simple.py | 2 +- |
23 |
6 files changed, 4 insertions(+), 25 deletions(-) |
24 |
|
25 |
diff --git a/cnf/make.globals b/cnf/make.globals |
26 |
index ce35554..dad2811 100644 |
27 |
--- a/cnf/make.globals |
28 |
+++ b/cnf/make.globals |
29 |
@@ -53,7 +53,7 @@ FETCHCOMMAND_SFTP="bash -c \"x=\\\${2#sftp://} ; host=\\\${x%%/*} ; port=\\\${ho |
30 |
# Default user options |
31 |
FEATURES="assume-digests binpkg-logs |
32 |
config-protect-if-modified distlocks ebuild-locks |
33 |
- fixlafiles news parallel-fetch parse-eapi-ebuild-head protect-owned |
34 |
+ fixlafiles news parallel-fetch protect-owned |
35 |
sandbox sfperms strict unknown-features-warn unmerge-logs |
36 |
unmerge-orphans userfetch" |
37 |
|
38 |
|
39 |
diff --git a/man/make.conf.5 b/man/make.conf.5 |
40 |
index 0118667..d9babe1 100644 |
41 |
--- a/man/make.conf.5 |
42 |
+++ b/man/make.conf.5 |
43 |
@@ -420,11 +420,6 @@ Use finer\-grained locks when installing packages, allowing for greater |
44 |
parallelization. For additional parallelization, disable |
45 |
\fIebuild\-locks\fR. |
46 |
.TP |
47 |
-.B parse\-eapi\-ebuild\-head |
48 |
-Parse \fBEAPI\fR from the head of the ebuild as specified in PMS section |
49 |
-7.3.1, and treat non\-conformant ebuilds as invalid. This feature is |
50 |
-enabled by default, and will soon become enabled unconditionally. |
51 |
-.TP |
52 |
.B prelink\-checksums |
53 |
If \fBprelink\fR(8) is installed then use it to undo any prelinks on files |
54 |
before computing checksums for merge and unmerge. This feature is |
55 |
|
56 |
diff --git a/pym/_emerge/EbuildMetadataPhase.py b/pym/_emerge/EbuildMetadataPhase.py |
57 |
index 9ab03e2..669b4ae 100644 |
58 |
--- a/pym/_emerge/EbuildMetadataPhase.py |
59 |
+++ b/pym/_emerge/EbuildMetadataPhase.py |
60 |
@@ -142,8 +142,7 @@ class EbuildMetadataPhase(SubProcess): |
61 |
def _set_returncode(self, wait_retval): |
62 |
SubProcess._set_returncode(self, wait_retval) |
63 |
# self._raw_metadata is None when _start returns |
64 |
- # early due to an unsupported EAPI detected with |
65 |
- # FEATURES=parse-eapi-ebuild-head |
66 |
+ # early due to an unsupported EAPI |
67 |
if self.returncode == os.EX_OK and \ |
68 |
self._raw_metadata is not None: |
69 |
metadata_lines = _unicode_decode(b''.join(self._raw_metadata), |
70 |
@@ -164,8 +163,7 @@ class EbuildMetadataPhase(SubProcess): |
71 |
if (not metadata["EAPI"] or self.eapi_supported) and \ |
72 |
metadata["EAPI"] != parsed_eapi: |
73 |
self._eapi_invalid(metadata) |
74 |
- if 'parse-eapi-ebuild-head' in self.settings.features: |
75 |
- metadata_valid = False |
76 |
+ metadata_valid = False |
77 |
|
78 |
if metadata_valid: |
79 |
# Since we're supposed to be able to efficiently obtain the |
80 |
|
81 |
diff --git a/pym/portage/const.py b/pym/portage/const.py |
82 |
index 6dffc5d..3b8e350 100644 |
83 |
--- a/pym/portage/const.py |
84 |
+++ b/pym/portage/const.py |
85 |
@@ -99,7 +99,6 @@ SUPPORTED_FEATURES = frozenset([ |
86 |
"metadata-transfer", "mirror", "multilib-strict", "news", |
87 |
"noauto", "noclean", "nodoc", "noinfo", "noman", |
88 |
"nostrip", "notitles", "parallel-fetch", "parallel-install", |
89 |
- "parse-eapi-ebuild-head", |
90 |
"prelink-checksums", |
91 |
"protect-owned", "python-trace", "sandbox", |
92 |
"selinux", "sesandbox", "sfperms", |
93 |
|
94 |
diff --git a/pym/portage/package/ebuild/_eapi_invalid.py b/pym/portage/package/ebuild/_eapi_invalid.py |
95 |
index d23677d..bcf1f7f 100644 |
96 |
--- a/pym/portage/package/ebuild/_eapi_invalid.py |
97 |
+++ b/pym/portage/package/ebuild/_eapi_invalid.py |
98 |
@@ -28,19 +28,6 @@ def eapi_invalid(self, cpv, repo_name, settings, |
99 |
"assignment on line: %s") % |
100 |
(eapi_var, eapi_lineno)) |
101 |
|
102 |
- if 'parse-eapi-ebuild-head' in settings.features: |
103 |
- msg.extend(textwrap.wrap(("NOTE: This error will soon" |
104 |
- " become unconditionally fatal in a future version of Portage," |
105 |
- " but at this time, it can by made non-fatal by setting" |
106 |
- " FEATURES=-parse-eapi-ebuild-head in" |
107 |
- " make.conf."), 70)) |
108 |
- else: |
109 |
- msg.extend(textwrap.wrap(("NOTE: This error will soon" |
110 |
- " become unconditionally fatal in a future version of Portage." |
111 |
- " At the earliest opportunity, please enable" |
112 |
- " FEATURES=parse-eapi-ebuild-head in make.conf in order to" |
113 |
- " make this error fatal."), 70)) |
114 |
- |
115 |
if portage.data.secpass >= 2: |
116 |
# TODO: improve elog permission error handling (bug #416231) |
117 |
for line in msg: |
118 |
|
119 |
diff --git a/pym/portage/tests/emerge/test_simple.py b/pym/portage/tests/emerge/test_simple.py |
120 |
index f87170a..77a0554 100644 |
121 |
--- a/pym/portage/tests/emerge/test_simple.py |
122 |
+++ b/pym/portage/tests/emerge/test_simple.py |
123 |
@@ -210,7 +210,7 @@ pkg_preinst() { |
124 |
({"FEATURES" : "metadata-transfer"},) + \ |
125 |
emerge_cmd + ("--regen",), |
126 |
rm_cmd + ("-rf", cachedir), |
127 |
- ({"FEATURES" : "metadata-transfer parse-eapi-ebuild-head"},) + \ |
128 |
+ ({"FEATURES" : "metadata-transfer"},) + \ |
129 |
emerge_cmd + ("--regen",), |
130 |
rm_cmd + ("-rf", cachedir), |
131 |
egencache_cmd + ("--update",) + tuple(egencache_extra_args), |