Gentoo Archives: gentoo-commits

From: Mike Gilbert <floppym@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-boot/systemd-boot/files/
Date: Sun, 29 Sep 2019 02:44:02
Message-Id: 1569725026.407828fc0139a3e9f177f475bab9e540cac76d3e.floppym@gentoo
1 commit: 407828fc0139a3e9f177f475bab9e540cac76d3e
2 Author: Michael Mair-Keimberger <m.mairkeimberger <AT> gmail <DOT> com>
3 AuthorDate: Sat Sep 28 07:44:40 2019 +0000
4 Commit: Mike Gilbert <floppym <AT> gentoo <DOT> org>
5 CommitDate: Sun Sep 29 02:43:46 2019 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=407828fc
7
8 sys-boot/systemd-boot: remove unused patches
9
10 Closes: https://github.com/gentoo/gentoo/pull/13068
11 Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger <AT> gmail.com>
12 Signed-off-by: Mike Gilbert <floppym <AT> gentoo.org>
13
14 sys-boot/systemd-boot/files/239-debug-extra.patch | 40 --------
15 sys-boot/systemd-boot/files/239-stat-0.patch | 108 ----------------------
16 sys-boot/systemd-boot/files/239-stat-1.patch | 74 ---------------
17 3 files changed, 222 deletions(-)
18
19 diff --git a/sys-boot/systemd-boot/files/239-debug-extra.patch b/sys-boot/systemd-boot/files/239-debug-extra.patch
20 deleted file mode 100644
21 index 19db590257c..00000000000
22 --- a/sys-boot/systemd-boot/files/239-debug-extra.patch
23 +++ /dev/null
24 @@ -1,40 +0,0 @@
25 -From 8f6b442a78d0b485f044742ad90b2e8271b4e68e Mon Sep 17 00:00:00 2001
26 -From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@××××××.pl>
27 -Date: Sun, 19 Aug 2018 19:11:30 +0200
28 -Subject: [PATCH] meson: rename -Ddebug to -Ddebug-extra
29 -
30 -Meson added -Doptimization and -Ddebug options, which obviously causes
31 -a conflict with our -Ddebug options. Let's rename it.
32 -
33 -Fixes #9883.
34 ----
35 - meson.build | 2 +-
36 - meson_options.txt | 2 +-
37 - 2 files changed, 2 insertions(+), 2 deletions(-)
38 -
39 -diff --git a/meson.build b/meson.build
40 -index f79ac4b12e7..2209c935ad6 100644
41 ---- a/meson.build
42 -+++ b/meson.build
43 -@@ -763,7 +763,7 @@ substs.set('DEBUGTTY', get_option('debug-tty'))
44 -
45 - enable_debug_hashmap = false
46 - enable_debug_mmap_cache = false
47 --foreach name : get_option('debug')
48 -+foreach name : get_option('debug-extra')
49 - if name == 'hashmap'
50 - enable_debug_hashmap = true
51 - elif name == 'mmap-cache'
52 -diff --git a/meson_options.txt b/meson_options.txt
53 -index e3140c8c110..7b1f61bf464 100644
54 ---- a/meson_options.txt
55 -+++ b/meson_options.txt
56 -@@ -45,7 +45,7 @@ option('debug-shell', type : 'string', value : '/bin/sh',
57 - description : 'path to debug shell binary')
58 - option('debug-tty', type : 'string', value : '/dev/tty9',
59 - description : 'specify the tty device for debug shell')
60 --option('debug', type : 'array', choices : ['hashmap', 'mmap-cache'], value : [],
61 -+option('debug-extra', type : 'array', choices : ['hashmap', 'mmap-cache'], value : [],
62 - description : 'enable extra debugging')
63 - option('memory-accounting-default', type : 'boolean',
64 - description : 'enable MemoryAccounting= by default')
65
66 diff --git a/sys-boot/systemd-boot/files/239-stat-0.patch b/sys-boot/systemd-boot/files/239-stat-0.patch
67 deleted file mode 100644
68 index e136b703a2f..00000000000
69 --- a/sys-boot/systemd-boot/files/239-stat-0.patch
70 +++ /dev/null
71 @@ -1,108 +0,0 @@
72 -From 75720bff62a84896e9a0654afc7cf9408cf89a38 Mon Sep 17 00:00:00 2001
73 -From: Filipe Brandenburger <filbranden@××××××.com>
74 -Date: Sun, 15 Jul 2018 22:43:35 -0700
75 -Subject: [PATCH] build-sys: Detect whether struct statx is defined in
76 - sys/stat.h
77 -MIME-Version: 1.0
78 -Content-Type: text/plain; charset=UTF-8
79 -Content-Transfer-Encoding: 8bit
80 -
81 -Starting with glibc 2.27.9000-36.fc29, include file sys/stat.h will have a
82 -definition for struct statx, in which case include file linux/stat.h should be
83 -avoided, in order to prevent a duplicate definition.
84 -
85 - In file included from ../src/basic/missing.h:18,
86 - from ../src/basic/util.h:28,
87 - from ../src/basic/hashmap.h:10,
88 - from ../src/shared/bus-util.h:12,
89 - from ../src/libsystemd/sd-bus/bus-creds.c:11:
90 - /usr/include/linux/stat.h:99:8: error: redefinition of ‘struct statx’
91 - struct statx {
92 - ^~~~~
93 - In file included from /usr/include/sys/stat.h:446,
94 - from ../src/basic/util.h:19,
95 - from ../src/basic/hashmap.h:10,
96 - from ../src/shared/bus-util.h:12,
97 - from ../src/libsystemd/sd-bus/bus-creds.c:11:
98 - /usr/include/bits/statx.h:36:8: note: originally defined here
99 - struct statx
100 - ^~~~~
101 -
102 -Extend our meson.build to look for struct statx when only sys/stat.h is
103 -included and, in that case, do not include linux/stat.h anymore.
104 -
105 -Tested that systemd builds correctly when using a glibc version that includes a
106 -definition for struct statx.
107 -
108 -glibc Fedora RPM update:
109 -https://src.fedoraproject.org/rpms/glibc/c/28cb5d31fc1e5887912283c889689c47076278ae
110 -
111 -glibc upstream commit:
112 -https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=fd70af45528d59a00eb3190ef6706cb299488fcd
113 ----
114 - meson.build | 5 +++++
115 - src/basic/missing.h | 5 ++++-
116 - src/basic/xattr-util.c | 1 -
117 - 3 files changed, 9 insertions(+), 2 deletions(-)
118 -
119 -diff --git a/meson.build b/meson.build
120 -index dd904c7148..68423bdfa5 100644
121 ---- a/meson.build
122 -+++ b/meson.build
123 -@@ -425,6 +425,7 @@ decl_headers = '''
124 - #include <sys/stat.h>
125 - '''
126 - # FIXME: key_serial_t is only defined in keyutils.h, this is bound to fail
127 -+# FIXME: these should use -D_GNU_SOURCE, since that is defined at build time
128 -
129 - foreach decl : ['char16_t',
130 - 'char32_t',
131 -@@ -439,6 +440,10 @@ foreach decl : ['char16_t',
132 - conf.set10('HAVE_' + decl.underscorify().to_upper(), have)
133 - endforeach
134 -
135 -+conf.set10('HAVE_STRUCT_STATX_IN_SYS_STAT_H', cc.sizeof('struct statx', prefix : '''
136 -+#include <sys/stat.h>
137 -+''', args : '-D_GNU_SOURCE') > 0)
138 -+
139 - foreach decl : [['IFLA_INET6_ADDR_GEN_MODE', 'linux/if_link.h'],
140 - ['IN6_ADDR_GEN_MODE_STABLE_PRIVACY', 'linux/if_link.h'],
141 - ['IFLA_VRF_TABLE', 'linux/if_link.h'],
142 -diff --git a/src/basic/missing.h b/src/basic/missing.h
143 -index 71a07d0574..14ad3d4914 100644
144 ---- a/src/basic/missing.h
145 -+++ b/src/basic/missing.h
146 -@@ -15,7 +15,6 @@
147 - #include <linux/neighbour.h>
148 - #include <linux/oom.h>
149 - #include <linux/rtnetlink.h>
150 --#include <linux/stat.h>
151 - #include <net/ethernet.h>
152 - #include <stdlib.h>
153 - #include <sys/resource.h>
154 -@@ -25,6 +24,10 @@
155 - #include <uchar.h>
156 - #include <unistd.h>
157 -
158 -+#if !HAVE_STRUCT_STATX_IN_SYS_STAT_H
159 -+#include <linux/stat.h>
160 -+#endif
161 -+
162 - #if HAVE_AUDIT
163 - #include <libaudit.h>
164 - #endif
165 -diff --git a/src/basic/xattr-util.c b/src/basic/xattr-util.c
166 -index c5c55ea846..0ee0979837 100644
167 ---- a/src/basic/xattr-util.c
168 -+++ b/src/basic/xattr-util.c
169 -@@ -2,7 +2,6 @@
170 -
171 - #include <errno.h>
172 - #include <fcntl.h>
173 --#include <linux/stat.h>
174 - #include <stdint.h>
175 - #include <stdlib.h>
176 - #include <string.h>
177 ---
178 -2.19.1
179 -
180
181 diff --git a/sys-boot/systemd-boot/files/239-stat-1.patch b/sys-boot/systemd-boot/files/239-stat-1.patch
182 deleted file mode 100644
183 index 1104de3c9c1..00000000000
184 --- a/sys-boot/systemd-boot/files/239-stat-1.patch
185 +++ /dev/null
186 @@ -1,74 +0,0 @@
187 -From 9c869d08d82c73f62ab3527567858ce4b0cf1257 Mon Sep 17 00:00:00 2001
188 -From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= <zbyszek@××××××.pl>
189 -Date: Wed, 18 Jul 2018 17:26:17 +0200
190 -Subject: [PATCH] meson: unify linux/stat.h check with other checks and use
191 - _GNU_SOURCE
192 -
193 -Using _GNU_SOURCE is better because that's how we include the headers in the
194 -actual build, and some headers define different stuff when it is defined.
195 -sys/stat.h for example defines 'struct statx' conditionally.
196 ----
197 - meson.build | 20 ++++++++++++++------
198 - src/basic/missing.h | 2 +-
199 - 2 files changed, 15 insertions(+), 7 deletions(-)
200 -
201 -diff --git a/meson.build b/meson.build
202 -index 68423bdfa5..99035d2306 100644
203 ---- a/meson.build
204 -+++ b/meson.build
205 -@@ -421,11 +421,9 @@ decl_headers = '''
206 - #include <uchar.h>
207 - #include <linux/ethtool.h>
208 - #include <linux/fib_rules.h>
209 --#include <linux/stat.h>
210 - #include <sys/stat.h>
211 - '''
212 - # FIXME: key_serial_t is only defined in keyutils.h, this is bound to fail
213 --# FIXME: these should use -D_GNU_SOURCE, since that is defined at build time
214 -
215 - foreach decl : ['char16_t',
216 - 'char32_t',
217 -@@ -436,13 +434,23 @@ foreach decl : ['char16_t',
218 - ]
219 -
220 - # We get -1 if the size cannot be determined
221 -- have = cc.sizeof(decl, prefix : decl_headers) > 0
222 -+ have = cc.sizeof(decl, prefix : decl_headers, args : '-D_GNU_SOURCE') > 0
223 -+
224 -+ if decl == 'struct statx'
225 -+ if have
226 -+ want_linux_stat_h = false
227 -+ else
228 -+ have = cc.sizeof(decl,
229 -+ prefix : decl_headers + '#include <linux/stat.h>',
230 -+ args : '-D_GNU_SOURCE') > 0
231 -+ want_linux_stat_h = have
232 -+ endif
233 -+ endif
234 -+
235 - conf.set10('HAVE_' + decl.underscorify().to_upper(), have)
236 - endforeach
237 -
238 --conf.set10('HAVE_STRUCT_STATX_IN_SYS_STAT_H', cc.sizeof('struct statx', prefix : '''
239 --#include <sys/stat.h>
240 --''', args : '-D_GNU_SOURCE') > 0)
241 -+conf.set10('WANT_LINUX_STAT_H', want_linux_stat_h)
242 -
243 - foreach decl : [['IFLA_INET6_ADDR_GEN_MODE', 'linux/if_link.h'],
244 - ['IN6_ADDR_GEN_MODE_STABLE_PRIVACY', 'linux/if_link.h'],
245 -diff --git a/src/basic/missing.h b/src/basic/missing.h
246 -index 14ad3d4914..9044683b15 100644
247 ---- a/src/basic/missing.h
248 -+++ b/src/basic/missing.h
249 -@@ -24,7 +24,7 @@
250 - #include <uchar.h>
251 - #include <unistd.h>
252 -
253 --#if !HAVE_STRUCT_STATX_IN_SYS_STAT_H
254 -+#if WANT_LINUX_STAT_H
255 - #include <linux/stat.h>
256 - #endif
257 -
258 ---
259 -2.19.1
260 -