1 |
commit: e66efe48672dc9ad463df7d3d842ae08e20bedd6 |
2 |
Author: André Erdmann <dywi <AT> mailerd <DOT> de> |
3 |
AuthorDate: Thu Jun 28 15:48:00 2012 +0000 |
4 |
Commit: André Erdmann <dywi <AT> mailerd <DOT> de> |
5 |
CommitDate: Thu Jun 28 15:48:00 2012 +0000 |
6 |
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/R_overlay.git;a=commit;h=e66efe48 |
7 |
|
8 |
use sets/tuples instead of lists |
9 |
|
10 |
--- |
11 |
roverlay/rpackage/descriptionfields.py | 16 ++++++++-------- |
12 |
1 files changed, 8 insertions(+), 8 deletions(-) |
13 |
|
14 |
diff --git a/roverlay/rpackage/descriptionfields.py b/roverlay/rpackage/descriptionfields.py |
15 |
index dcb0803..148b757 100644 |
16 |
--- a/roverlay/rpackage/descriptionfields.py |
17 |
+++ b/roverlay/rpackage/descriptionfields.py |
18 |
@@ -291,10 +291,10 @@ class DescriptionFields ( object ): |
19 |
"""Scans all stored DescriptionField(s) and creates fast-accessible |
20 |
data to be used in get_fields_with_<sth> (...). |
21 |
""" |
22 |
- flagmap = dict () |
23 |
+ flagmap = dict() |
24 |
optionmap = dict ( |
25 |
- defaults = dict (), |
26 |
- allowed_values = list () |
27 |
+ defaults = dict(), |
28 |
+ allowed_values = set() |
29 |
) |
30 |
|
31 |
for field_name in self.fields.keys(): |
32 |
@@ -303,12 +303,12 @@ class DescriptionFields ( object ): |
33 |
optionmap ['defaults'] [field_name] = d |
34 |
|
35 |
if self.fields [field_name].allowed_values: |
36 |
- optionmap ['allowed_values'].append ( field_name ) |
37 |
+ optionmap ['allowed_values'].add ( field_name ) |
38 |
|
39 |
for flag in self.fields [field_name].flags: |
40 |
if not flag in flagmap: |
41 |
- flagmap [flag] = list () |
42 |
- flagmap [flag].append ( field_name ) |
43 |
+ flagmap [flag] = set() |
44 |
+ flagmap [flag].add ( field_name ) |
45 |
|
46 |
self._fields_by_flag = flagmap |
47 |
self._fields_by_option = optionmap |
48 |
@@ -331,7 +331,7 @@ class DescriptionFields ( object ): |
49 |
if flag in self._fields_by_flag: |
50 |
return self._fields_by_flag [flag] |
51 |
else: |
52 |
- return [] |
53 |
+ return () |
54 |
|
55 |
# --- end of get_fields_with_flag (...) --- |
56 |
|
57 |
@@ -349,7 +349,7 @@ class DescriptionFields ( object ): |
58 |
if option in self._fields_by_option: |
59 |
return self._fields_by_option [option] |
60 |
else: |
61 |
- return [] |
62 |
+ return () |
63 |
|
64 |
# --- end of get_field_with_option (...) --- |