| 1 |
commit: c88734624727231da02a3f610c9af0fda70fc1d0 |
| 2 |
Author: Robin H. Johnson <robbat2 <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Sun Apr 21 05:23:22 2019 +0000 |
| 4 |
Commit: Robin H. Johnson <robbat2 <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Sun Apr 21 05:33:35 2019 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=c8873462 |
| 7 |
|
| 8 |
init.d/net.lo.in: shellcheck: PROVIDEDBY MODULE trample |
| 9 |
|
| 10 |
This is a logic error caught by shellcheck. The nested loops used the |
| 11 |
same index variable, so the outer loop progress could get trampled. |
| 12 |
|
| 13 |
Signed-off-by: Robin H. Johnson <robbat2 <AT> gentoo.org> |
| 14 |
|
| 15 |
init.d/net.lo.in | 10 +++++----- |
| 16 |
1 file changed, 5 insertions(+), 5 deletions(-) |
| 17 |
|
| 18 |
diff --git a/init.d/net.lo.in b/init.d/net.lo.in |
| 19 |
index 961d9fa..a958598 100644 |
| 20 |
--- a/init.d/net.lo.in |
| 21 |
+++ b/init.d/net.lo.in |
| 22 |
@@ -369,14 +369,14 @@ _gen_module_list() |
| 23 |
VISITED="${VISITED} $1" |
| 24 |
|
| 25 |
eval AFTER=\$${1}_after |
| 26 |
- for MODULE in ${AFTER}; do |
| 27 |
- eval PROVIDEDBY=\$${MODULE}_providedby |
| 28 |
+ for MODULE1 in ${AFTER}; do |
| 29 |
+ eval PROVIDEDBY=\$${MODULE1}_providedby |
| 30 |
if [ -n "${PROVIDEDBY}" ]; then |
| 31 |
- for MODULE in ${PROVIDEDBY}; do |
| 32 |
- visit "${MODULE}" |
| 33 |
+ for MODULE2 in ${PROVIDEDBY}; do |
| 34 |
+ visit "${MODULE2}" |
| 35 |
done |
| 36 |
else |
| 37 |
- visit "${MODULE}" |
| 38 |
+ visit "${MODULE1}" |
| 39 |
fi |
| 40 |
done |
Archives