| 1 |
commit: 318e87348168e37d78f433d3ff06288ad8ccf15c |
| 2 |
Author: William Hubbs <w.d.hubbs <AT> gmail <DOT> com> |
| 3 |
AuthorDate: Tue Nov 14 20:11:57 2017 +0000 |
| 4 |
Commit: William Hubbs <williamh <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Tue Nov 14 21:41:03 2017 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/proj/openrc.git/commit/?id=318e8734 |
| 7 |
|
| 8 |
strongly encourage Linux users to not make /etc/mtab a flat file |
| 9 |
|
| 10 |
The OpenRC team does not currently know of any modern linux tools that |
| 11 |
require /etc/mtab to be a flat file, so this puts users on notice that |
| 12 |
the mtab service will be removed in the future. |
| 13 |
|
| 14 |
NEWS.md | 15 +++++++++++++++ |
| 15 |
conf.d/mtab | 14 +++++++++++--- |
| 16 |
init.d/mtab.in | 4 ++++ |
| 17 |
3 files changed, 30 insertions(+), 3 deletions(-) |
| 18 |
|
| 19 |
diff --git a/NEWS.md b/NEWS.md |
| 20 |
index 1a98da2a..9982e9bd 100644 |
| 21 |
--- a/NEWS.md |
| 22 |
+++ b/NEWS.md |
| 23 |
@@ -3,6 +3,21 @@ |
| 24 |
This file will contain a list of notable changes for each release. Note |
| 25 |
the information in this file is in reverse order. |
| 26 |
|
| 27 |
+## OpenRC 0.35 |
| 28 |
+ |
| 29 |
+Consider this your second notification with regard to /etc/mtab being a |
| 30 |
+file instead of a symbolic link. |
| 31 |
+ |
| 32 |
+In this version, the mtab service will complain loudly if you have |
| 33 |
+mtab_is_file set to yes and recommend that you change this to no and |
| 34 |
+restart the mtab service to migrate /etc/mtab to a symbolic link. |
| 35 |
+ |
| 36 |
+If there is a valid technical reason to keep /etc/mtab as a flat file |
| 37 |
+instead of a symbolic link to /proc/self/mounts, we are interested and |
| 38 |
+we will keep the support in that case. Please open an issue and let us |
| 39 |
+know however. Otherwise, consider this your final notice that the mtab |
| 40 |
+service will be removed in the future. |
| 41 |
+ |
| 42 |
## OpenRC 0.33 |
| 43 |
|
| 44 |
This version removes the "service" binary which was just a copy of |
| 45 |
|
| 46 |
diff --git a/conf.d/mtab b/conf.d/mtab |
| 47 |
index 9e16d9b3..f58fad6c 100644 |
| 48 |
--- a/conf.d/mtab |
| 49 |
+++ b/conf.d/mtab |
| 50 |
@@ -1,5 +1,13 @@ |
| 51 |
+# As far as we are aware, there are no modern linux tools or use cases |
| 52 |
+# which require /etc/mtab to be a separate file from /proc/self/mounts, |
| 53 |
+# so this setting should be commented out. |
| 54 |
+# If it is set to yes, please comment it out and run this command: |
| 55 |
+# # rc-service mtab restart |
| 56 |
+# In the future, the mtab service will be removed since we are not aware |
| 57 |
+# of any need to manipulate /etc/mtab as a separate file from |
| 58 |
+# /proc/self/mounts. |
| 59 |
+# If you have a technical reason we should keep this support, please |
| 60 |
+# open an issue at https://github.com/openrc/openrc/issues and let us |
| 61 |
+# know about your situation. |
| 62 |
# This setting controls whether /etc/mtab is a file or symbolic link. |
| 63 |
-# Most of the time, you shouldn't touch this. However, if the default |
| 64 |
-# breaks your system in some way, please see the NEWS.md file that comes |
| 65 |
-# with OpenRC for the actions to take. |
| 66 |
# mtab_is_file=no |
| 67 |
|
| 68 |
diff --git a/init.d/mtab.in b/init.d/mtab.in |
| 69 |
index 9e0c1a6e..bac8230f 100644 |
| 70 |
--- a/init.d/mtab.in |
| 71 |
+++ b/init.d/mtab.in |
| 72 |
@@ -31,6 +31,10 @@ start() |
| 73 |
einfo "Creating mtab symbolic link" |
| 74 |
ln -snf /proc/self/mounts /etc/mtab |
| 75 |
else |
| 76 |
+ ewarn "The ${RC_SVCNAME} service will be removed in the future." |
| 77 |
+ ewarn "Please change the mtab_is_file setting to no and run" |
| 78 |
+ ewarn "# rc-service mtab restart" |
| 79 |
+ ewarn "to create the mtab symbolic link." |
| 80 |
[ -L /etc/mtab ] && ewarn "Removing /etc/mtab symbolic link" |
| 81 |
rm -f /etc/mtab |
| 82 |
einfo "Creating mtab file" |
Archives