| 1 |
commit: f72795c60b475cc36501ed03b7b3a03c38bcf851 |
| 2 |
Author: Sam James <sam <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Sun Mar 21 02:50:27 2021 +0000 |
| 4 |
Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Tue Mar 30 18:14:56 2021 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=f72795c6 |
| 7 |
|
| 8 |
ebuild-writing/common-mistakes: mention "the compiler", not only GCC |
| 9 |
|
| 10 |
Signed-off-by: Sam James <sam <AT> gentoo.org> |
| 11 |
Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org> |
| 12 |
|
| 13 |
ebuild-writing/common-mistakes/text.xml | 15 ++++++++------- |
| 14 |
1 file changed, 8 insertions(+), 7 deletions(-) |
| 15 |
|
| 16 |
diff --git a/ebuild-writing/common-mistakes/text.xml b/ebuild-writing/common-mistakes/text.xml |
| 17 |
index 6f33248..9455688 100644 |
| 18 |
--- a/ebuild-writing/common-mistakes/text.xml |
| 19 |
+++ b/ebuild-writing/common-mistakes/text.xml |
| 20 |
@@ -176,13 +176,14 @@ Always check that it's really gone in the build log. |
| 21 |
|
| 22 |
<p><b>Specific -Werror=... flags</b></p> |
| 23 |
<p> |
| 24 |
-GCC can turn any specific warning into an error. A specific -Werror flag would |
| 25 |
-be "-Werror=implicit-function-declaration" for example and will only affect |
| 26 |
-warnings about implicit function declarations. It's mostly safe to leave these |
| 27 |
-untouched, cause they are pinned to this issue and should not cause random |
| 28 |
-build time breakage. Also, we can expect that upstream did this on purpose to |
| 29 |
-avoid known runtime errors and not just for testing their builds. However you |
| 30 |
-should check the specified warnings yourself or ask other developers if unsure. |
| 31 |
+The compiler (e.g. GCC) can turn any specific warning into an error. A |
| 32 |
+specific -Werror flag would be "-Werror=implicit-function-declaration" for |
| 33 |
+example and will only affect warnings about implicit function declarations. It's |
| 34 |
+mostly safe to leave these untouched, cause they are pinned to this issue and |
| 35 |
+should not cause random build time breakage. Also, we can expect that upstream |
| 36 |
+did this on purpose to avoid known runtime errors and not just for testing their |
| 37 |
+builds. However, you should check the specified warnings yourself or ask other |
| 38 |
+developers if unsure. |
| 39 |
</p> |
| 40 |
|
| 41 |
<p><b>Exceptions</b></p> |
Archives