[gentoo-commits] proj/pms:eapi-9 commit in: /

[Ulrich Müller]

commit:     edb669663d753b599673f2ddda5987a9b93be437
Author:     Ulrich Müller <ulm <AT> gentoo <DOT> org>
AuthorDate: Mon Feb 21 18:30:11 2022 +0000
Commit:     Ulrich Müller <ulm <AT> gentoo <DOT> org>
CommitDate: Thu Aug 18 15:51:54 2022 +0000
URL:        https://gitweb.gentoo.org/proj/pms.git/commit/?id=edb66966

EAPI 9 profile parent files can contain comments

Bug: https://bugs.gentoo.org/470094
Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org>

 eapi-differences.tex |  5 ++++-
 profiles.tex         | 20 +++++++++++++++++++-
 2 files changed, 23 insertions(+), 2 deletions(-)

diff --git a/eapi-differences.tex b/eapi-differences.tex
index 7bf3f2c..b83da4e 100644
--- a/eapi-differences.tex
+++ b/eapi-differences.tex
@@ -47,6 +47,9 @@ for a complete table of previous EAPIs.}
 Less strict filenames in \t{updates} & \compactfeatureref{updates-filenames} &
     No & No & No & Yes & Yes \\
 
+Comments in profiles \t{parent} file & \compactfeatureref{parent-comments} &
+    No & No & No & No & Yes \\
+
 Profile files as directories & \compactfeatureref{profile-file-dirs} &
     No & No & Yes & Yes & Yes \\
 
@@ -405,7 +408,7 @@ EAPI 8 is EAPI 7 with the following changes:
 EAPI 9 is EAPI 8 with the following changes:
 
 \begin{compactitem}
-\item None
+\item Comments in profiles \t{parent} file, \featureref{parent-comments}.
 \end{compactitem}
 
 \ChangeWhenAddingAnEAPI{9}

diff --git a/profiles.tex b/profiles.tex
index 8d8226a..6fa8a1c 100644
--- a/profiles.tex
+++ b/profiles.tex
@@ -25,7 +25,25 @@ first, left to right, with duplicate parent paths being sourced for every time t
 It is illegal for a profile's parent tree to contain cycles. Package manager behaviour upon
 encountering a cycle is undefined.
 
-This file must not contain comments, blank lines or make use of line continuations.
+This file must not make use of line continuations.
+
+\featurelabel{parent-comments} For EAPIs listed in table~\ref{tab:profile-parent-comments} as
+allowing comments, blank lines and lines beginning with a \t{\#} are discarded. For other EAPIs,
+this file must not contain comments or blank lines.
+
+\ChangeWhenAddingAnEAPI{9}
+\begin{centertable}{EAPIs allowing comments in \t{parent} file}
+    \label{tab:profile-parent-comments}
+    \begin{tabular}{ll}
+      \toprule
+      \multicolumn{1}{c}{\textbf{EAPI}} &
+      \multicolumn{1}{c}{\textbf{Allows comments?}} \\
+      \midrule
+      0, 1, 2, 3, 4, 5, 6, 7, 8 & No  \\
+      9                         & Yes \\
+      \bottomrule
+    \end{tabular}
+\end{centertable}
 
 \subsection{The eapi file}
 \label{sec:profile-eapi}