| 1 |
commit: bab507676f7c22f94e4457b7aafb5d53c26401c3 |
| 2 |
Author: Ulrich Müller <ulm <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Mon Apr 1 12:21:35 2013 +0000 |
| 4 |
Commit: Ulrich Mueller <ulm <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Mon Apr 1 12:21:35 2013 +0000 |
| 6 |
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/emacs-tools.git;a=commit;h=bab50767 |
| 7 |
|
| 8 |
Don't use braces for positional parameters. |
| 9 |
|
| 10 |
--- |
| 11 |
ctags.eselect | 6 +++--- |
| 12 |
emacs.eselect | 10 +++++----- |
| 13 |
2 files changed, 8 insertions(+), 8 deletions(-) |
| 14 |
|
| 15 |
diff --git a/ctags.eselect b/ctags.eselect |
| 16 |
index 9db3f9c..30c227d 100644 |
| 17 |
--- a/ctags.eselect |
| 18 |
+++ b/ctags.eselect |
| 19 |
@@ -59,14 +59,14 @@ remove_symlinks() { |
| 20 |
|
| 21 |
set_bin_symlinks() { |
| 22 |
# Set symlink to binary |
| 23 |
- local target=${1} |
| 24 |
+ local target=$1 |
| 25 |
ln -s "${target}" "${EROOT}/usr/bin/${CTAGS}" \ |
| 26 |
|| die "Couldn't set ${target} ${EROOT}/usr/bin/${CTAGS} symlink" |
| 27 |
} |
| 28 |
|
| 29 |
set_man_symlinks() { |
| 30 |
# Set symlink to man page |
| 31 |
- local target=${1} extension i |
| 32 |
+ local target=$1 extension i |
| 33 |
for i in "${EROOT}"/usr/share/man/man1/${target}.1*; do |
| 34 |
if [[ -f ${i} ]]; then |
| 35 |
# target file exists; determine compress extension |
| 36 |
@@ -85,7 +85,7 @@ set_symlinks() { |
| 37 |
# numeric index, find the target's name |
| 38 |
targets=( $(find_targets) ) |
| 39 |
[[ ${target} -ge 1 && ${target} -le ${#targets[@]} ]] \ |
| 40 |
- || die -q "Number out of range: ${1}" |
| 41 |
+ || die -q "Number out of range: $1" |
| 42 |
target=${targets[target-1]} |
| 43 |
fi |
| 44 |
|
| 45 |
|
| 46 |
diff --git a/emacs.eselect b/emacs.eselect |
| 47 |
index 6ac68d2..3ed6e06 100644 |
| 48 |
--- a/emacs.eselect |
| 49 |
+++ b/emacs.eselect |
| 50 |
@@ -64,7 +64,7 @@ remove_symlinks() { |
| 51 |
|
| 52 |
set_bin_symlinks() { |
| 53 |
# Set symlinks to binaries in /usr/bin/ |
| 54 |
- local target=${1} f |
| 55 |
+ local target=$1 f |
| 56 |
for f in ${BINARYLIST}; do |
| 57 |
# set symlink only if target binary actually exists |
| 58 |
if [[ -f ${EROOT}/usr/bin/${f}-${target} ]]; then |
| 59 |
@@ -76,7 +76,7 @@ set_bin_symlinks() { |
| 60 |
|
| 61 |
set_man_symlinks() { |
| 62 |
# Set symlinks to man pages |
| 63 |
- local target=${1} extension f i |
| 64 |
+ local target=$1 extension f i |
| 65 |
for f in ${MANPAGELIST}; do |
| 66 |
for i in "${EROOT}"/usr/share/man/man1/${f}-${target}.1*; do |
| 67 |
if [[ -f ${i} ]]; then |
| 68 |
@@ -97,13 +97,13 @@ set_symlinks() { |
| 69 |
# numeric index, find the target's name |
| 70 |
targets=( $(find_targets) ) |
| 71 |
[[ ${target} -ge 1 && ${target} -le ${#targets[@]} ]] \ |
| 72 |
- || die -q "Number out of range: ${1}" |
| 73 |
+ || die -q "Number out of range: $1" |
| 74 |
target=${targets[target-1]} |
| 75 |
fi |
| 76 |
|
| 77 |
# is the target valid, i.e. does an Emacs binary with this name exist? |
| 78 |
[[ -f ${EROOT}/usr/bin/${target} ]] \ |
| 79 |
- || die -q "Target \"${1}\" doesn't appear to be valid!" |
| 80 |
+ || die -q "Target \"$1\" doesn't appear to be valid!" |
| 81 |
|
| 82 |
echo "Switching emacs to ${target} ..." |
| 83 |
remove_symlinks || die -q "Couldn't remove existing symlink" |
| 84 |
@@ -221,7 +221,7 @@ do_set() { |
| 85 |
die -q "${EROOT}/usr/bin/emacs exists but is not a symlink" |
| 86 |
fi |
| 87 |
|
| 88 |
- set_symlinks "${1}" || die -q "Couldn't set a new symlink" |
| 89 |
+ set_symlinks "$1" || die -q "Couldn't set a new symlink" |
| 90 |
|
| 91 |
# ctags symlinks are handled in an own module now |
| 92 |
do_action ctags update |
Archives