Gentoo Archives: gentoo-commits

From: "Anthony G. Basile" <blueness@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/catalyst:2.X commit in: targets/support/
Date: Fri, 04 Mar 2016 01:51:17
Message-Id: 1457056123.1eabce3a9c15c5caf022e71c1959e8c8f4819fad.blueness@gentoo
1 commit: 1eabce3a9c15c5caf022e71c1959e8c8f4819fad
2 Author: Anthony G. Basile <blueness <AT> gentoo <DOT> org>
3 AuthorDate: Fri Mar 4 01:48:43 2016 +0000
4 Commit: Anthony G. Basile <blueness <AT> gentoo <DOT> org>
5 CommitDate: Fri Mar 4 01:48:43 2016 +0000
6 URL: https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=1eabce3a
7
8 targets/support/chroot-functions.sh: correct quotes to allow expansion of $1
9
10 This is a backport of commit b2473eff. The single quotes prevented the proper
11 expansion of $1 in setup_pkgmgr(). Since this is usually called as
12 `setup_pkgmgr "build"` during stage1 builds, it is surprising this was
13 not caught earlier.
14
15 targets/support/chroot-functions.sh | 8 ++++----
16 1 file changed, 4 insertions(+), 4 deletions(-)
17
18 diff --git a/targets/support/chroot-functions.sh b/targets/support/chroot-functions.sh
19 index 3b7f77b..6c1a31c 100755
20 --- a/targets/support/chroot-functions.sh
21 +++ b/targets/support/chroot-functions.sh
22 @@ -172,12 +172,12 @@ setup_pkgmgr(){
23 # Use --update or portage might just waste time/cycles and reinstall the same version.
24 # Use --newuse to make sure it rebuilds with any changed use flags.
25 if [ -n "$1" ];then
26 - echo "Adding USE='${USE} $1' to make.conf for portage build"
27 - [ -e /etc/portage/make.conf ] && echo 'USE="${USE} $1"' >> /etc/portage/make.conf
28 + echo "Adding USE=\"${USE} $1\" to make.conf for portage build"
29 + [ -e /etc/portage/make.conf ] && echo "USE=\"\${USE} $1\"" >> /etc/portage/make.conf
30 run_merge --oneshot --update --newuse sys-apps/portage
31 - sed -i '/USE="${USE} $1"/d' /etc/portage/make.conf
32 + sed -i "/USE=\"\${USE} $1\"/d" /etc/portage/make.conf
33 else
34 - echo "Updating portage with USE='${USE}'"
35 + echo "Updating portage with USE=\"${USE}\""
36 run_merge --oneshot --update --newuse sys-apps/portage
37 fi
38 }