Gentoo Archives: gentoo-commits

From: Zac Medico <zmedico@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/portage:master commit in: bin/install-qa-check.d/
Date: Wed, 02 Aug 2017 07:24:06
Message-Id: 1501658532.864585bc32dc0ccad8f53aec03d378d37b385c21.zmedico@gentoo
1 commit: 864585bc32dc0ccad8f53aec03d378d37b385c21
2 Author: Zac Medico <zmedico <AT> gentoo <DOT> org>
3 AuthorDate: Tue Aug 1 05:04:29 2017 +0000
4 Commit: Zac Medico <zmedico <AT> gentoo <DOT> org>
5 CommitDate: Wed Aug 2 07:22:12 2017 +0000
6 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=864585bc
7
8 multilib-strict: disable recursion into subdirectories (bug 424423)
9
10 Disable recursion into subdirectories, in order to avoid false-positives.
11 The MULTILIB_STRICT_EXEMPT variable only served to filter false-positives
12 that were triggered by recursion, so it will no longer be needed.
13
14 X-Gentoo-bug: 424423
15 X-Gentoo-bug-url: https://bugs.gentoo.org/show_bug.cgi?id=424423
16 Reviewed-by: Manuel RĂ¼ger <mrueg <AT> gentoo.org>
17
18 bin/install-qa-check.d/80multilib-strict | 7 +++----
19 1 file changed, 3 insertions(+), 4 deletions(-)
20
21 diff --git a/bin/install-qa-check.d/80multilib-strict b/bin/install-qa-check.d/80multilib-strict
22 index f944be9e6..afd223250 100644
23 --- a/bin/install-qa-check.d/80multilib-strict
24 +++ b/bin/install-qa-check.d/80multilib-strict
25 @@ -6,14 +6,13 @@ multilib_strict_check() {
26 then
27 rm -f "${T}/multilib-strict.log"
28 local abort=no dir file
29 - MULTILIB_STRICT_EXEMPT=$(echo ${MULTILIB_STRICT_EXEMPT} | sed -e 's:\([(|)]\):\\\1:g')
30 for dir in ${MULTILIB_STRICT_DIRS} ; do
31 [[ -d ${ED}/${dir} ]] || continue
32 - for file in $(find ${ED}/${dir} -type f | grep -v "^${ED}/${dir}/${MULTILIB_STRICT_EXEMPT}"); do
33 - if file ${file} | egrep -q "${MULTILIB_STRICT_DENY}" ; then
34 + while read -r -d '' file; do
35 + if file "${file}" | grep -Eq "${MULTILIB_STRICT_DENY}" ; then
36 echo "${file#${ED}//}" >> "${T}/multilib-strict.log"
37 fi
38 - done
39 + done < <(find "${ED}/${dir}" -maxdepth 1 -type f -print0)
40 done
41
42 if [[ -s ${T}/multilib-strict.log ]] ; then