[gentoo-commits] portage r13725 - main/trunk/pym/repoman

[Zac Medico (zmedico)]

Author: zmedico
Date: 2009-06-28 18:40:05 +0000 (Sun, 28 Jun 2009)
New Revision: 13725

Modified:
   main/trunk/pym/repoman/checks.py
Log:
Check for redundant blank lines. Thanks to Markus Meier <maekke@g.o>
for this patch.


Modified: main/trunk/pym/repoman/checks.py
===================================================================
--- main/trunk/pym/repoman/checks.py	2009-06-28 18:24:23 UTC (rev 13724)
+++ main/trunk/pym/repoman/checks.py	2009-06-28 18:40:05 UTC (rev 13725)
@@ -82,6 +82,25 @@
 		if self.trailing_whitespace.match(line) is None:
 			return errors.TRAILING_WHITESPACE_ERROR
 
+class EbuildBlankLine(LineCheck):
+	repoman_check_name = 'ebuild.minorsyn'
+	blank_line = re.compile(r'^$')
+
+	def new(self, pkg):
+		self.line_is_blank = False
+
+	def check(self, num, line):
+		if self.line_is_blank and self.blank_line.match(line):
+			return 'Useless blank line on line: %d'
+		if self.blank_line.match(line):
+			self.line_is_blank = True
+		else:
+			self.line_is_blank = False
+
+	def end(self):
+		if self.line_is_blank:
+			yield 'Useless blank line on last line'
+
 class EbuildQuote(LineCheck):
 	"""Ensure ebuilds have valid quoting around things like D,FILESDIR, etc..."""
 
@@ -471,7 +490,7 @@
 
 
 _constant_checks = tuple((c() for c in (
-	EbuildHeader, EbuildWhitespace, EbuildQuote,
+	EbuildHeader, EbuildWhitespace, EbuildBlankLine, EbuildQuote,
 	EbuildAssignment, EbuildUselessDodoc,
 	EbuildUselessCdS, EbuildNestedDie,
 	EbuildPatches, EbuildQuotedA, EapiDefinition,