Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/qt:master commit in: dev-qt/qtwidgets/, dev-qt/qtwidgets/files/
Date: Sun, 29 Sep 2019 07:04:45
Message-Id: 1569664555.a01453d34ae409ef1a3430a08c01b4633484a696.asturm@gentoo
1 commit: a01453d34ae409ef1a3430a08c01b4633484a696
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Sat Sep 28 09:55:39 2019 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Sat Sep 28 09:55:55 2019 +0000
6 URL: https://gitweb.gentoo.org/proj/qt.git/commit/?id=a01453d3
7
8 dev-qt/qtwidgets: Fix focus widget issue
9
10 Fixes keyboard input or rather lack thereof in qtwebengine based applications.
11
12 Package-Manager: Portage-2.3.76, Repoman-2.3.17
13 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
14
15 ...dgets-5.13.1-adjust-focus-widget-properly.patch | 34 ++++++++++++++++++++++
16 dev-qt/qtwidgets/qtwidgets-5.13.1.ebuild | 2 ++
17 2 files changed, 36 insertions(+)
18
19 diff --git a/dev-qt/qtwidgets/files/qtwidgets-5.13.1-adjust-focus-widget-properly.patch b/dev-qt/qtwidgets/files/qtwidgets-5.13.1-adjust-focus-widget-properly.patch
20 new file mode 100644
21 index 00000000..6fdc0f2b
22 --- /dev/null
23 +++ b/dev-qt/qtwidgets/files/qtwidgets-5.13.1-adjust-focus-widget-properly.patch
24 @@ -0,0 +1,34 @@
25 +From 947883141d9d8b3079a8a21981ad8a5ce3c4798e Mon Sep 17 00:00:00 2001
26 +From: David Faure <david.faure@××××.com>
27 +Date: Mon, 9 Sep 2019 18:12:26 +0200
28 +Subject: [PATCH] QWidget::setFocusProxy: adjust focus widget properly
29 +
30 +My commit 3e7463411e adjusted the focus widget by setting
31 +QApplicationPrivate::focus_widget directly, while there is a method for
32 +doing this properly, including setFocus_sys() and emitting signals.
33 +
34 +Fixes: QTBUG-77364
35 +Change-Id: I218acf7a9de39173d282ced46def4f65594f80b4
36 +Reviewed-by: Florian Bruhin <qt-project.org@××××××××××××.org>
37 +Reviewed-by: Volker Hilsheimer <volker.hilsheimer@××.io>
38 +Reviewed-by: Allan Sandfeld Jensen <allan.jensen@××.io>
39 +Reviewed-by: Shawn Rutledge <shawn.rutledge@××.io>
40 +---
41 + src/widgets/kernel/qwidget.cpp | 2 +-
42 + 1 file changed, 1 insertion(+), 1 deletion(-)
43 +
44 +diff --git a/src/widgets/kernel/qwidget.cpp b/src/widgets/kernel/qwidget.cpp
45 +index 04290a4ce12..0fa59077449 100644
46 +--- a/src/widgets/kernel/qwidget.cpp
47 ++++ b/src/widgets/kernel/qwidget.cpp
48 +@@ -6446,7 +6446,7 @@ void QWidget::setFocusProxy(QWidget * w)
49 +
50 + if (changingAppFocusWidget) {
51 + QWidget *newDeepestFocusProxy = d_func()->deepestFocusProxy();
52 +- QApplicationPrivate::focus_widget = newDeepestFocusProxy ? newDeepestFocusProxy : this;
53 ++ QApplicationPrivate::setFocusWidget(newDeepestFocusProxy ? newDeepestFocusProxy : this, Qt::NoFocusReason);
54 + }
55 + }
56 +
57 +--
58 +2.16.3
59
60 diff --git a/dev-qt/qtwidgets/qtwidgets-5.13.1.ebuild b/dev-qt/qtwidgets/qtwidgets-5.13.1.ebuild
61 index 85ceaa9c..677d210f 100644
62 --- a/dev-qt/qtwidgets/qtwidgets-5.13.1.ebuild
63 +++ b/dev-qt/qtwidgets/qtwidgets-5.13.1.ebuild
64 @@ -42,6 +42,8 @@ QT5_GENTOO_PRIVATE_CONFIG=(
65 :widgets
66 )
67
68 +PATCHES=( "${FILESDIR}/${P}-adjust-focus-widget-properly.patch" ) # QTBUG-77364
69 +
70 src_configure() {
71 local myconf=(
72 -opengl $(usex gles2 es2 desktop)