Gentoo Archives: gentoo-commits

From: "Ulrich Müller" <ulm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/devmanual:master commit in: ebuild-writing/common-mistakes/
Date: Mon, 29 Mar 2021 20:44:10
Message-Id: 1617050499.b487288add4b6a7ecc8a9674fe8e500ab7d8306a.ulm@gentoo
1 commit: b487288add4b6a7ecc8a9674fe8e500ab7d8306a
2 Author: Sam James <sam <AT> gentoo <DOT> org>
3 AuthorDate: Sat Mar 20 15:21:57 2021 +0000
4 Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org>
5 CommitDate: Mon Mar 29 20:41:39 2021 +0000
6 URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=b487288a
7
8 ebuild-writing/common-mistakes: extend 'DEPEND is incomplete'
9
10 Emphasise that the tips/information applies to all dependency
11 classes.
12
13 Signed-off-by: Sam James <sam <AT> gentoo.org>
14 Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org>
15
16 ebuild-writing/common-mistakes/text.xml | 7 ++++++-
17 1 file changed, 6 insertions(+), 1 deletion(-)
18
19 diff --git a/ebuild-writing/common-mistakes/text.xml b/ebuild-writing/common-mistakes/text.xml
20 index dcdc969..91eca66 100644
21 --- a/ebuild-writing/common-mistakes/text.xml
22 +++ b/ebuild-writing/common-mistakes/text.xml
23 @@ -284,6 +284,11 @@ part.
24 <title>DEPEND is incomplete</title>
25 <body>
26
27 +<note>
28 +The tips in this section apply to all dependency classes, not just
29 +<c>DEPEND</c>.
30 +</note>
31 +
32 <p>
33 This is another very common error. The ebuild submitter submits an ebuild
34 that "just works" without checking if the dependencies are correct. Here are
35 @@ -317,7 +322,7 @@ some tips on how to find the correct dependencies.
36 programs, etc.</e>
37 Usually the build process requires some dependencies such as intltool,
38 libtool, pkg-config, doxygen, scrollkeeper, gtk-doc, etc. Make sure those
39 - are clearly stated.
40 + are clearly stated, usually in <c>BDEPEND</c>.
41 </li>
42 </ul>