Gentoo Archives: gentoo-commits

From: "Mike Frysinger (vapier)" <vapier@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] gentoo-projects commit in portage-utils/libq: vdb_get_next_dir.c
Date: Mon, 03 Oct 2011 01:08:51
Message-Id: 20111003010837.5BCC82004B@flycatcher.gentoo.org
1 vapier 11/10/03 01:08:37
2
3 Modified: vdb_get_next_dir.c
4 Log:
5 avoid useless strlen, and use size_t for indexing
6
7 Revision Changes Path
8 1.6 portage-utils/libq/vdb_get_next_dir.c
9
10 file : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/portage-utils/libq/vdb_get_next_dir.c?rev=1.6&view=markup
11 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-projects/portage-utils/libq/vdb_get_next_dir.c?rev=1.6&content-type=text/plain
12 diff : http://sources.gentoo.org/viewvc.cgi/gentoo-projects/portage-utils/libq/vdb_get_next_dir.c?r1=1.5&r2=1.6
13
14 Index: vdb_get_next_dir.c
15 ===================================================================
16 RCS file: /var/cvsroot/gentoo-projects/portage-utils/libq/vdb_get_next_dir.c,v
17 retrieving revision 1.5
18 retrieving revision 1.6
19 diff -u -r1.5 -r1.6
20 --- vdb_get_next_dir.c 17 Mar 2011 03:54:53 -0000 1.5
21 +++ vdb_get_next_dir.c 3 Oct 2011 01:08:37 -0000 1.6
22 @@ -6,7 +6,7 @@
23 {
24 /* search for a category directory */
25 struct dirent *ret;
26 - int len, i;
27 + size_t i;
28
29 next_entry:
30 ret = readdir(dir);
31 @@ -18,8 +18,7 @@
32 if (ret->d_name[0] == '.' || ret->d_name[0] == '-')
33 goto next_entry;
34
35 - len = strlen(ret->d_name);
36 - for (i = 0; i < len; i++) {
37 + for (i = 0; ret->d_name[i]; ++i) {
38 if (!isalnum(ret->d_name[i])) { /* [A-Za-z0-9+_.-] */
39 switch (ret->d_name[i]) {
40 case '+':