| 1 |
commit: a9971615ef69dbb26f04af2c9fd1cddd1ec6d626 |
| 2 |
Author: Michał Górny <mgorny <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Sun Jan 28 08:55:35 2018 +0000 |
| 4 |
Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Wed Feb 7 13:22:07 2018 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/data/glep.git/commit/?id=a9971615 |
| 7 |
|
| 8 |
glep-0075: Include argument on injected distfiles |
| 9 |
|
| 10 |
Include the argument that we have injected distfiles as noted |
| 11 |
on the bug by Robin. Inclusion suggested by Michael Orlitzky. |
| 12 |
|
| 13 |
glep-0075.rst | 5 ++++- |
| 14 |
1 file changed, 4 insertions(+), 1 deletion(-) |
| 15 |
|
| 16 |
diff --git a/glep-0075.rst b/glep-0075.rst |
| 17 |
index c0a1d5c..ced1231 100644 |
| 18 |
--- a/glep-0075.rst |
| 19 |
+++ b/glep-0075.rst |
| 20 |
@@ -205,7 +205,7 @@ to split them further. |
| 21 |
|
| 22 |
The alternate option of using file hash has the advantage of having |
| 23 |
a more balanced split. Furthermore, since hashes are stored |
| 24 |
-in Manifests using them is zero-cost. However, this solution has two |
| 25 |
+in Manifests using them is zero-cost. However, this solution has three |
| 26 |
significant disadvantages: |
| 27 |
|
| 28 |
1. The hash values are unknown for newly-downloaded distfiles, so |
| 29 |
@@ -216,6 +216,9 @@ significant disadvantages: |
| 30 |
hash mismatches would be placed in the wrong subdirectory, |
| 31 |
potentially causing confusing errors. |
| 32 |
|
| 33 |
+3. Not all files in the distfiles tree are covered by package Manifests |
| 34 |
+ --- there are additional files that are injected into distfiles. |
| 35 |
+ |
| 36 |
Using filename hashes has proven to provide a similar balance |
| 37 |
to using file hashes. Furthermore, since filenames are known up front |
| 38 |
this solution does not suffer from the both listed problems. While |
Archives