Gentoo Archives: gentoo-commits

From: Matt Turner <mattst88@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: mail-client/evolution/files/, mail-client/evolution/
Date: Fri, 16 Apr 2021 13:23:54
Message-Id: 1618579414.c0068bb3863bdee6d3d01f78b7d7ea6a8f23261c.mattst88@gentoo
1 commit: c0068bb3863bdee6d3d01f78b7d7ea6a8f23261c
2 Author: Matt Turner <mattst88 <AT> gentoo <DOT> org>
3 AuthorDate: Fri Apr 16 13:23:24 2021 +0000
4 Commit: Matt Turner <mattst88 <AT> gentoo <DOT> org>
5 CommitDate: Fri Apr 16 13:23:34 2021 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0068bb3
7
8 mail-client/evolution: Add patch for cmake-3.20 compat
9
10 Closes: https://bugs.gentoo.org/781971
11 Signed-off-by: Matt Turner <mattst88 <AT> gentoo.org>
12
13 mail-client/evolution/evolution-3.38.4.ebuild | 2 +
14 ...tions.cmake-Correct-variable-name-compari.patch | 75 ++++++++++++++++++++++
15 2 files changed, 77 insertions(+)
16
17 diff --git a/mail-client/evolution/evolution-3.38.4.ebuild b/mail-client/evolution/evolution-3.38.4.ebuild
18 index 3a5b6390343..3dbfedc6526 100644
19 --- a/mail-client/evolution/evolution-3.38.4.ebuild
20 +++ b/mail-client/evolution/evolution-3.38.4.ebuild
21 @@ -95,6 +95,8 @@ file from /usr/share/applications if you use a different browser)."
22 src_prepare() {
23 cmake_src_prepare
24 gnome2_src_prepare
25 +
26 + eapply "${FILESDIR}"/3.38-PrintableOptions.cmake-Correct-variable-name-compari.patch
27 }
28
29 src_configure() {
30
31 diff --git a/mail-client/evolution/files/3.38-PrintableOptions.cmake-Correct-variable-name-compari.patch b/mail-client/evolution/files/3.38-PrintableOptions.cmake-Correct-variable-name-compari.patch
32 new file mode 100644
33 index 00000000000..f7e8855bbe0
34 --- /dev/null
35 +++ b/mail-client/evolution/files/3.38-PrintableOptions.cmake-Correct-variable-name-compari.patch
36 @@ -0,0 +1,75 @@
37 +From 7cfe4190e3e72b40472d57871459f1b136393003 Mon Sep 17 00:00:00 2001
38 +From: Milan Crha <mcrha@××××××.com>
39 +Date: Wed, 14 Apr 2021 16:58:08 +0200
40 +Subject: [PATCH] PrintableOptions.cmake: Correct variable name comparison
41 +
42 +CMake 3.20.1 errors out with:
43 +
44 +CMake Error at cmake/modules/PrintableOptions.cmake:38 (message):
45 + variable name cannot be empty
46 + Call Stack (most recent call first):
47 + CMakeLists.txt:152 (add_printable_variable)
48 +
49 +Change how the parameter value is compared, to fix it.
50 +---
51 + cmake/modules/PrintableOptions.cmake | 20 ++++++++++----------
52 + 1 file changed, 10 insertions(+), 10 deletions(-)
53 +
54 +diff --git a/cmake/modules/PrintableOptions.cmake b/cmake/modules/PrintableOptions.cmake
55 +index ba1c9d0b7f..339f1da4b4 100644
56 +--- a/cmake/modules/PrintableOptions.cmake
57 ++++ b/cmake/modules/PrintableOptions.cmake
58 +@@ -19,40 +19,40 @@
59 + # prints all the build options previously added with the above functions
60 +
61 + macro(add_printable_variable_bare _name)
62 +- if(_name STREQUAL "")
63 ++ if("${_name}" STREQUAL "")
64 + message(FATAL_ERROR "variable name cannot be empty")
65 +- endif(_name STREQUAL "")
66 ++ endif("${_name}" STREQUAL "")
67 + list(APPEND _printable_options ${_name})
68 + endmacro()
69 +
70 + macro(add_printable_option _name _description _default_value)
71 +- if(_name STREQUAL "")
72 ++ if("${_name}" STREQUAL "")
73 + message(FATAL_ERROR "option name cannot be empty")
74 +- endif(_name STREQUAL "")
75 ++ endif("${_name}" STREQUAL "")
76 + option(${_name} ${_description} ${_default_value})
77 + add_printable_variable_bare(${_name})
78 + endmacro()
79 +
80 + macro(add_printable_variable _name _description _default_value)
81 +- if(_name STREQUAL "")
82 ++ if("${_name}" STREQUAL "")
83 + message(FATAL_ERROR "variable name cannot be empty")
84 +- endif(_name STREQUAL "")
85 ++ endif("${_name}" STREQUAL "")
86 + set(${_name} ${_default_value} CACHE STRING ${_description})
87 + add_printable_variable_bare(${_name})
88 + endmacro()
89 +
90 + macro(add_printable_variable_path _name _description _default_value)
91 +- if(_name STREQUAL "")
92 ++ if("${_name}" STREQUAL "")
93 + message(FATAL_ERROR "path variable name cannot be empty")
94 +- endif(_name STREQUAL "")
95 ++ endif("${_name}" STREQUAL "")
96 + set(${_name} ${_default_value} CACHE PATH ${_description})
97 + add_printable_variable_bare(${_name})
98 + endmacro()
99 +
100 + macro(add_printable_variable_filepath _name _description _default_value)
101 +- if(_name STREQUAL "")
102 ++ if("${_name}" STREQUAL "")
103 + message(FATAL_ERROR "filepath variable name cannot be empty")
104 +- endif(_name STREQUAL "")
105 ++ endif("${_name}" STREQUAL "")
106 + set(${_name} ${_default_value} CACHE FILEPATH ${_description})
107 + add_printable_variable_bare(${_name})
108 + endmacro()
109 +--
110 +2.26.3
111 +