| 1 |
commit: f437c7c0233294f197514f3b6ab8a4a24736719b |
| 2 |
Author: Sergei Trofimovich <slyfox <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Fri Feb 15 07:49:26 2019 +0000 |
| 4 |
Commit: Sergei Trofimovich <slyfox <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Fri Feb 15 07:53:19 2019 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f437c7c0 |
| 7 |
|
| 8 |
toolchain.eclass: never pass --enable-libvtv to ./configure |
| 9 |
|
| 10 |
gcc treats --enable-libvtv as an override on top of |
| 11 |
autodetection. It it never what we want. Happens to break |
| 12 |
at least powerpc64 cross-compilers: |
| 13 |
https://bugs.gentoo.org/661252 |
| 14 |
|
| 15 |
Reported-by: Ilia Mirkin |
| 16 |
Closes: https://bugs.gentoo.org/661252 |
| 17 |
Signed-off-by: Sergei Trofimovich <slyfox <AT> gentoo.org> |
| 18 |
|
| 19 |
eclass/toolchain.eclass | 7 +++++-- |
| 20 |
1 file changed, 5 insertions(+), 2 deletions(-) |
| 21 |
|
| 22 |
diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass |
| 23 |
index 56921228daa..daa62e3a67c 100644 |
| 24 |
--- a/eclass/toolchain.eclass |
| 25 |
+++ b/eclass/toolchain.eclass |
| 26 |
@@ -1278,7 +1278,8 @@ toolchain_src_configure() { |
| 27 |
if in_iuse vtv ; then |
| 28 |
confgcc+=( |
| 29 |
$(use_enable vtv vtable-verify) |
| 30 |
- $(use_enable vtv libvtv) |
| 31 |
+ # See Note [implicitly enabled flags] |
| 32 |
+ $(usex vtv '' --disable-libvtv) |
| 33 |
) |
| 34 |
fi |
| 35 |
|
| 36 |
@@ -2514,7 +2515,9 @@ toolchain_death_notice() { |
| 37 |
# |
| 38 |
# GCC does not follow this pattern and instead overrides autodetection |
| 39 |
# of the feature and enables it unconditionally. |
| 40 |
-# See https://gcc.gnu.org/PR85663 |
| 41 |
+# See bugs: |
| 42 |
+# https://gcc.gnu.org/PR85663 (libsanitizer on mips) |
| 43 |
+# https://bugs.gentoo.org/661252 (libvtv on powerpc64) |
| 44 |
# |
| 45 |
# Thus safer way to enable/disable the feature is to rely on implicit |
| 46 |
# enabled-by-default state: |
Archives