Gentoo Archives: gentoo-commits

From: "Mike Auty (ikelos)" <ikelos@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] gentoo-x86 commit in app-forensics/foremost/files: foremost-1.5.7-format-security.patch
Date: Sun, 31 Aug 2014 00:37:47
Message-Id: 20140831003743.644AE44AA@oystercatcher.gentoo.org
1 ikelos 14/08/31 00:37:43
2
3 Added: foremost-1.5.7-format-security.patch
4 Log:
5 Add in patch for -Werror=format-security warning (fixes bug 521038).
6
7 (Portage version: 2.2.12/cvs/Linux x86_64, signed Manifest commit with key 6C20157A)
8
9 Revision Changes Path
10 1.1 app-forensics/foremost/files/foremost-1.5.7-format-security.patch
11
12 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-forensics/foremost/files/foremost-1.5.7-format-security.patch?rev=1.1&view=markup
13 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-forensics/foremost/files/foremost-1.5.7-format-security.patch?rev=1.1&content-type=text/plain
14
15 Index: foremost-1.5.7-format-security.patch
16 ===================================================================
17 diff --git a/extract.c b/extract.c
18 index 30bdf54..9639117 100755
19 --- a/extract.c
20 +++ b/extract.c
21 @@ -2110,7 +2110,6 @@ unsigned char *extract_exe(f_state *s, u_int64_t c_offset, unsigned char *founda
22 int i = 0;
23 time_t compile_time = 0;
24 struct tm *ret_time;
25 - char comment[32];
26 char ascii_time[32];
27
28 if (buflen < 100)
29 @@ -2145,8 +2144,7 @@ unsigned char *extract_exe(f_state *s, u_int64_t c_offset, unsigned char *founda
30 ret_time->tm_sec);
31 chop(ascii_time);
32
33 - sprintf(comment, ascii_time);
34 - strcat(needle->comment, comment);
35 + strcat(needle->comment, ascii_time);
36 exe_char = htos(&foundat[22], FOREMOST_LITTLE_ENDIAN);
37 if (exe_char & 0x2000)
38 {