| 1 |
commit: 5059bb531cc73e428042a83fe07191b2d98d40c4 |
| 2 |
Author: Thomas Deutschmann <whissi <AT> gentoo <DOT> org> |
| 3 |
AuthorDate: Mon Feb 24 22:31:24 2020 +0000 |
| 4 |
Commit: Thomas Deutschmann <whissi <AT> gentoo <DOT> org> |
| 5 |
CommitDate: Mon Feb 24 22:35:18 2020 +0000 |
| 6 |
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5059bb53 |
| 7 |
|
| 8 |
www-client/firefox: block USE=pgo when USE=-clang |
| 9 |
|
| 10 |
USE=pgo is currently known to be broken when using GCC. |
| 11 |
|
| 12 |
Instead of silently ignoring USE=pgo when using GCC, we are |
| 13 |
forcing a user decision so user has the chance to enable USE=clang |
| 14 |
in case PGO is important for user without wasting 2+ hours |
| 15 |
commpiling firefox just to find out that PGO which was requested |
| 16 |
was ignored. |
| 17 |
|
| 18 |
Bug: https://bugs.gentoo.org/709594 |
| 19 |
Bug: https://bugs.gentoo.org/709654 |
| 20 |
Package-Manager: Portage-2.3.89, Repoman-2.3.20 |
| 21 |
Signed-off-by: Thomas Deutschmann <whissi <AT> gentoo.org> |
| 22 |
|
| 23 |
www-client/firefox/firefox-73.0.1.ebuild | 8 ++++++++ |
| 24 |
1 file changed, 8 insertions(+) |
| 25 |
|
| 26 |
diff --git a/www-client/firefox/firefox-73.0.1.ebuild b/www-client/firefox/firefox-73.0.1.ebuild |
| 27 |
index a9232b0afb2..106e5b996ea 100644 |
| 28 |
--- a/www-client/firefox/firefox-73.0.1.ebuild |
| 29 |
+++ b/www-client/firefox/firefox-73.0.1.ebuild |
| 30 |
@@ -209,6 +209,14 @@ pkg_pretend() { |
| 31 |
if ! has usersandbox $FEATURES ; then |
| 32 |
die "You must enable usersandbox as X server can not run as root!" |
| 33 |
fi |
| 34 |
+ |
| 35 |
+ if ! use clang ; then |
| 36 |
+ # Force user decision so they don't find out firefox was build |
| 37 |
+ # without pgo after spending some hours |
| 38 |
+ eerror "USE=pgo when using GCC is currently known to be broken." |
| 39 |
+ eerror "Either switch to USE=clang or temporarily set USE=-pgo." |
| 40 |
+ die "USE=pgo without USE=clang is currently known to be broken." |
| 41 |
+ fi |
| 42 |
fi |
| 43 |
|
| 44 |
# Ensure we have enough disk space to compile |
Archives