Gentoo Archives: gentoo-commits

From: Michael Palimaka <kensington@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/qa-scripts:master commit in: tinderbox/
Date: Wed, 04 Jun 2014 14:56:02
Message-Id: 1401893303.0e6e3a57a8de9287892f2a67cd37632b43754aee.kensington@gentoo
1 commit: 0e6e3a57a8de9287892f2a67cd37632b43754aee
2 Author: Michael Palimaka <kensington <AT> gentoo <DOT> org>
3 AuthorDate: Wed Jun 4 14:06:06 2014 +0000
4 Commit: Michael Palimaka <kensington <AT> gentoo <DOT> org>
5 CommitDate: Wed Jun 4 14:48:23 2014 +0000
6 URL: http://git.overlays.gentoo.org/gitweb/?p=proj/qa-scripts.git;a=commit;h=0e6e3a57
7
8 tinderbox: return the exit status of the make function override.
9
10 This ensure that tests are correctly detected as passed/failed by
11 portage.
12 Also, calling /usr/bin/make instead of emake should more
13 accurately replicate the behaviour intended by the original
14 function call.
15
16 ---
17 tinderbox/bashrc | 13 ++++++-------
18 1 file changed, 6 insertions(+), 7 deletions(-)
19
20 diff --git a/tinderbox/bashrc b/tinderbox/bashrc
21 index 763979c..47bb19e 100644
22 --- a/tinderbox/bashrc
23 +++ b/tinderbox/bashrc
24 @@ -140,17 +140,16 @@ tinderbox_log() {
25 #
26
27 make() {
28 - if [[ "${FUNCNAME[1]}" == "einstall" ]] ; then
29 - emake -j1 "$@"
30 + if [[ "${FUNCNAME[1]}" == "einstall" || "${FUNCNAME[1]}" == "__eapi0_src_test" ]] ; then
31 + /usr/bin/make -j1 "$@"
32 + ret=$?
33 else
34 emake "$@"
35 -
36 - if [[ "${FUNCNAME[1]}" == "__eapi0_src_test" ]] ; then
37 - return
38 - fi
39 -
40 + ret=$?
41 eqawarn QA Notice: direct 'make' call by ${FUNCNAME[1]}
42 fi
43 +
44 + return ${ret}
45 }
46
47 #