[gentoo-commits] repo/gentoo:master commit in: app-text/uudeview/, app-text/uudeview/files/

[Joonas Niilola]

commit:     352af12a667285b8127b77fc2d39b820230da8e4
Author:     Ronny (tastytea) Gutbrod <gentoo <AT> tastytea <DOT> de>
AuthorDate: Sat May  1 16:05:43 2021 +0000
Commit:     Joonas Niilola <juippis <AT> gentoo <DOT> org>
CommitDate: Tue May 18 10:33:25 2021 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=352af12a

app-text/uudeview: Make append_signature() void.

It seems that the function is never called.

Closes: https://bugs.gentoo.org/735682
Signed-off-by: Ronny (tastytea) Gutbrod <gentoo <AT> tastytea.de>
Closes: https://github.com/gentoo/gentoo/pull/20630
Signed-off-by: Joonas Niilola <juippis <AT> gentoo.org>

 .../uudeview-0.5.20-fix-append_signature.patch     | 36 ++++++++++++++++++++++
 app-text/uudeview/uudeview-0.5.20-r2.ebuild        |  1 +
 2 files changed, 37 insertions(+)

diff --git a/app-text/uudeview/files/uudeview-0.5.20-fix-append_signature.patch b/app-text/uudeview/files/uudeview-0.5.20-fix-append_signature.patch
new file mode 100644
index 00000000000..3dfecc18cb9
--- /dev/null
+++ b/app-text/uudeview/files/uudeview-0.5.20-fix-append_signature.patch
@@ -0,0 +1,36 @@
+From 3bd5dee4226142df3645b8a027ef9142277257cf Mon Sep 17 00:00:00 2001
+From: tastytea <tastytea@××××××××.de>
+Date: Sat, 1 May 2021 17:51:47 +0200
+Subject: [PATCH] Make append_signature() void.
+
+If the type specifier is missing, it defaults to int. From the looks of
+it, the function is meant to be void.
+---
+ inews/inews.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/inews/inews.c b/inews/inews.c
+index 5fa309d..d1c1ee8 100644
+--- a/inews/inews.c
++++ b/inews/inews.c
+@@ -143,7 +143,7 @@ char	*argv[];
+ 		fprintf(ser_wr_fp, "%s\r\n", s);
+ 	}
+ 
+-	append_signature();
++	void append_signature();
+ 
+ 	fprintf(ser_wr_fp, ".\r\n");
+ 	(void) fflush(ser_wr_fp);
+@@ -181,7 +181,7 @@ char	*argv[];
+  * The rn-style DOTDIR environmental variable is used if present.
+  */
+ 
+-append_signature()
++void append_signature()
+ {
+ 	char	line[256], sigfile[256];
+ 	char	*cp;
+-- 
+2.26.3
+

diff --git a/app-text/uudeview/uudeview-0.5.20-r2.ebuild b/app-text/uudeview/uudeview-0.5.20-r2.ebuild
index c92ff28eafb..72fc9d499c8 100644
--- a/app-text/uudeview/uudeview-0.5.20-r2.ebuild
+++ b/app-text/uudeview/uudeview-0.5.20-r2.ebuild
@@ -20,6 +20,7 @@ PATCHES=(
 	"${FILESDIR}"/${P}-man.patch
 	"${FILESDIR}"/${P}-rename.patch
 	"${FILESDIR}"/${P}-makefile.patch
+	"${FILESDIR}"/${P}-fix-append_signature.patch
 )
 
 DOCS=( HISTORY INSTALL README )