Gentoo Archives: gentoo-commits

From: Sam James <sam@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: mail-filter/rspamd/, mail-filter/rspamd/files/
Date: Tue, 07 Sep 2021 20:25:29
Message-Id: 1631046227.066a3f86023d2329d692558e9f869fc892071d96.sam@gentoo
1 commit: 066a3f86023d2329d692558e9f869fc892071d96
2 Author: Petr Vaněk <arkamar <AT> atlas <DOT> cz>
3 AuthorDate: Mon Sep 6 06:42:00 2021 +0000
4 Commit: Sam James <sam <AT> gentoo <DOT> org>
5 CommitDate: Tue Sep 7 20:23:47 2021 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=066a3f86
7
8 mail-filter/rspamd: backport null dereference fix
9
10 This Backports patch which fixes possible runtime segfaults caused by
11 null pointer dereference.
12
13 Signed-off-by: Petr Vaněk <arkamar <AT> atlas.cz>
14 Signed-off-by: Sam James <sam <AT> gentoo.org>
15
16 .../files/rspamd-3.0-fix-null-dereference.patch | 46 ++++++++++++++++++++++
17 mail-filter/rspamd/rspamd-3.0-r2.ebuild | 1 +
18 2 files changed, 47 insertions(+)
19
20 diff --git a/mail-filter/rspamd/files/rspamd-3.0-fix-null-dereference.patch b/mail-filter/rspamd/files/rspamd-3.0-fix-null-dereference.patch
21 new file mode 100644
22 index 00000000000..d355f701a27
23 --- /dev/null
24 +++ b/mail-filter/rspamd/files/rspamd-3.0-fix-null-dereference.patch
25 @@ -0,0 +1,46 @@
26 +From abea3ac21f764658a966dad475fc99e4b79530d7 Mon Sep 17 00:00:00 2001
27 +From: Jan Smutny <js@×××××××.cz>
28 +Date: Tue, 31 Aug 2021 14:25:23 +0200
29 +Subject: [PATCH] [Fix] src/lua/lua_mimepart.c: fix null dereference
30 +
31 +---
32 +
33 +This patch is taken from upstream. It fixes possible runtime segfaults.
34 +
35 +PR: https://github.com/rspamd/rspamd/pull/3873
36 +
37 +diff --git a/src/lua/lua_mimepart.c b/src/lua/lua_mimepart.c
38 +index 66b588e3a..21a46d496 100644
39 +--- a/src/lua/lua_mimepart.c
40 ++++ b/src/lua/lua_mimepart.c
41 +@@ -1240,7 +1240,16 @@ lua_textpart_get_fuzzy_hashes (lua_State * L)
42 + rspamd_stat_token_t *word;
43 + struct lua_shingle_filter_cbdata cbd;
44 +
45 +- if (part && pool) {
46 ++
47 ++ if (part == NULL || pool == NULL) {
48 ++ return luaL_error (L, "invalid arguments");
49 ++ }
50 ++
51 ++ if (IS_TEXT_PART_EMPTY (part) || part->utf_words == NULL) {
52 ++ lua_pushnil (L);
53 ++ lua_pushnil (L);
54 ++ }
55 ++ else {
56 + /* TODO: add keys and algorithms support */
57 + rspamd_cryptobox_hash (key, "rspamd", strlen ("rspamd"), NULL, 0);
58 +
59 +@@ -1294,9 +1303,6 @@ lua_textpart_get_fuzzy_hashes (lua_State * L)
60 + }
61 + }
62 + }
63 +- else {
64 +- return luaL_error (L, "invalid arguments");
65 +- }
66 +
67 + return 2;
68 + }
69 +--
70 +2.31.1
71 +
72
73 diff --git a/mail-filter/rspamd/rspamd-3.0-r2.ebuild b/mail-filter/rspamd/rspamd-3.0-r2.ebuild
74 index efe18dc57b0..30065ff095b 100644
75 --- a/mail-filter/rspamd/rspamd-3.0-r2.ebuild
76 +++ b/mail-filter/rspamd/rspamd-3.0-r2.ebuild
77 @@ -60,6 +60,7 @@ BDEPEND="
78 PATCHES=(
79 "${FILESDIR}/${P}-cmake-lua-version.patch"
80 "${FILESDIR}/${P}-system-libfmt.patch"
81 + "${FILESDIR}/${P}-fix-null-dereference.patch"
82 "${FILESDIR}/${PN}-2.6-unbundle-lua.patch"
83 "${FILESDIR}/${PN}-2.5-unbundle-snowball.patch"
84 )