Gentoo Archives: gentoo-commits

From: Matt Turner <mattst88@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/catalyst:stage4-user-groups-fixes commit in: catalyst/base/
Date: Fri, 13 May 2022 17:43:50
Message-Id: 1652463735.214bb3d849d5bf7ce2314aab1858ed6e72b28108.mattst88@gentoo
1 commit: 214bb3d849d5bf7ce2314aab1858ed6e72b28108
2 Author: Daniel Cordero <gentoo.catalyst <AT> 0xdc <DOT> io>
3 AuthorDate: Thu Apr 21 07:08:24 2022 +0000
4 Commit: Matt Turner <mattst88 <AT> gentoo <DOT> org>
5 CommitDate: Fri May 13 17:42:15 2022 +0000
6 URL: https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=214bb3d8
7
8 catalyst/stage4: don't run split on a list
9
10 "groups" has been normalised into a list and does not have a split()
11 method.
12
13 Fixes: 5be6069b ("catalyst: support 3 new options")
14 Signed-off-by: Daniel Cordero <gentoo.catalyst <AT> 0xdc.io>
15 Signed-off-by: Matt Turner <mattst88 <AT> gentoo.org>
16
17 catalyst/base/stagebase.py | 2 +-
18 1 file changed, 1 insertion(+), 1 deletion(-)
19
20 diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
21 index 1d71c59d..7e6b9e32 100644
22 --- a/catalyst/base/stagebase.py
23 +++ b/catalyst/base/stagebase.py
24 @@ -931,7 +931,7 @@ class StageBase(TargetBase, ClearBase, GenBase):
25 env=self.env)
26
27 def groups(self):
28 - for x in self.settings["groups"].split():
29 + for x in self.settings["groups"]:
30 log.notice("Creating group: '%s'", x)
31 cmd(["groupadd", "-R", self.settings['chroot_path'], x], env=self.env)