Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-frameworks/kio/files/, kde-frameworks/kio/
Date: Tue, 14 Sep 2021 09:04:44
Message-Id: 1631610211.b7c85ff59071636cb109f0b7229ab9a3f279b8a2.asturm@gentoo
1 commit: b7c85ff59071636cb109f0b7229ab9a3f279b8a2
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Tue Sep 14 08:06:57 2021 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Tue Sep 14 09:03:31 2021 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b7c85ff5
7
8 kde-frameworks/kio: drop 5.82.0*
9
10 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
11
12 kde-frameworks/kio/Manifest | 1 -
13 .../kio-5.81.0-fix-qtconcurrent-private-link.patch | 46 ---------
14 .../kio-5.82.0-MimeTypeFinderJob-memleak-1.patch | 69 -------------
15 .../kio-5.82.0-MimeTypeFinderJob-memleak-2.patch | 61 -----------
16 .../kio-5.82.0-MimeTypeFinderJob-memleak-3.patch | 52 ----------
17 .../kio-5.82.0-MimeTypeFinderJob-memleak-4.patch | 62 ------------
18 .../kio-5.82.0-fix-filenamesearch-crashes.patch | 28 ------
19 .../kio/files/kio-5.82.0-no-cache-kcm.patch | 79 ---------------
20 .../kio/files/kio-5.82.0-no-useragent-kcm.patch | 105 -------------------
21 kde-frameworks/kio/kio-5.82.0-r2.ebuild | 111 ---------------------
22 10 files changed, 614 deletions(-)
23
24 diff --git a/kde-frameworks/kio/Manifest b/kde-frameworks/kio/Manifest
25 index c4bfe59fdca..2e46d8cebbd 100644
26 --- a/kde-frameworks/kio/Manifest
27 +++ b/kde-frameworks/kio/Manifest
28 @@ -1,3 +1,2 @@
29 -DIST kio-5.82.0.tar.xz 3330028 BLAKE2B be2d22adec291f8e5f6be5227d33e4ca505b43c3888174cfe667dc7fc3bf6d1a383178238540b4598028c61c51498e5d94f3ba3c7e354d82f8dfdf11f7c7fbd0 SHA512 a14f42a8c96fb8b1f435d4120805628f877132b588c2c1f983af6409603baffbcdad99f1c296fef99dd78fb7edbf526fd95f85970ccbf91887619eb5728cb3dc
30 DIST kio-5.85.0.tar.xz 3200300 BLAKE2B fd723dba761b81862bf503645a8526a246867e5a10441f3edf895e4107c189ead357615e17f3704325976ed29867c54f98bc11b4e977e21a78d429ee7efa2dde SHA512 73c69743f3d99671ced8176bf9806df54eb3afd04dbdd9dd92b79c9979428f980d3dbda9504c81aca4aa36249b3e43edcc38831497752e31a510a70ee98dc4e8
31 DIST kio-5.86.0.tar.xz 3251976 BLAKE2B 5257ad0be8023ec661262fcd96f3f5860357fda73d1a039fbb30e549f4bb0bcab62217ccea70c22ecea63622ecbccfbeae27afe3692470be738f813e466a9142 SHA512 64a4ae7b0fff6e4e2c5ee3a25ec6db472c198fbcce5d8a929da2d42f6a881e404151a1935532c53359b645acac2a46ffa129616acb26b871dc7993b91a31fd8e
32
33 diff --git a/kde-frameworks/kio/files/kio-5.81.0-fix-qtconcurrent-private-link.patch b/kde-frameworks/kio/files/kio-5.81.0-fix-qtconcurrent-private-link.patch
34 deleted file mode 100644
35 index 42637cd6e1e..00000000000
36 --- a/kde-frameworks/kio/files/kio-5.81.0-fix-qtconcurrent-private-link.patch
37 +++ /dev/null
38 @@ -1,46 +0,0 @@
39 -From e6825658b7f59a3a933559def9aebf21ff0efb7f Mon Sep 17 00:00:00 2001
40 -From: Andreas Sturmlechner <asturm@g.o>
41 -Date: Fri, 23 Apr 2021 20:10:31 +0200
42 -Subject: [PATCH] Drop find_dependency(Qt5Concurrent) from
43 - KF5KIOConfig.cmake.in
44 -
45 -This was added in 2f83dde2c8e8a25f0fe3dd52012bb49cb69e1ea5 but as far as I can
46 -see it is only a KIO build time dependency with no Qt5Concurrent header being
47 -used in KIO headers.
48 -
49 -Signed-off-by: Andreas Sturmlechner <asturm@g.o>
50 ----
51 - KF5KIOConfig.cmake.in | 1 -
52 - src/core/CMakeLists.txt | 2 +-
53 - 2 files changed, 1 insertion(+), 2 deletions(-)
54 -
55 -diff --git a/KF5KIOConfig.cmake.in b/KF5KIOConfig.cmake.in
56 -index 687ec512..749e9b9b 100644
57 ---- a/KF5KIOConfig.cmake.in
58 -+++ b/KF5KIOConfig.cmake.in
59 -@@ -21,7 +21,6 @@ find_dependency(KF5WindowSystem "@KF_DEP_VERSION@")
60 - endif()
61 -
62 - find_dependency(Qt5Network "@REQUIRED_QT_VERSION@")
63 --find_dependency(Qt5Concurrent "@REQUIRED_QT_VERSION@")
64 - find_dependency(Qt5DBus "@REQUIRED_QT_VERSION@")
65 -
66 - include("${CMAKE_CURRENT_LIST_DIR}/KF5KIOTargets.cmake")
67 -diff --git a/src/core/CMakeLists.txt b/src/core/CMakeLists.txt
68 -index 76c3061c..fe4be56b 100644
69 ---- a/src/core/CMakeLists.txt
70 -+++ b/src/core/CMakeLists.txt
71 -@@ -188,9 +188,9 @@ PUBLIC
72 - KF5::CoreAddons # KJob
73 - KF5::Service # TODO KF6 move to PRIVATE
74 - Qt5::Network
75 -- Qt5::Concurrent # QtConcurrentRun in hostinfo.cpp
76 - Qt5::DBus
77 - PRIVATE
78 -+ Qt5::Concurrent # QtConcurrentRun in hostinfo.cpp
79 - Qt5::Xml # davjob.cpp uses QDom
80 - KF5::ConfigCore
81 - KF5::I18n
82 ---
83 -2.31.1
84 -
85
86 diff --git a/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-1.patch b/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-1.patch
87 deleted file mode 100644
88 index 08d72d754d7..00000000000
89 --- a/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-1.patch
90 +++ /dev/null
91 @@ -1,69 +0,0 @@
92 -From e79da836c34fce66231e396c7215314d0eba51b4 Mon Sep 17 00:00:00 2001
93 -From: Jonathan Marten <jjm@×××××××××××.uk>
94 -Date: Sat, 8 May 2021 15:20:39 +0000
95 -Subject: [PATCH] MimeTypeFinderJob: Resolve symlinks for a local file
96 -
97 ----
98 - autotests/mimetypefinderjobtest.cpp | 18 +++++++++++++++++-
99 - src/core/mimetypefinderjob.cpp | 2 +-
100 - 2 files changed, 18 insertions(+), 2 deletions(-)
101 -
102 -diff --git a/autotests/mimetypefinderjobtest.cpp b/autotests/mimetypefinderjobtest.cpp
103 -index 72296b9b8..f494ff3b6 100644
104 ---- a/autotests/mimetypefinderjobtest.cpp
105 -+++ b/autotests/mimetypefinderjobtest.cpp
106 -@@ -48,6 +48,7 @@ void MimeTypeFinderJobTest::determineMimeType_data()
107 - QTest::newRow("text_file_no_extension") << "text/plain" << "srcfile";
108 - QTest::newRow("desktop_file") << "application/x-desktop" << "foo.desktop";
109 - QTest::newRow("script") << "application/x-shellscript" << "srcfile.sh";
110 -+ QTest::newRow("directory") << "inode/directory" << "srcdir";
111 - /* clang-format on */
112 - }
113 -
114 -@@ -60,7 +61,12 @@ void MimeTypeFinderJobTest::determineMimeType()
115 - QTemporaryDir tempDir;
116 - const QString srcDir = tempDir.path();
117 - const QString srcFile = srcDir + QLatin1Char('/') + fileName;
118 -- createSrcFile(srcFile);
119 -+ if (mimeType == "inode/directory") {
120 -+ QVERIFY(QDir(srcDir).mkdir(fileName));
121 -+ } else {
122 -+ createSrcFile(srcFile);
123 -+ }
124 -+
125 - QVERIFY(QFile::exists(srcFile));
126 - const QUrl url = QUrl::fromLocalFile(srcFile);
127 -
128 -@@ -68,6 +74,16 @@ void MimeTypeFinderJobTest::determineMimeType()
129 - KIO::MimeTypeFinderJob *job = new KIO::MimeTypeFinderJob(url, this);
130 - QVERIFY2(job->exec(), qPrintable(job->errorString()));
131 - QCOMPARE(job->mimeType(), mimeType);
132 -+
133 -+ // Check that the result is the same when accessing the source
134 -+ // file through a symbolic link (bug #436708)
135 -+ const QString srcLink = srcDir + QLatin1String("/link_") + fileName;
136 -+ QVERIFY(QFile::link(srcFile, srcLink));
137 -+ const QUrl linkUrl = QUrl::fromLocalFile(srcLink);
138 -+
139 -+ job = new KIO::MimeTypeFinderJob(linkUrl, this);
140 -+ QVERIFY2(job->exec(), qPrintable(job->errorString()));
141 -+ QCOMPARE(job->mimeType(), mimeType);
142 - }
143 -
144 - void MimeTypeFinderJobTest::invalidUrl()
145 -diff --git a/src/core/mimetypefinderjob.cpp b/src/core/mimetypefinderjob.cpp
146 -index f5e50cdc4..48fc8c289 100644
147 ---- a/src/core/mimetypefinderjob.cpp
148 -+++ b/src/core/mimetypefinderjob.cpp
149 -@@ -122,7 +122,7 @@ void KIO::MimeTypeFinderJobPrivate::statFile()
150 - {
151 - Q_ASSERT(m_mimeTypeName.isEmpty());
152 -
153 -- KIO::StatJob *job = KIO::statDetails(m_url, KIO::StatJob::SourceSide, KIO::StatBasic, KIO::HideProgressInfo);
154 -+ KIO::StatJob *job = KIO::statDetails(m_url, KIO::StatJob::SourceSide, KIO::StatBasic | KIO::StatResolveSymlink, KIO::HideProgressInfo);
155 - if (!m_authPrompts) {
156 - job->addMetaData(QStringLiteral("no-auth-prompt"), QStringLiteral("true"));
157 - }
158 ---
159 -GitLab
160 -
161
162 diff --git a/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-2.patch b/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-2.patch
163 deleted file mode 100644
164 index bf3ff50802f..00000000000
165 --- a/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-2.patch
166 +++ /dev/null
167 @@ -1,61 +0,0 @@
168 -From c748d6987252fafc296cde9351b289ef734cf861 Mon Sep 17 00:00:00 2001
169 -From: Ahmad Samir <a.samirh78@×××××.com>
170 -Date: Thu, 13 May 2021 23:03:57 +0200
171 -Subject: [PATCH] kio_file: pass the absolute path to
172 - QMimeDatabase::mimeTypeForFile()
173 -
174 -Otherwise detecting the mime type based on the file content may fail and
175 -return application/octet-stream.
176 -
177 -And pass the whole url to createUDSEntry(), less QFile::decodeName/encodeName()
178 -in the middle is better and less error prone.
179 -
180 -Note that without this change a MimeTypeFinderJob could end up failing to
181 -find the mime type of a local file based on the file contents.
182 ----
183 - src/ioslaves/file/file_unix.cpp | 8 ++++----
184 - 1 file changed, 4 insertions(+), 4 deletions(-)
185 -
186 -diff --git a/src/ioslaves/file/file_unix.cpp b/src/ioslaves/file/file_unix.cpp
187 -index 99d46c8f1..940e3cbc4 100644
188 ---- a/src/ioslaves/file/file_unix.cpp
189 -+++ b/src/ioslaves/file/file_unix.cpp
190 -@@ -364,7 +364,7 @@ inline static time_t stat_mtime(QT_STATBUF &buf)
191 - }
192 - #endif
193 -
194 --static bool createUDSEntry(const QString &filename, const QByteArray &path, UDSEntry &entry, KIO::StatDetails details)
195 -+static bool createUDSEntry(const QString &filename, const QByteArray &path, UDSEntry &entry, KIO::StatDetails details, const QUrl &url)
196 - {
197 - assert(entry.count() == 0); // by contract :-)
198 - int entries = 0;
199 -@@ -539,7 +539,7 @@ static bool createUDSEntry(const QString &filename, const QByteArray &path, UDSE
200 -
201 - if (details & KIO::StatMimeType) {
202 - QMimeDatabase db;
203 -- entry.fastInsert(KIO::UDSEntry::UDS_MIME_TYPE, db.mimeTypeForFile(filename).name());
204 -+ entry.fastInsert(KIO::UDSEntry::UDS_MIME_TYPE, db.mimeTypeForFile(url.toLocalFile()).name());
205 - }
206 -
207 - return true;
208 -@@ -1186,7 +1186,7 @@ void FileProtocol::listDir(const QUrl &url)
209 - listEntry(entry);
210 -
211 - } else {
212 -- if (createUDSEntry(filename, QByteArray(ep->d_name), entry, details)) {
213 -+ if (createUDSEntry(filename, QByteArray(ep->d_name), entry, details, url)) {
214 - #if HAVE_SYS_XATTR_H
215 - if (isNtfsHidden(filename)) {
216 - bool ntfsHidden = true;
217 -@@ -1476,7 +1476,7 @@ void FileProtocol::stat(const QUrl &url)
218 - const KIO::StatDetails details = getStatDetails();
219 -
220 - UDSEntry entry;
221 -- if (!createUDSEntry(url.fileName(), _path, entry, details)) {
222 -+ if (!createUDSEntry(url.fileName(), _path, entry, details, url)) {
223 - error(KIO::ERR_DOES_NOT_EXIST, path);
224 - return;
225 - }
226 ---
227 -GitLab
228 -
229
230 diff --git a/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-3.patch b/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-3.patch
231 deleted file mode 100644
232 index a9c55e1f7f2..00000000000
233 --- a/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-3.patch
234 +++ /dev/null
235 @@ -1,52 +0,0 @@
236 -From c19876052ecec18a87a82f5950e8909e22e895ba Mon Sep 17 00:00:00 2001
237 -From: Ahmad Samir <a.samirh78@×××××.com>
238 -Date: Thu, 13 May 2021 17:02:52 +0200
239 -Subject: [PATCH] MimeTypeFinderJob: the StatJob details should include the
240 - mimetype
241 -
242 -Apparently we forgot to specify that we want the UDS_MIME_TYPE field in
243 -the statFile() method (both when it lived in OpenUrlJob and when it was moved
244 -to MimeTypeFinderJob). And now there is a dedicated StatJob flag, StatMimeType,
245 -that we can use.
246 -
247 -Not passing KIO::StatMimeType when creating the StatJob meant the code always
248 -used a get job to determine the mime type, which mean that e.g. opening an
249 -ISO file from Dolphin, which supposedly just needs to launch Ark, had the
250 -whole file read into memory, which means that opening a couple of ISO's and
251 -you're out of memory...
252 -
253 -Thanks to sitter for doing a big chunk of the investigative work in the bug
254 -report.
255 -
256 -CCBUG: 398908
257 ----
258 - src/core/mimetypefinderjob.cpp | 6 +++++-
259 - 1 file changed, 5 insertions(+), 1 deletion(-)
260 -
261 -diff --git a/src/core/mimetypefinderjob.cpp b/src/core/mimetypefinderjob.cpp
262 -index 48fc8c289..baca58695 100644
263 ---- a/src/core/mimetypefinderjob.cpp
264 -+++ b/src/core/mimetypefinderjob.cpp
265 -@@ -122,7 +122,9 @@ void KIO::MimeTypeFinderJobPrivate::statFile()
266 - {
267 - Q_ASSERT(m_mimeTypeName.isEmpty());
268 -
269 -- KIO::StatJob *job = KIO::statDetails(m_url, KIO::StatJob::SourceSide, KIO::StatBasic | KIO::StatResolveSymlink, KIO::HideProgressInfo);
270 -+ static constexpr auto statFlags = KIO::StatBasic | KIO::StatResolveSymlink | KIO::StatMimeType;
271 -+
272 -+ KIO::StatJob *job = KIO::statDetails(m_url, KIO::StatJob::SourceSide, statFlags, KIO::HideProgressInfo);
273 - if (!m_authPrompts) {
274 - job->addMetaData(QStringLiteral("no-auth-prompt"), QStringLiteral("true"));
275 - }
276 -@@ -147,6 +149,8 @@ void KIO::MimeTypeFinderJobPrivate::statFile()
277 -
278 - const KIO::UDSEntry entry = job->statResult();
279 -
280 -+ qCDebug(KIO_CORE) << "UDSEntry from StatJob in MimeTypeFinderJob" << entry;
281 -+
282 - const QString localPath = entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH);
283 - if (!localPath.isEmpty()) {
284 - m_url = QUrl::fromLocalFile(localPath);
285 ---
286 -GitLab
287 -
288
289 diff --git a/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-4.patch b/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-4.patch
290 deleted file mode 100644
291 index 9e59a0eb16e..00000000000
292 --- a/kde-frameworks/kio/files/kio-5.82.0-MimeTypeFinderJob-memleak-4.patch
293 +++ /dev/null
294 @@ -1,62 +0,0 @@
295 -From 71484c97dee0c977a00f141123d8ccd9b93c2e96 Mon Sep 17 00:00:00 2001
296 -From: Ahmad Samir <a.samirh78@×××××.com>
297 -Date: Fri, 14 May 2021 21:19:31 +0200
298 -Subject: [PATCH] kio_file: fix how createUDSEntry() is called
299 -
300 -When calling createUDSEntry() from listDir(), we need to concatenate the full
301 -path to the item.
302 -
303 -This is an addendum to commit c748d6987252f.
304 ----
305 - src/ioslaves/file/file_unix.cpp | 14 ++++++++++----
306 - 1 file changed, 10 insertions(+), 4 deletions(-)
307 -
308 -diff --git a/src/ioslaves/file/file_unix.cpp b/src/ioslaves/file/file_unix.cpp
309 -index 940e3cbc4..3573c200e 100644
310 ---- a/src/ioslaves/file/file_unix.cpp
311 -+++ b/src/ioslaves/file/file_unix.cpp
312 -@@ -364,7 +364,7 @@ inline static time_t stat_mtime(QT_STATBUF &buf)
313 - }
314 - #endif
315 -
316 --static bool createUDSEntry(const QString &filename, const QByteArray &path, UDSEntry &entry, KIO::StatDetails details, const QUrl &url)
317 -+static bool createUDSEntry(const QString &filename, const QByteArray &path, UDSEntry &entry, KIO::StatDetails details, const QString &fullPath)
318 - {
319 - assert(entry.count() == 0); // by contract :-)
320 - int entries = 0;
321 -@@ -539,7 +539,7 @@ static bool createUDSEntry(const QString &filename, const QByteArray &path, UDSE
322 -
323 - if (details & KIO::StatMimeType) {
324 - QMimeDatabase db;
325 -- entry.fastInsert(KIO::UDSEntry::UDS_MIME_TYPE, db.mimeTypeForFile(url.toLocalFile()).name());
326 -+ entry.fastInsert(KIO::UDSEntry::UDS_MIME_TYPE, db.mimeTypeForFile(fullPath).name());
327 - }
328 -
329 - return true;
330 -@@ -1186,7 +1186,13 @@ void FileProtocol::listDir(const QUrl &url)
331 - listEntry(entry);
332 -
333 - } else {
334 -- if (createUDSEntry(filename, QByteArray(ep->d_name), entry, details, url)) {
335 -+ QString fullPath(path);
336 -+ if (!fullPath.endsWith(QLatin1Char('/'))) {
337 -+ fullPath += QLatin1Char('/');
338 -+ }
339 -+ fullPath += filename;
340 -+
341 -+ if (createUDSEntry(filename, QByteArray(ep->d_name), entry, details, fullPath)) {
342 - #if HAVE_SYS_XATTR_H
343 - if (isNtfsHidden(filename)) {
344 - bool ntfsHidden = true;
345 -@@ -1476,7 +1482,7 @@ void FileProtocol::stat(const QUrl &url)
346 - const KIO::StatDetails details = getStatDetails();
347 -
348 - UDSEntry entry;
349 -- if (!createUDSEntry(url.fileName(), _path, entry, details, url)) {
350 -+ if (!createUDSEntry(url.fileName(), _path, entry, details, path)) {
351 - error(KIO::ERR_DOES_NOT_EXIST, path);
352 - return;
353 - }
354 ---
355 -GitLab
356 -
357
358 diff --git a/kde-frameworks/kio/files/kio-5.82.0-fix-filenamesearch-crashes.patch b/kde-frameworks/kio/files/kio-5.82.0-fix-filenamesearch-crashes.patch
359 deleted file mode 100644
360 index b92139a5187..00000000000
361 --- a/kde-frameworks/kio/files/kio-5.82.0-fix-filenamesearch-crashes.patch
362 +++ /dev/null
363 @@ -1,28 +0,0 @@
364 -From a38fcf356de0cbba1ce97c8ef70979ed897a8094 Mon Sep 17 00:00:00 2001
365 -From: Kai Uwe Broulik <kde@××××××××××××××.de>
366 -Date: Tue, 18 May 2021 19:54:54 +0200
367 -Subject: [PATCH] [KCoreDirLister] Guard uiDelegate(), it might be null
368 -
369 -BUG: 437153
370 ----
371 - src/core/kcoredirlister.cpp | 4 +++-
372 - 1 file changed, 3 insertions(+), 1 deletion(-)
373 -
374 -diff --git a/src/core/kcoredirlister.cpp b/src/core/kcoredirlister.cpp
375 -index a836f0aa..58d8791c 100644
376 ---- a/src/core/kcoredirlister.cpp
377 -+++ b/src/core/kcoredirlister.cpp
378 -@@ -1288,7 +1288,9 @@ void KCoreDirListerCache::slotResult(KJob *j)
379 - Q_EMIT kdl->jobError(job);
380 - if (kdl->d->m_autoErrorHandling && !errorShown) {
381 - errorShown = true; // do it only once
382 -- job->uiDelegate()->showErrorMessage();
383 -+ if (job->uiDelegate()) {
384 -+ job->uiDelegate()->showErrorMessage();
385 -+ }
386 - }
387 - #if KIOCORE_BUILD_DEPRECATED_SINCE(5, 82)
388 - kdl->handleError(job);
389 ---
390 -2.31.1
391 -
392
393 diff --git a/kde-frameworks/kio/files/kio-5.82.0-no-cache-kcm.patch b/kde-frameworks/kio/files/kio-5.82.0-no-cache-kcm.patch
394 deleted file mode 100644
395 index 9cc0379b699..00000000000
396 --- a/kde-frameworks/kio/files/kio-5.82.0-no-cache-kcm.patch
397 +++ /dev/null
398 @@ -1,79 +0,0 @@
399 -From 581fab08ff4d5539e4684adcffc74ec3517ce29d Mon Sep 17 00:00:00 2001
400 -From: Nicolas Fella <nicolas.fella@×××.de>
401 -Date: Thu, 6 May 2021 21:26:31 +0200
402 -Subject: [PATCH] Remove the cache KCM
403 -
404 -Same reasoning as for
405 -https://invent.kde.org/frameworks/kio/-/merge_requests/438.
406 -
407 -It is very targeted towards KIO-based browsers which don't really exist
408 -any more.
409 -
410 -The setting is also global to everything that uses KIO and it's a bit
411 -questionable whether for example webdav browsing in Dolphin should
412 -automatically have the same cache settings as network access in Choqok.
413 -
414 -It being part of system settings is also confusing for users since it
415 -gives the false impression of true globality. They might expect it to
416 -affect Firefox or Webengine-based Konqueror which it does not.
417 ----
418 - docs/kcontrol5/CMakeLists.txt | 1 -
419 - src/kcms/kio/CMakeLists.txt | 4 +-
420 - src/kcms/kio/main.cpp | 4 +-
421 - 3 files changed, 2 insertions(+), 7 deletions(-)
422 -
423 -diff --git a/docs/kcontrol5/CMakeLists.txt b/docs/kcontrol5/CMakeLists.txt
424 -index 2dd1ae16a..6c2f21b07 100644
425 ---- a/docs/kcontrol5/CMakeLists.txt
426 -+++ b/docs/kcontrol5/CMakeLists.txt
427 -@@ -1,4 +1,3 @@
428 --add_subdirectory(cache)
429 - add_subdirectory(cookies)
430 - add_subdirectory(netpref)
431 - add_subdirectory(proxy)
432 -diff --git a/src/kcms/kio/CMakeLists.txt b/src/kcms/kio/CMakeLists.txt
433 -index 11cd239f2..5281fc7dc 100644
434 ---- a/src/kcms/kio/CMakeLists.txt
435 -+++ b/src/kcms/kio/CMakeLists.txt
436 -@@ -12,11 +12,9 @@ set(kcm_kio_PART_SRCS
437 - smbrodlg.cpp
438 - kproxydlg.cpp
439 - netpref.cpp
440 -- cache.cpp
441 - ksaveioconfig.cpp)
442 -
443 - ki18n_wrap_ui(kcm_kio_PART_SRCS
444 -- cache.ui
445 - kproxydlg.ui
446 - kcookiespolicies.ui
447 - kcookiesmanagement.ui
448 -@@ -41,5 +39,5 @@ install(TARGETS kcm_kio DESTINATION ${KDE_INSTALL_PLUGINDIR} )
449 -
450 - ########### install files ###############
451 -
452 --install( FILES smb.desktop cookies.desktop cache.desktop
453 -+install( FILES smb.desktop cookies.desktop
454 - netpref.desktop proxy.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
455 -diff --git a/src/kcms/kio/main.cpp b/src/kcms/kio/main.cpp
456 -index 8bacb10ca..2c0ebc29b 100644
457 ---- a/src/kcms/kio/main.cpp
458 -+++ b/src/kcms/kio/main.cpp
459 -@@ -13,7 +13,6 @@
460 - #include <KPluginFactory>
461 -
462 - // Local
463 --#include "cache.h"
464 - #include "kcookiesmain.h"
465 - #include "kproxydlg.h"
466 - #include "netpref.h"
467 -@@ -21,7 +20,6 @@
468 -
469 - K_PLUGIN_FACTORY(KioConfigFactory, registerPlugin<SMBRoOptions>(QStringLiteral("smb")); registerPlugin<KIOPreferences>(QStringLiteral("netpref"));
470 - registerPlugin<KProxyDialog>(QStringLiteral("proxy"));
471 -- registerPlugin<KCookiesMain>(QStringLiteral("cookie"));
472 -- registerPlugin<CacheConfigModule>(QStringLiteral("cache"));)
473 -+ registerPlugin<KCookiesMain>(QStringLiteral("cookie"));)
474 -
475 - #include "main.moc"
476 ---
477 -GitLab
478
479 diff --git a/kde-frameworks/kio/files/kio-5.82.0-no-useragent-kcm.patch b/kde-frameworks/kio/files/kio-5.82.0-no-useragent-kcm.patch
480 deleted file mode 100644
481 index ce0e891e916..00000000000
482 --- a/kde-frameworks/kio/files/kio-5.82.0-no-useragent-kcm.patch
483 +++ /dev/null
484 @@ -1,105 +0,0 @@
485 -From 1aa42558a0f539abfe4bc92cf2c8078ac4adb9a0 Mon Sep 17 00:00:00 2001
486 -From: Nicolas Fella <nicolas.fella@×××.de>
487 -Date: Wed, 5 May 2021 22:27:25 +0200
488 -Subject: [PATCH] Remove the Browser Identification KCM
489 -
490 -It's purpose is to control the user agent used by kio-http.
491 -
492 -Very few things use kio-http these days, not even Konqueror with the
493 -webengine part.
494 -
495 -For the remaining use cases (kioclient, webdav kio worker, etc.) this
496 -kind of configurability is overkill.
497 -
498 -Moreover being part of systemsettings this gives a false impression of
499 -globality. A user might change something in there and wonder why it does
500 -not apply to Firefox or Falkon.
501 -
502 -Given the questionable usefulness and the potential for confusion I
503 -propose to remove it entirely.
504 ----
505 - docs/kcontrol5/CMakeLists.txt | 1 -
506 - src/kcms/kio/CMakeLists.txt | 18 +-
507 - src/kcms/kio/main.cpp | 4 +-
508 - 3 files changed, 2 insertions(+), 21 deletions(-)
509 -
510 -diff --git a/docs/kcontrol5/CMakeLists.txt b/docs/kcontrol5/CMakeLists.txt
511 -index 1b19e5e7b..2dd1ae16a 100644
512 ---- a/docs/kcontrol5/CMakeLists.txt
513 -+++ b/docs/kcontrol5/CMakeLists.txt
514 -@@ -4,5 +4,4 @@ add_subdirectory(netpref)
515 - add_subdirectory(proxy)
516 - add_subdirectory(smb)
517 - add_subdirectory(trash)
518 --add_subdirectory(useragent)
519 - add_subdirectory(webshortcuts)
520 -diff --git a/src/kcms/kio/CMakeLists.txt b/src/kcms/kio/CMakeLists.txt
521 -index a354651b0..11cd239f2 100644
522 ---- a/src/kcms/kio/CMakeLists.txt
523 -+++ b/src/kcms/kio/CMakeLists.txt
524 -@@ -1,6 +1,4 @@
525 -
526 --add_subdirectory( uasproviders )
527 --
528 - find_package(KF5TextWidgets ${KF_DEP_VERSION} REQUIRED)
529 -
530 - ########### next target ###############
531 -@@ -12,31 +10,18 @@ set(kcm_kio_PART_SRCS
532 - kcookiesmanagement.cpp
533 - kcookiespolicyselectiondlg.cpp
534 - smbrodlg.cpp
535 -- useragentdlg.cpp
536 - kproxydlg.cpp
537 -- useragentinfo.cpp
538 -- useragentselectordlg.cpp
539 - netpref.cpp
540 - cache.cpp
541 - ksaveioconfig.cpp)
542 -
543 - ki18n_wrap_ui(kcm_kio_PART_SRCS
544 - cache.ui
545 -- useragentselectordlg.ui
546 -- useragentdlg.ui
547 - kproxydlg.ui
548 - kcookiespolicies.ui
549 - kcookiesmanagement.ui
550 - kcookiespolicyselectiondlg.ui)
551 -
552 --ecm_qt_export_logging_category(
553 -- IDENTIFIER KIO_USERAGENTDLG
554 -- CATEGORY_NAME kf.configwidgets.cms.kf.kio.useragentdlg
555 -- OLD_CATEGORY_NAMES kf5.kio.useragentdlg
556 -- DESCRIPTION "kio useragentdialog (KIO)"
557 -- EXPORT KIO
558 --)
559 --
560 - add_library(kcm_kio MODULE ${kcm_kio_PART_SRCS})
561 -
562 - target_link_libraries(kcm_kio
563 -@@ -56,6 +41,5 @@ install(TARGETS kcm_kio DESTINATION ${KDE_INSTALL_PLUGINDIR} )
564 -
565 - ########### install files ###############
566 -
567 --install( FILES smb.desktop cookies.desktop useragent.desktop cache.desktop
568 -+install( FILES smb.desktop cookies.desktop cache.desktop
569 - netpref.desktop proxy.desktop DESTINATION ${KDE_INSTALL_KSERVICES5DIR} )
570 --install( FILES uasprovider.desktop DESTINATION ${KDE_INSTALL_KSERVICETYPES5DIR} )
571 -diff --git a/src/kcms/kio/main.cpp b/src/kcms/kio/main.cpp
572 -index f1b065f46..8bacb10ca 100644
573 ---- a/src/kcms/kio/main.cpp
574 -+++ b/src/kcms/kio/main.cpp
575 -@@ -18,10 +18,8 @@
576 - #include "kproxydlg.h"
577 - #include "netpref.h"
578 - #include "smbrodlg.h"
579 --#include "useragentdlg.h"
580 -
581 --K_PLUGIN_FACTORY(KioConfigFactory, registerPlugin<UserAgentDlg>(QStringLiteral("useragent")); registerPlugin<SMBRoOptions>(QStringLiteral("smb"));
582 -- registerPlugin<KIOPreferences>(QStringLiteral("netpref"));
583 -+K_PLUGIN_FACTORY(KioConfigFactory, registerPlugin<SMBRoOptions>(QStringLiteral("smb")); registerPlugin<KIOPreferences>(QStringLiteral("netpref"));
584 - registerPlugin<KProxyDialog>(QStringLiteral("proxy"));
585 - registerPlugin<KCookiesMain>(QStringLiteral("cookie"));
586 - registerPlugin<CacheConfigModule>(QStringLiteral("cache"));)
587 ---
588 -GitLab
589 -
590
591 diff --git a/kde-frameworks/kio/kio-5.82.0-r2.ebuild b/kde-frameworks/kio/kio-5.82.0-r2.ebuild
592 deleted file mode 100644
593 index 74aef058f24..00000000000
594 --- a/kde-frameworks/kio/kio-5.82.0-r2.ebuild
595 +++ /dev/null
596 @@ -1,111 +0,0 @@
597 -# Copyright 1999-2021 Gentoo Authors
598 -# Distributed under the terms of the GNU General Public License v2
599 -
600 -EAPI=7
601 -
602 -ECM_DESIGNERPLUGIN="true"
603 -ECM_TEST="forceoptional"
604 -PVCUT=$(ver_cut 1-2)
605 -QTMIN=5.15.2
606 -VIRTUALX_REQUIRED="test"
607 -inherit ecm kde.org xdg-utils
608 -
609 -DESCRIPTION="Framework providing transparent file and data management"
610 -
611 -LICENSE="LGPL-2+"
612 -KEYWORDS="amd64 ~arm arm64 ~ppc64 x86"
613 -IUSE="acl +handbook kerberos +kwallet X"
614 -
615 -# tests hang
616 -RESTRICT+=" test"
617 -
618 -RDEPEND="
619 - dev-libs/libxml2
620 - dev-libs/libxslt
621 - >=dev-qt/qtdbus-${QTMIN}:5
622 - >=dev-qt/qtdeclarative-${QTMIN}:5
623 - >=dev-qt/qtgui-${QTMIN}:5
624 - >=dev-qt/qtnetwork-${QTMIN}:5[ssl]
625 - >=dev-qt/qtwidgets-${QTMIN}:5
626 - >=dev-qt/qtxml-${QTMIN}:5
627 - =kde-frameworks/kauth-${PVCUT}*:5
628 - =kde-frameworks/karchive-${PVCUT}*:5
629 - =kde-frameworks/kbookmarks-${PVCUT}*:5
630 - =kde-frameworks/kcodecs-${PVCUT}*:5
631 - =kde-frameworks/kcompletion-${PVCUT}*:5
632 - =kde-frameworks/kconfig-${PVCUT}*:5
633 - =kde-frameworks/kconfigwidgets-${PVCUT}*:5
634 - =kde-frameworks/kcoreaddons-${PVCUT}*:5
635 - =kde-frameworks/kcrash-${PVCUT}*:5
636 - =kde-frameworks/kdbusaddons-${PVCUT}*:5
637 - =kde-frameworks/kguiaddons-${PVCUT}*:5
638 - =kde-frameworks/ki18n-${PVCUT}*:5
639 - =kde-frameworks/kiconthemes-${PVCUT}*:5
640 - =kde-frameworks/kitemviews-${PVCUT}*:5
641 - =kde-frameworks/kjobwidgets-${PVCUT}*:5
642 - =kde-frameworks/knotifications-${PVCUT}*:5
643 - =kde-frameworks/kservice-${PVCUT}*:5
644 - =kde-frameworks/ktextwidgets-${PVCUT}*:5
645 - =kde-frameworks/kwidgetsaddons-${PVCUT}*:5
646 - =kde-frameworks/kwindowsystem-${PVCUT}*:5
647 - =kde-frameworks/kxmlgui-${PVCUT}*:5
648 - =kde-frameworks/solid-${PVCUT}*:5
649 - acl? (
650 - sys-apps/attr
651 - virtual/acl
652 - )
653 - handbook? ( =kde-frameworks/kdoctools-${PVCUT}*:5 )
654 - kerberos? ( virtual/krb5 )
655 - kwallet? ( =kde-frameworks/kwallet-${PVCUT}*:5 )
656 - X? ( >=dev-qt/qtx11extras-${QTMIN}:5 )
657 -"
658 -DEPEND="${RDEPEND}
659 - >=dev-qt/qtconcurrent-${QTMIN}:5
660 - test? ( sys-libs/zlib )
661 - X? (
662 - x11-base/xorg-proto
663 - x11-libs/libX11
664 - x11-libs/libXrender
665 - )
666 -"
667 -PDEPEND="
668 - >=kde-frameworks/kded-${PVCUT}:5
669 -"
670 -
671 -PATCHES=(
672 - # pending https://invent.kde.org/frameworks/kio/-/merge_requests/426
673 - "${FILESDIR}"/${PN}-5.81.0-fix-qtconcurrent-private-link.patch # bug 784971
674 - # upstream backport request - see also KDE-bug 398908
675 - "${FILESDIR}"/${P}-MimeTypeFinderJob-memleak-{1,2,3,4}.patch
676 - "${FILESDIR}"/${P}-fix-filenamesearch-crashes.patch # KDE-bug 437153
677 - # git master/KIO 5.83:
678 - "${FILESDIR}"/${P}-no-useragent-kcm.patch
679 - "${FILESDIR}"/${P}-no-cache-kcm.patch
680 -)
681 -
682 -src_prepare() {
683 - ecm_src_prepare
684 - rm -rf po/*/docs/kcontrol5/{cache,useragent} || die # superfluous docs
685 -}
686 -
687 -src_configure() {
688 - local mycmakeargs=(
689 - $(cmake_use_find_package acl ACL)
690 - $(cmake_use_find_package handbook KF5DocTools)
691 - $(cmake_use_find_package kerberos GSSAPI)
692 - $(cmake_use_find_package kwallet KF5Wallet)
693 - $(cmake_use_find_package X X11)
694 - )
695 -
696 - ecm_src_configure
697 -}
698 -
699 -pkg_postinst() {
700 - ecm_pkg_postinst
701 - xdg_desktop_database_update
702 -}
703 -
704 -pkg_postrm() {
705 - ecm_pkg_postrm
706 - xdg_desktop_database_update
707 -}