Gentoo Archives: gentoo-commits

From: Georgy Yakovlev <gyakovlev@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-vcs/tig/, dev-vcs/tig/files/
Date: Sat, 03 Oct 2020 06:20:29
Message-Id: 1601705960.c48cfb265e5607474be746056ebf85657da6bee2.gyakovlev@gentoo
1 commit: c48cfb265e5607474be746056ebf85657da6bee2
2 Author: Justin Bronder <jsbronder <AT> cold-front <DOT> org>
3 AuthorDate: Tue Sep 29 20:29:26 2020 +0000
4 Commit: Georgy Yakovlev <gyakovlev <AT> gentoo <DOT> org>
5 CommitDate: Sat Oct 3 06:19:20 2020 +0000
6 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c48cfb26
7
8 dev-vcs/tig: restore tab completion
9
10 The patch applied in the last bump is incorrect and effectively disables
11 bash completion no matter what order the completions were loaded in as
12 `type -f` will not find `__git_complete`.
13
14 ```
15 $ type -f __git_complete
16 bash: type: __git_complete: not found
17 $ type __git_complete | grep 'is a'
18 __git_complete is a function
19 ```
20
21 There is a pull-request upstream that properly addresses the issue of
22 `__git_complete` not being found but it's not accepted yet,
23 https://github.com/jonas/tig/pull/1016
24
25 Package-Manager: Portage-3.0.4, Repoman-3.0.1
26 Signed-off-by: Justin Bronder <jsbronder <AT> cold-front.org>
27 Closes: https://github.com/gentoo/gentoo/pull/17715
28 Signed-off-by: Georgy Yakovlev <gyakovlev <AT> gentoo.org>
29
30 .../tig/files/tig-2.5.1-bash-completion-qa-warning.patch | 15 ---------------
31 dev-vcs/tig/tig-2.5.1.ebuild | 4 ----
32 2 files changed, 19 deletions(-)
33
34 diff --git a/dev-vcs/tig/files/tig-2.5.1-bash-completion-qa-warning.patch b/dev-vcs/tig/files/tig-2.5.1-bash-completion-qa-warning.patch
35 deleted file mode 100644
36 index 01222ddf14c..00000000000
37 --- a/dev-vcs/tig/files/tig-2.5.1-bash-completion-qa-warning.patch
38 +++ /dev/null
39 @@ -1,15 +0,0 @@
40 -diff --git a/contrib/tig-completion.bash b/contrib/tig-completion.bash
41 -index 5aef3fd..cec0632 100755
42 ---- a/contrib/tig-completion.bash
43 -+++ b/contrib/tig-completion.bash
44 -@@ -29,6 +29,10 @@
45 - # at source time then all lookups will be done on demand,
46 - # which may be slightly slower.
47 -
48 -+if ! type -f __git_complete &>/dev/null; then
49 -+ __git_complete() { complete "${1}"; }
50 -+fi
51 -+
52 - __tig_options="
53 - -v --version
54 - -h --help
55
56 diff --git a/dev-vcs/tig/tig-2.5.1.ebuild b/dev-vcs/tig/tig-2.5.1.ebuild
57 index 41544b59209..e88d7e4b44f 100644
58 --- a/dev-vcs/tig/tig-2.5.1.ebuild
59 +++ b/dev-vcs/tig/tig-2.5.1.ebuild
60 @@ -31,10 +31,6 @@ RDEPEND="${DEPEND}
61 # encoding/env issues
62 RESTRICT="test"
63
64 -PATCHES=(
65 - "${FILESDIR}/tig-2.5.1-bash-completion-qa-warning.patch"
66 -)
67 -
68 src_prepare() {
69 default
70 [[ ${PV} == "9999" ]] && eautoreconf