1 |
commit: 78f612ca869cfbf57478fa30eabb612eb0439659 |
2 |
Author: Michael Tokarev <mjt <AT> tls <DOT> msk <DOT> ru> |
3 |
AuthorDate: Wed Jun 6 21:11:00 2012 +0000 |
4 |
Commit: Doug Goldstein <cardoe <AT> gentoo <DOT> org> |
5 |
CommitDate: Wed Oct 24 07:03:21 2012 +0000 |
6 |
URL: http://git.overlays.gentoo.org/gitweb/?p=proj/qemu-kvm.git;a=commit;h=78f612ca |
7 |
|
8 |
use --libexecdir instead of ignoring it first and reinventing it later |
9 |
|
10 |
Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 "Add basic version |
11 |
of bridge helper" put the bridge helper executable into a fixed |
12 |
${prefix}/libexec/ location, instead of using ${libexecdir} for |
13 |
this. At the same time, --libexecdir is being happily ignored |
14 |
by ./configure. Even more, the same patch sets unused $libexecdir |
15 |
variable in the generated config-host.mak, and uses fixed string |
16 |
(\${prefix}/libexecdir) for the bridge helper binary. |
17 |
|
18 |
Fix this braindamage by introducing $libexecdir variable, using |
19 |
it for the bridge helper binary, and recognizing --libexecdir. |
20 |
|
21 |
This patch is applicable to stable-1.1. |
22 |
|
23 |
Reviewed-by: Andreas Färber <afaerber <AT> suse.de> |
24 |
Reviewed-by: Corey Bryant <coreyb <AT> linux.vnet.ibm.com> |
25 |
Signed-off-by: Michael Tokarev <mjt <AT> tls.msk.ru> |
26 |
Cc: Corey Bryant <coreyb <AT> linux.vnet.ibm.com> |
27 |
Cc: Richa Marwaha <rmarwah <AT> linux.vnet.ibm.com> |
28 |
Cc: qemu-stable <AT> nongnu.org |
29 |
Signed-off-by: Anthony Liguori <aliguori <AT> us.ibm.com> |
30 |
(cherry picked from commit 8bf188aa18ef7a8355d9edbd43871d590468c4ed) |
31 |
|
32 |
--- |
33 |
configure | 10 +++++++--- |
34 |
1 files changed, 7 insertions(+), 3 deletions(-) |
35 |
|
36 |
diff --git a/configure b/configure |
37 |
index b5a21af..e08e8f2 100755 |
38 |
--- a/configure |
39 |
+++ b/configure |
40 |
@@ -169,6 +169,7 @@ datadir="\${prefix}/share" |
41 |
qemu_docdir="\${prefix}/share/doc/qemu" |
42 |
bindir="\${prefix}/bin" |
43 |
libdir="\${prefix}/lib" |
44 |
+libexecdir="\${prefix}/libexec" |
45 |
includedir="\${prefix}/include" |
46 |
sysconfdir="\${prefix}/etc" |
47 |
confsuffix="/qemu" |
48 |
@@ -608,6 +609,8 @@ for opt do |
49 |
;; |
50 |
--libdir=*) libdir="$optarg" |
51 |
;; |
52 |
+ --libexecdir=*) libexecdir="$optarg" |
53 |
+ ;; |
54 |
--includedir=*) includedir="$optarg" |
55 |
;; |
56 |
--datadir=*) datadir="$optarg" |
57 |
@@ -618,7 +621,7 @@ for opt do |
58 |
;; |
59 |
--sysconfdir=*) sysconfdir="$optarg" |
60 |
;; |
61 |
- --sbindir=*|--libexecdir=*|--sharedstatedir=*|--localstatedir=*|\ |
62 |
+ --sbindir=*|--sharedstatedir=*|--localstatedir=*|\ |
63 |
--oldincludedir=*|--datarootdir=*|--infodir=*|--localedir=*|\ |
64 |
--htmldir=*|--dvidir=*|--pdfdir=*|--psdir=*) |
65 |
# These switches are silently ignored, for compatibility with |
66 |
@@ -2975,6 +2978,7 @@ echo "Install prefix $prefix" |
67 |
echo "BIOS directory `eval echo $qemu_datadir`" |
68 |
echo "binary directory `eval echo $bindir`" |
69 |
echo "library directory `eval echo $libdir`" |
70 |
+echo "libexec directory `eval echo $libexecdir`" |
71 |
echo "include directory `eval echo $includedir`" |
72 |
echo "config directory `eval echo $sysconfdir`" |
73 |
if test "$mingw32" = "no" ; then |
74 |
@@ -3079,14 +3083,14 @@ echo all: >> $config_host_mak |
75 |
echo "prefix=$prefix" >> $config_host_mak |
76 |
echo "bindir=$bindir" >> $config_host_mak |
77 |
echo "libdir=$libdir" >> $config_host_mak |
78 |
+echo "libexecdir=$libexecdir" >> $config_host_mak |
79 |
echo "includedir=$includedir" >> $config_host_mak |
80 |
echo "mandir=$mandir" >> $config_host_mak |
81 |
echo "sysconfdir=$sysconfdir" >> $config_host_mak |
82 |
echo "qemu_confdir=$qemu_confdir" >> $config_host_mak |
83 |
echo "qemu_datadir=$qemu_datadir" >> $config_host_mak |
84 |
echo "qemu_docdir=$qemu_docdir" >> $config_host_mak |
85 |
-echo "libexecdir=\${prefix}/libexec" >> $config_host_mak |
86 |
-echo "CONFIG_QEMU_HELPERDIR=\"$prefix/libexec\"" >> $config_host_mak |
87 |
+echo "CONFIG_QEMU_HELPERDIR=\"$libexecdir\"" >> $config_host_mak |
88 |
|
89 |
echo "ARCH=$ARCH" >> $config_host_mak |
90 |
if test "$debug_tcg" = "yes" ; then |