[gentoo-commits] repo/gentoo:master commit in: x11-terms/gnome-terminal/

[Mart Raudsepp]

commit:     ea82df78be457f6edf44c565de6310a676a60092
Author:     Mart Raudsepp <leio <AT> gentoo <DOT> org>
AuthorDate: Mon Jan  8 18:49:45 2018 +0000
Commit:     Mart Raudsepp <leio <AT> gentoo <DOT> org>
CommitDate: Mon Jan  8 18:54:00 2018 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ea82df78

x11-terms/gnome-terminal: remove some unnecessary USE requirements on dependencies

dev-libs/glib[dbus] just pulls in dconf at runtime, but we already have that
dependency here explicitly ourselves; no need to force a rebuild of glib just
for that then.

gtk+[X] is not required and a build against a pure-wayland gtk+ should work
just fine. The problem is that it won't grow X11 support after gtk+ is rebuilt
with USE=X and gnome-terminal not rebuilt. But it'll work fine, just have some
X11 specific extra cases or features disabled. Or it will break if USE=X is
initially there on gtk+, but later removed.
This is a global issue in gtk+[X,wayland] handling and we shouldn't disallow
pure wayland gnome-terminal builds in the meantime. Bug 624960 tracks the
global concerns.

Package-Manager: Portage-2.3.19, Repoman-2.3.6

 x11-terms/gnome-terminal/gnome-terminal-3.24.2.ebuild | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/x11-terms/gnome-terminal/gnome-terminal-3.24.2.ebuild b/x11-terms/gnome-terminal/gnome-terminal-3.24.2.ebuild
index 0a7b6da0999..934e903908d 100644
--- a/x11-terms/gnome-terminal/gnome-terminal-3.24.2.ebuild
+++ b/x11-terms/gnome-terminal/gnome-terminal-3.24.2.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2017 Gentoo Foundation
+# Copyright 1999-2018 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI="6"
@@ -16,11 +16,11 @@ SRC_URI="${SRC_URI} !vanilla? ( https://dev.gentoo.org/~leio/distfiles/gnome-ter
 
 KEYWORDS="~alpha ~amd64 ~arm ~ia64 ~mips ~ppc ~ppc64 ~sh ~sparc ~x86 ~x86-fbsd ~amd64-linux ~arm-linux ~x86-linux"
 
-# FIXME: automagic dependency on gtk+[X], just transitive but needs proper control
+# FIXME: automagic dependency on gtk+[X], just transitive but needs proper control, bug 624960
 # Needed vte in 3.24.2 is 0.48.2, but we add desktop notification patches in 0.48.3 that non-vanilla needs
 RDEPEND="
-	>=dev-libs/glib-2.42:2[dbus]
-	>=x11-libs/gtk+-3.20:3[X]
+	>=dev-libs/glib-2.42:2
+	>=x11-libs/gtk+-3.20:3
 	>=x11-libs/vte-0.48.3:2.91[!vanilla?]
 	>=dev-libs/libpcre2-10
 	>=gnome-base/dconf-0.14