Gentoo Archives: gentoo-commits

From: Fabian Groffen <grobian@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/portage-utils:master commit in: /
Date: Sun, 19 Jan 2020 12:37:23
Message-Id: 1579436454.f47f9880d7266d2e87b2530ea777e4a104ee1a71.grobian@gentoo
1 commit: f47f9880d7266d2e87b2530ea777e4a104ee1a71
2 Author: Fabian Groffen <grobian <AT> gentoo <DOT> org>
3 AuthorDate: Sun Jan 19 12:20:54 2020 +0000
4 Commit: Fabian Groffen <grobian <AT> gentoo <DOT> org>
5 CommitDate: Sun Jan 19 12:20:54 2020 +0000
6 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=f47f9880
7
8 main.h: attempt fix for Coverity 206563 Unintended sign extension
9
10 Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>
11
12 main.h | 8 ++++----
13 1 file changed, 4 insertions(+), 4 deletions(-)
14
15 diff --git a/main.h b/main.h
16 index a7fe725..35b95ab 100644
17 --- a/main.h
18 +++ b/main.h
19 @@ -64,10 +64,10 @@ extern const char *argv0;
20 #endif
21
22 #define READ_BE_INT32(P) \
23 - ((((unsigned char *)(P))[0] << 24) | \
24 - (((unsigned char *)(P))[1] << 16) | \
25 - (((unsigned char *)(P))[2] << 8 ) | \
26 - (((unsigned char *)(P))[3]))
27 + (((unsigned int)((unsigned char *)(P))[0] << 24) | \
28 + ((unsigned int)((unsigned char *)(P))[1] << 16) | \
29 + ((unsigned int)((unsigned char *)(P))[2] << 8 ) | \
30 + ((unsigned int)((unsigned char *)(P))[3]))
31 #define WRITE_BE_INT32(P,I) \
32 { \
33 ((unsigned char *)(P))[0] = (I & 0xff000000) >> 24; \