Gentoo Archives: gentoo-commits

From: "Justin Lecher (jlec)" <jlec@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] gentoo-x86 commit in x11-misc/viewglob/files: viewglob-2.0.4-format-security.patch
Date: Tue, 24 Feb 2015 08:53:03
Message-Id: 20150224085254.DE6C012708@oystercatcher.gentoo.org
1 jlec 15/02/24 08:52:54
2
3 Added: viewglob-2.0.4-format-security.patch
4 Log:
5 Fix for format-security, #541212
6
7 (Portage version: 2.2.17/cvs/Linux x86_64, signed Manifest commit with key B9D4F231BD1558AB!)
8
9 Revision Changes Path
10 1.1 x11-misc/viewglob/files/viewglob-2.0.4-format-security.patch
11
12 file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-misc/viewglob/files/viewglob-2.0.4-format-security.patch?rev=1.1&view=markup
13 plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-misc/viewglob/files/viewglob-2.0.4-format-security.patch?rev=1.1&content-type=text/plain
14
15 Index: viewglob-2.0.4-format-security.patch
16 ===================================================================
17 common/syslogging.c | 2 +-
18 vgseer/vgseer.c | 4 ++--
19 2 files changed, 3 insertions(+), 3 deletions(-)
20
21 diff --git a/common/syslogging.c b/common/syslogging.c
22 index dcb7106..df0b537 100644
23 --- a/common/syslogging.c
24 +++ b/common/syslogging.c
25 @@ -40,6 +40,6 @@ void syslogging(const gchar* log_domain, GLogLevelFlags log_level,
26 else
27 priority = LOG_NOTICE;
28
29 - syslog(priority, message);
30 + syslog(priority, "%s", message);
31 }
32
33 diff --git a/vgseer/vgseer.c b/vgseer/vgseer.c
34 index e045835..18b0024 100644
35 --- a/vgseer/vgseer.c
36 +++ b/vgseer/vgseer.c
37 @@ -276,13 +276,13 @@ static gint connect_to_vgd(gchar* server, gchar* port,
38 if (STREQ(value, "ERROR")) {
39 /* Print reason for error and exit. */
40 get_param_verify(fd, &param, &value, P_REASON, NULL);
41 - g_critical(value);
42 + g_critical("%s", value);
43 clean_fail(NULL);
44 }
45 else if (STREQ(value, "WARNING")) {
46 /* Print warning but continue. */
47 get_param_verify(fd, &param, &value, P_REASON, NULL);
48 - g_warning(value);
49 + g_warning("%s", value);
50 }
51 else if (!STREQ(value, "OK")) {
52 g_critical("Unknown value for P_STATUS: %s", value);