Gentoo Archives: gentoo-commits

From: Andreas Sturmlechner <asturm@g.o>
To: gentoo-commits@l.g.o
Subject: [gentoo-commits] proj/kde:master commit in: kde-apps/gwenview/files/, kde-apps/gwenview/
Date: Wed, 02 Nov 2022 12:58:37
Message-Id: 1667393875.f8902579139556cd20f278d97e9cdef5cedd0b2a.asturm@gentoo
1 commit: f8902579139556cd20f278d97e9cdef5cedd0b2a
2 Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
3 AuthorDate: Wed Nov 2 12:05:39 2022 +0000
4 Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
5 CommitDate: Wed Nov 2 12:57:55 2022 +0000
6 URL: https://gitweb.gentoo.org/proj/kde.git/commit/?id=f8902579
7
8 kde-apps/gwenview: Fix build with USE -X
9
10 Backporting upstream(ed) commit 2ffdf26b81a90c91abadbc8582f82d219dd19e90
11
12 Bug: https://bugs.gentoo.org/813450
13 Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>
14
15 .../files/gwenview-22.08.3-without_x11.patch | 52 ++++++++++++++++++++++
16 kde-apps/gwenview/gwenview-22.08.3.ebuild | 4 +-
17 2 files changed, 55 insertions(+), 1 deletion(-)
18
19 diff --git a/kde-apps/gwenview/files/gwenview-22.08.3-without_x11.patch b/kde-apps/gwenview/files/gwenview-22.08.3-without_x11.patch
20 new file mode 100644
21 index 0000000000..89724ce4bb
22 --- /dev/null
23 +++ b/kde-apps/gwenview/files/gwenview-22.08.3-without_x11.patch
24 @@ -0,0 +1,52 @@
25 +From 2ffdf26b81a90c91abadbc8582f82d219dd19e90 Mon Sep 17 00:00:00 2001
26 +From: Andreas Sturmlechner <asturm@g.o>
27 +Date: Sat, 27 Nov 2021 12:49:09 +0100
28 +Subject: [PATCH] Add CMake option to build WITHOUT_X11
29 +
30 +We want to be able to build without X11 support even if some of the used
31 +libraries may not work w/o X11 themselves yet or need to be built with
32 +X11 support for other reverse dependencies.
33 +
34 +HAVE_X11 already exists and is set automagically so far, but using
35 +-DCMAKE_DISABLE_FIND_PACKAGE_X11 will break if any dependencies list X11
36 +as required in their cmake config.
37 +
38 +Introducing this option means there is no behavior change by default,
39 +cmake will just skip finding X11 or adding unwanted features if the
40 +option is enabled.
41 +
42 +Signed-off-by: Andreas Sturmlechner <asturm@g.o>
43 +---
44 + CMakeLists.txt | 15 +++++++++------
45 + 1 file changed, 9 insertions(+), 6 deletions(-)
46 +
47 +diff --git a/CMakeLists.txt b/CMakeLists.txt
48 +index 22ebcb42..d1b0b5fe 100644
49 +--- a/CMakeLists.txt
50 ++++ b/CMakeLists.txt
51 +@@ -132,13 +132,16 @@ endif()
52 + set_package_properties(KF5KDcraw PROPERTIES URL "https://invent.kde.org/graphics/libkdcraw/" DESCRIPTION "C++ interface around LibRaw library used to decode RAW picture files" TYPE OPTIONAL)
53 +
54 +
55 +-find_package(X11)
56 +-if(X11_FOUND)
57 +- if (QT_MAJOR_VERSION STREQUAL "5")
58 +- find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED X11Extras)
59 ++option(WITHOUT_X11 "Build without X11 integration (disables finding X11)" OFF)
60 ++if(NOT WITHOUT_X11)
61 ++ find_package(X11)
62 ++ if(X11_FOUND)
63 ++ if (QT_MAJOR_VERSION STREQUAL "5")
64 ++ find_package(Qt5 ${QT_MIN_VERSION} CONFIG REQUIRED X11Extras)
65 ++ endif()
66 ++ # we need to add qt6 lib when we found x11
67 ++ set(HAVE_X11 TRUE)
68 + endif()
69 +- # we need to add qt6 lib when we found x11
70 +- set(HAVE_X11 1)
71 + endif()
72 +
73 + if (QT_MAJOR_VERSION STREQUAL "5")
74 +--
75 +GitLab
76 +
77
78 diff --git a/kde-apps/gwenview/gwenview-22.08.3.ebuild b/kde-apps/gwenview/gwenview-22.08.3.ebuild
79 index d341db59c1..9f34c3cac0 100644
80 --- a/kde-apps/gwenview/gwenview-22.08.3.ebuild
81 +++ b/kde-apps/gwenview/gwenview-22.08.3.ebuild
82 @@ -74,6 +74,8 @@ RDEPEND="${COMMON_DEPEND}
83 >=kde-frameworks/kimageformats-${KFMIN}:5
84 "
85
86 +PATCHES=( "${FILESDIR}/${P}-without_x11.patch" )
87 +
88 src_prepare() {
89 ecm_src_prepare
90 if ! use mpris; then
91 @@ -89,7 +91,7 @@ src_configure() {
92 $(cmake_use_find_package raw KF5KDcraw)
93 -DGWENVIEW_SEMANTICINFO_BACKEND=$(usex semantic-desktop Baloo None)
94 $(cmake_use_find_package share KF5Purpose)
95 - $(cmake_use_find_package X X11)
96 + -DWITHOUT_X11=$(usex !X)
97 )
98 ecm_src_configure
99 }