* [gentoo-dev] [PATCH] distutils-r1.eclasS: Switch scikit-build-core to build.verbose
@ 2024-09-24 6:14 Michał Górny
2024-09-24 7:43 ` [gentoo-dev] " Petr Vaněk
2024-09-25 4:27 ` [gentoo-dev] " Michał Górny
0 siblings, 2 replies; 3+ messages in thread
From: Michał Górny @ 2024-09-24 6:14 UTC (permalink / raw
To: gentoo-dev; +Cc: Michał Górny
Replace `cmake.verbose` with `build.verbose`, following the change
in scikit-build-core 0.10.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
eclass/distutils-r1.eclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index 5a6ebdcede8a..53b40163c216 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -1339,9 +1339,9 @@ distutils_pep517_install() {
ninjaopts = shlex.split(os.environ["NINJAOPTS"])
print(json.dumps({
"build.tool-args": ninjaopts,
+ "build.verbose": True,
"cmake.args": ";".join(sys.argv[1:]),
"cmake.build-type": "${CMAKE_BUILD_TYPE}",
- "cmake.verbose": True,
"install.strip": False,
}))
EOF
--
2.46.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [gentoo-dev] Re: [PATCH] distutils-r1.eclasS: Switch scikit-build-core to build.verbose
2024-09-24 6:14 [gentoo-dev] [PATCH] distutils-r1.eclasS: Switch scikit-build-core to build.verbose Michał Górny
@ 2024-09-24 7:43 ` Petr Vaněk
2024-09-25 4:27 ` [gentoo-dev] " Michał Górny
1 sibling, 0 replies; 3+ messages in thread
From: Petr Vaněk @ 2024-09-24 7:43 UTC (permalink / raw
To: gentoo-dev; +Cc: Michał Górny
On Tue, Sep 24, 2024 at 08:14:02AM +0200, Michał Górny wrote:
> Replace `cmake.verbose` with `build.verbose`, following the change
> in scikit-build-core 0.10.
LGTM. There is a typo in commit subject, eclasS -> eclass.
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [gentoo-dev] [PATCH] distutils-r1.eclasS: Switch scikit-build-core to build.verbose
2024-09-24 6:14 [gentoo-dev] [PATCH] distutils-r1.eclasS: Switch scikit-build-core to build.verbose Michał Górny
2024-09-24 7:43 ` [gentoo-dev] " Petr Vaněk
@ 2024-09-25 4:27 ` Michał Górny
1 sibling, 0 replies; 3+ messages in thread
From: Michał Górny @ 2024-09-25 4:27 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]
On Tue, 2024-09-24 at 08:14 +0200, Michał Górny wrote:
> Replace `cmake.verbose` with `build.verbose`, following the change
> in scikit-build-core 0.10.
>
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
> eclass/distutils-r1.eclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 5a6ebdcede8a..53b40163c216 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -1339,9 +1339,9 @@ distutils_pep517_install() {
> ninjaopts = shlex.split(os.environ["NINJAOPTS"])
> print(json.dumps({
> "build.tool-args": ninjaopts,
> + "build.verbose": True,
> "cmake.args": ";".join(sys.argv[1:]),
> "cmake.build-type": "${CMAKE_BUILD_TYPE}",
> - "cmake.verbose": True,
> "install.strip": False,
> }))
> EOF
Reverting this, since it breaks "older" packages. Upstream literally
didn't provide any way for this to work for everyone.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-25 4:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-24 6:14 [gentoo-dev] [PATCH] distutils-r1.eclasS: Switch scikit-build-core to build.verbose Michał Górny
2024-09-24 7:43 ` [gentoo-dev] " Petr Vaněk
2024-09-25 4:27 ` [gentoo-dev] " Michał Górny
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox