public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH] cargo.eclass: Correct variable name in error message
@ 2025-09-11  7:44 Petr Vaněk
  2025-09-11 10:33 ` [gentoo-dev] " Petr Vaněk
  0 siblings, 1 reply; 4+ messages in thread
From: Petr Vaněk @ 2025-09-11  7:44 UTC (permalink / raw
  To: gentoo-dev; +Cc: rust, Petr Vaněk

The error message triggered when RUST_MIN_VER is less than the required
minimum version has been corrected to reflect the actual variable name
used in the eclass. Specifically, RUST_MIN_VERSION was changed to
RUST_MIN_VER for consistency.

Fixes: 8ba94e73b14d ("cargo: update for rust eclass")
Signed-off-by: Petr Vaněk <arkamar@gentoo.org>
---
 eclass/cargo.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
index 247d1bf535b9..5c2b89b6a718 100644
--- a/eclass/cargo.eclass
+++ b/eclass/cargo.eclass
@@ -43,7 +43,7 @@ case ${EAPI} in
 			# than the oldest in-tree in future.
 			if [[ -z ${CARGO_BOOTSTRAP} ]]; then
 				if ver_test "${RUST_MIN_VER}" -lt "${_CARGO_ECLASS_RUST_MIN_VER}"; then
-					die "RUST_MIN_VERSION must be at least ${_CARGO_ECLASS_RUST_MIN_VER}"
+					die "RUST_MIN_VER must be at least ${_CARGO_ECLASS_RUST_MIN_VER}"
 				fi
 			fi
 		else
-- 
2.49.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [gentoo-dev] Re: [PATCH] cargo.eclass: Correct variable name in error message
  2025-09-11  7:44 [gentoo-dev] [PATCH] cargo.eclass: Correct variable name in error message Petr Vaněk
@ 2025-09-11 10:33 ` Petr Vaněk
  2025-09-11 10:49   ` Sam James
  0 siblings, 1 reply; 4+ messages in thread
From: Petr Vaněk @ 2025-09-11 10:33 UTC (permalink / raw
  To: gentoo-dev; +Cc: rust, Sam James

On Thu, Sep 11, 2025 at 09:44:03AM +0200, Petr Vaněk wrote:
> The error message triggered when RUST_MIN_VER is less than the required
> minimum version has been corrected to reflect the actual variable name
> used in the eclass. Specifically, RUST_MIN_VERSION was changed to
> RUST_MIN_VER for consistency.
> 
> Fixes: 8ba94e73b14d ("cargo: update for rust eclass")
> Signed-off-by: Petr Vaněk <arkamar@gentoo.org>

Sam already pushed alternative commit:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43c15cb26af8df9537cc7f9051e0d4ab26f33514


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [gentoo-dev] Re: [PATCH] cargo.eclass: Correct variable name in error message
  2025-09-11 10:33 ` [gentoo-dev] " Petr Vaněk
@ 2025-09-11 10:49   ` Sam James
  2025-09-11 11:00     ` Petr Vaněk
  0 siblings, 1 reply; 4+ messages in thread
From: Sam James @ 2025-09-11 10:49 UTC (permalink / raw
  To: Petr Vaněk; +Cc: gentoo-dev, rust

Petr Vaněk <arkamar@gentoo.org> writes:

> On Thu, Sep 11, 2025 at 09:44:03AM +0200, Petr Vaněk wrote:
>> The error message triggered when RUST_MIN_VER is less than the required
>> minimum version has been corrected to reflect the actual variable name
>> used in the eclass. Specifically, RUST_MIN_VERSION was changed to
>> RUST_MIN_VER for consistency.
>> 
>> Fixes: 8ba94e73b14d ("cargo: update for rust eclass")
>> Signed-off-by: Petr Vaněk <arkamar@gentoo.org>
>
> Sam already pushed alternative commit:
> https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43c15cb26af8df9537cc7f9051e0d4ab26f33514

Sorry, I hadn't seen you'd sent this.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [gentoo-dev] Re: [PATCH] cargo.eclass: Correct variable name in error message
  2025-09-11 10:49   ` Sam James
@ 2025-09-11 11:00     ` Petr Vaněk
  0 siblings, 0 replies; 4+ messages in thread
From: Petr Vaněk @ 2025-09-11 11:00 UTC (permalink / raw
  To: Sam James; +Cc: gentoo-dev, rust

On Thu, Sep 11, 2025 at 11:49:04AM +0100, Sam James wrote:
> Petr Vaněk <arkamar@gentoo.org> writes:
> 
> > On Thu, Sep 11, 2025 at 09:44:03AM +0200, Petr Vaněk wrote:
> >> The error message triggered when RUST_MIN_VER is less than the required
> >> minimum version has been corrected to reflect the actual variable name
> >> used in the eclass. Specifically, RUST_MIN_VERSION was changed to
> >> RUST_MIN_VER for consistency.
> >> 
> >> Fixes: 8ba94e73b14d ("cargo: update for rust eclass")
> >> Signed-off-by: Petr Vaněk <arkamar@gentoo.org>
> >
> > Sam already pushed alternative commit:
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43c15cb26af8df9537cc7f9051e0d4ab26f33514
> 
> Sorry, I hadn't seen you'd sent this.

No problem, I wrote it mainly as FTR.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-09-11 11:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-11  7:44 [gentoo-dev] [PATCH] cargo.eclass: Correct variable name in error message Petr Vaněk
2025-09-11 10:33 ` [gentoo-dev] " Petr Vaněk
2025-09-11 10:49   ` Sam James
2025-09-11 11:00     ` Petr Vaněk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox