From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7825015813A for ; Sun, 12 Jan 2025 13:15:16 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9B7DFE0819; Sun, 12 Jan 2025 13:15:12 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 60FD5E07D9 for ; Sun, 12 Jan 2025 13:15:12 +0000 (UTC) From: Agostino Sarubbo To: gentoo-dev@lists.gentoo.org Cc: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: Emit a warning if the package uses 300+ crates Date: Sun, 12 Jan 2025 14:15:06 +0100 Message-ID: <2498321.jE0xQCEvom@fcf> In-Reply-To: <20250112125639.15047-1-mgorny@gentoo.org> References: <20250112125639.15047-1-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="nextPart2425651.NG923GbCHz" Content-Transfer-Encoding: 7Bit X-Archives-Salt: a24e4302-b6a6-4f8c-b403-27fd3e1b3d2d X-Archives-Hash: 05d84b3fcfc6548de8942e740bd1ee8c This is a multi-part message in MIME format. --nextPart2425651.NG923GbCHz Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On domenica 12 gennaio 2025 13:56:39 CET Micha=C5=82 G=C3=B3rny wrote: > + if [[ ${#crates[@]} -ge 300 ]]; then > + eqawarn "This package uses a very large number of > CRATES. Please provide" + eqawarn "a crate tarball > instead and fetch it via SRC_URI. You can use" + =20 > eqawarn "'pycargoebuild --crate-tarball' to create one." + = fi I would like to suggest to use "QA Notice: " prefix if you want to have=20 them reported. Agostino --nextPart2425651.NG923GbCHz Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8"

On domenica 12 gennaio 2025 13:56:39 CET Micha=C5=82 G=C3=B3rny wrote:

>= ; +            =    if [[ ${#crates[@]} -ge 300 ]]; then

>= ; +            =            eqawarn "= This package uses a very large number of

>= ; CRATES.  Please provide" +      &= nbsp;           &nbs= p;    eqawarn "a crate tarball

>= ; instead and fetch it via SRC_URI.  You can use" +  &n= bsp;            = ;      

>= ; eqawarn "'pycargoebuild --crate-tarball' to create one." + = ;            &n= bsp; fi


I would like to suggest to use "QA Notice: " prefix if you wan= t to have them reported.


Agostino


--nextPart2425651.NG923GbCHz--