public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Allow .jar files in sitedir
Date: Tue, 03 Sep 2024 09:24:11 +0200	[thread overview]
Message-ID: <26471b96faab4e3b61ce29622415215854f17314.camel@gentoo.org> (raw)
In-Reply-To: <2119f623-1c55-4651-b5e7-969e18587cb6@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]

On Sun, 2024-08-25 at 11:36 -0400, Eli Schwartz wrote:
> On 8/25/24 11:33 AM, Michał Górny wrote:
> > Closes: https://bugs.gentoo.org/937642
> > Signed-off-by: Michał Górny <mgorny@gentoo.org>
> > ---
> >  eclass/distutils-r1.eclass | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> > index 0f9dc8d14d5e..39705c5c3c84 100644
> > --- a/eclass/distutils-r1.eclass
> > +++ b/eclass/distutils-r1.eclass
> > @@ -2109,8 +2109,10 @@ _distutils-r1_post_python_install() {
> >  		local strays=()
> >  		local p
> >  		mapfile -d $'\0' -t strays < <(
> > +			# jar for jpype, https://bugs.gentoo.org/937642
> >  			find "${sitedir}" -maxdepth 1 -type f '!' '(' \
> >  					-name '*.egg-info' -o \
> > +					-name '*.jar' -o \
> >  					-name '*.pth' -o \
> >  					-name '*.py' -o \
> >  					-name '*.pyi' -o \
> 
> 
> Copying my comment from the bug report:
> 
> I don't think it makes sense to add a special exception for jar files.
> If we think that packages may be legitimately storing *data* files at
> the top level, we should either relax the check in general, or allow
> adding a suppression variable for packages to suppress this check.
> 

If you don't like JPype's design decisions, take it up to them.  This is
not my fight.

This is the simplest solution to the problem at hand.  The check is
primarily supposed to detect obvious violations, such as common Poetry
use screwups that install random documentation and package configuration
files (LICENSE, README, pyproject.toml...) there.  I don't see a point
in adding a lot of complexity for theoretical purity.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

      parent reply	other threads:[~2024-09-03  7:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-25 15:33 [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Allow .jar files in sitedir Michał Górny
2024-08-25 15:33 ` [gentoo-dev] [PATCH 2/4] distutils-r1.eclass: require <setuptools-72 for det setup.py Michał Górny
2024-08-25 15:33 ` [gentoo-dev] [PATCH 3/4] distutils-r1.eclass: Print pytest version as well (if used) Michał Górny
2024-08-25 15:33 ` [gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Print sphinx + plugins version " Michał Górny
2024-08-25 15:36 ` [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Allow .jar files in sitedir Eli Schwartz
     [not found]   ` <40f857bed27ba9359a495c52266a39404fe276e640af634c0bc0e284aaf23f3c@mu.id>
2024-08-25 16:06     ` Sam James
2024-09-03  7:24   ` Michał Górny [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26471b96faab4e3b61ce29622415215854f17314.camel@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox