From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DE613158042 for ; Tue, 12 Nov 2024 20:09:55 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C3EFCE0837; Tue, 12 Nov 2024 20:09:52 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D758DE0829 for ; Tue, 12 Nov 2024 20:09:51 +0000 (UTC) Message-ID: <85b15a40ca5e109b39fa651eefe3bdd1b0a75703.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: disable setuptools validation of pypi.org allowed strings From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Tue, 12 Nov 2024 21:09:46 +0100 In-Reply-To: References: <20241112172117.2176777-1-eschwartz@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-gU1BWItwxKZtxIHV5Dk7" User-Agent: Evolution 3.52.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: b1078bc5-0768-4ee5-9ea6-a2d01a36566e X-Archives-Hash: 7a02f3ad73345dd4e66c284bc2794741 --=-gU1BWItwxKZtxIHV5Dk7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2024-11-12 at 15:00 -0500, Eli Schwartz wrote: > On 11/12/24 1:37 PM, Micha=C5=82 G=C3=B3rny wrote: > > > diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass > > > index 7ab8dcae3265..9b9ba4b803ac 100644 > > > --- a/eclass/distutils-r1.eclass > > > +++ b/eclass/distutils-r1.eclass > > > @@ -1360,6 +1360,17 @@ distutils_pep517_install() { > > > EOF > > > ) > > > fi > > > + if [[ ${BDEPEND} !=3D *dev-python/trove-classifiers* ]]; then > >=20 > > It's not valid to access stacked variables like BDEPEND from ebuilds. >=20 >=20 > For what reason is it invalid? Is it about whether this will work > correctly or is there a policy reason banning it or... ? Both. > e that this happens inside of a phase function, not at global scope. > So the value of the variable is determined by the contents of the > environment file, not from the incremental value when sourcing the > eclass at global scope. >=20 Precisely. The spec doesn't guarantee that PM will reexport the merged BDEPEND back into ebuild env, rather than leaving whatever the last eclass sourced set. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-gU1BWItwxKZtxIHV5Dk7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQFGBAABCgAwFiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAmcztgoSHG1nb3JueUBn ZW50b28ub3JnAAoJEGOa2uIyniQOFEIIAIjZ6I/pOcw9Co0smB1OyRZJY512SmB0 61OFslGz7ltOl/Tk3/LhbAHTgawe7xuc9JY3QVsU9/A12wLzyr+9rQT8z1j+DzV7 rFNSTWLe6Oyx03UKucMQeZftEgiDJ0b/JdinNLChjed9JVzh64QHIe3SU6MbWJjX bYqWarKaW3VVlZwk2MP5SPJfCL5cNdQkqdikxyehNE0VC6k7z4eQuARFriU0xEdF pCZPNhEuuk1xFrHIxhemAa+o+K2VFWqmtLikkzV8QXbh4YW5sAZISaKvD+b8Ge8m Y1gV83lYZ/qGzU4MtqXYDMI552djY30yibIREHVrTtX5fWsV1Dy8Fto= =yFtU -----END PGP SIGNATURE----- --=-gU1BWItwxKZtxIHV5Dk7--