From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 615601581FB for ; Sun, 25 Aug 2024 16:06:50 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CB0C4E2A4B; Sun, 25 Aug 2024 16:06:46 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 86BA4E2A45 for ; Sun, 25 Aug 2024 16:06:46 +0000 (UTC) From: Sam James To: Eli Schwartz Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Allow .jar files in sitedir In-Reply-To: <40f857bed27ba9359a495c52266a39404fe276e640af634c0bc0e284aaf23f3c@mu.id> (Sam James's message of "Sun, 25 Aug 2024 16:55:57 +0100") Organization: Gentoo References: <20240825153341.21121-1-mgorny@gentoo.org> <2119f623-1c55-4651-b5e7-969e18587cb6@gentoo.org> <40f857bed27ba9359a495c52266a39404fe276e640af634c0bc0e284aaf23f3c@mu.id> Date: Sun, 25 Aug 2024 17:06:41 +0100 Message-ID: <8734msfuy6.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: 266fc6d0-8f8e-4125-8b0b-0c2741c604b4 X-Archives-Hash: e422cc2dae1f26e612163207b906cf8c --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sam James writes: > Eli Schwartz writes: > >> On 8/25/24 11:33 AM, Micha=C5=82 G=C3=B3rny wrote: >>> Closes: https://bugs.gentoo.org/937642 >>> Signed-off-by: Micha=C5=82 G=C3=B3rny >>> --- >>> eclass/distutils-r1.eclass | 2 ++ >>> 1 file changed, 2 insertions(+) >>>=20 >>> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass >>> index 0f9dc8d14d5e..39705c5c3c84 100644 >>> --- a/eclass/distutils-r1.eclass >>> +++ b/eclass/distutils-r1.eclass >>> @@ -2109,8 +2109,10 @@ _distutils-r1_post_python_install() { >>> local strays=3D() >>> local p >>> mapfile -d $'\0' -t strays < <( >>> + # jar for jpype, https://bugs.gentoo.org/937642 >>> find "${sitedir}" -maxdepth 1 -type f '!' '(' \ >>> -name '*.egg-info' -o \ >>> + -name '*.jar' -o \ >>> -name '*.pth' -o \ >>> -name '*.py' -o \ >>> -name '*.pyi' -o \ >> >> >> Copying my comment from the bug report: >> >> I don't think it makes sense to add a special exception for jar files. >> If we think that packages may be legitimately storing *data* files at >> the top level, we should either relax the check in general, or allow >> adding a suppression variable for packages to suppress this check. > > Unfortunately, I think I agree -- we should probably blacklist, not white= list. Or maybe we keep it as-is but with an opt-out var, with documentation saying not to use it without strong justification. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZstWkl8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZA3HgEAgCfWx0qBpAoCEl6Hg4UpRxp7Qc1wjFP3Q6M7 g8OUQ4EBAN9Hql6DYWe3XxeigwYwXhXKmpPz0stt0D42bm3DIkEF =POOl -----END PGP SIGNATURE----- --=-=-=--