From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-102998-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 3E88415812D
	for <garchives@archives.gentoo.org>; Thu, 02 Jan 2025 19:50:12 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 4A4EEE0891;
	Thu, 02 Jan 2025 19:50:08 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 0E3B7E0880
	for <gentoo-dev@lists.gentoo.org>; Thu, 02 Jan 2025 19:50:08 +0000 (UTC)
From: Sam James <sam@gentoo.org>
To: James Le Cuirot <chewi@gentoo.org>
Cc: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] toolchain.eclass: Don't prefixify dynamic
 linker for cross-compilers
In-Reply-To: <20250102163832.26654-1-chewi@gentoo.org> (James Le Cuirot's
	message of "Thu, 2 Jan 2025 16:38:27 +0000")
Organization: Gentoo
References: <20250102163832.26654-1-chewi@gentoo.org>
User-Agent: mu4e 1.12.7; emacs 31.0.50
Date: Thu, 02 Jan 2025 19:49:59 +0000
Message-ID: <87bjwpvvvc.fsf@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: text/plain
X-Archives-Salt: b93c604a-5aa2-43cb-af62-7c3760b9c780
X-Archives-Hash: f830a1c109d99355352425e83d02d9df

James Le Cuirot <chewi@gentoo.org> writes:

> Cross environments within a prefixed system do not have a nested prefix,
> i.e. they are located at ${EPREFIX}/usr/${CHOST}, not
> ${EPREFIX}/usr/${CHOST}/${EPREFIX}. Binaries built with the
> cross-compiler should therefore get an unprefixed dynamic linker path by
> default so that they work out of the box with QEMU's -L option.

Remember to CC eclass maintainers.

Looks good.

>
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
>  eclass/toolchain.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
> index c605c437f355a..f5d3b83c2e03b 100644
> --- a/eclass/toolchain.eclass
> +++ b/eclass/toolchain.eclass
> @@ -716,7 +716,7 @@ toolchain_src_prepare() {
>  
>  	gnuconfig_update
>  
> -	if ! use prefix-guest && [[ -n ${EPREFIX} ]] ; then
> +	if ! is_crosscompile && ! use prefix-guest && [[ -n ${EPREFIX} ]] ; then
>  		einfo "Prefixifying dynamic linkers..."
>  		for f in gcc/config/*/*linux*.h ; do
>  			ebegin "  Updating ${f}"