From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DB0EC1581F3 for ; Thu, 28 Nov 2024 17:22:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 85679E092C; Thu, 28 Nov 2024 17:22:33 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8CFB0E08FC for ; Thu, 28 Nov 2024 17:22:32 +0000 (UTC) From: Sam James To: =?utf-8?B?TWljaGHFgiBHw7Nybnk=?= Cc: gentoo-dev@lists.gentoo.org, Eli Schwartz Subject: Re: [gentoo-dev] [PATCH v2 1/2] sec-keys.eclass: new eclass In-Reply-To: (=?utf-8?Q?=22Micha=C5=82_G=C3=B3rny=22's?= message of "Thu, 28 Nov 2024 18:06:17 +0100") Organization: Gentoo References: <20241127203042.1503004-1-eschwartz@gentoo.org> <20241128043320.1562802-1-eschwartz@gentoo.org> <20241128043320.1562802-2-eschwartz@gentoo.org> <0296ba81-8379-4030-896c-4722cc768d4a@gentoo.org> <87r06vb8l4.fsf@gentoo.org> User-Agent: mu4e 1.12.7; emacs 31.0.50 Date: Thu, 28 Nov 2024 17:22:28 +0000 Message-ID: <87iks7b7e3.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: 289198c8-d1e9-4427-8d58-a9087bc5d5b9 X-Archives-Hash: b795a2b8de2e992d0307264f033c0629 Micha=C5=82 G=C3=B3rny writes: > On Thu, 2024-11-28 at 16:56 +0000, Sam James wrote: >> Eli Schwartz writes: >>=20 >> > On 11/28/24 8:10 AM, Micha=C5=82 G=C3=B3rny wrote: >> > > On Wed, 2024-11-27 at 23:32 -0500, Eli Schwartz wrote: >> > >=20 >> > > That looks like something you could do in src_compile() already. >> >=20 >> >=20 >> > Perhaps. But it felt like exporting keys is work that is conceptually >> > part of installing, in much the way that running a meson project's >> > `meson install` step does more than just copy files into ${D} -- it al= so >> > processes those files in order to do things like patch the rpath. >> >=20 >> > I guess I am not too attached to either approach. >>=20 >> I think I very loosely prefer doing it in src_compile as it's >> "compilation" of the resulting files and then src_install just moving >> the bundle, but I hardly feel strongly about it at all and feel it's >> personal preference. Not worth the electrons ;) > > My point was mostly that you wouldn't have to start with GNUPGHOME > again. Also, tests might be able to reuse the result then. Also, tests > wouldn't be able to mess up src_install() (think of test-fail-continue > too). Ah, test-fail-continue is a good point.