public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] [PATCH] ruby-fakegem.eclass: compile ruby31 extensions with gnu17
@ 2024-12-08 10:53 Hans de Graaff
  2024-12-09  5:51 ` Sam James
  0 siblings, 1 reply; 2+ messages in thread
From: Hans de Graaff @ 2024-12-08 10:53 UTC (permalink / raw
  To: gentoo-dev; +Cc: Hans de Graaff

The varargs implementation in Ruby 3.2 is not compatible with gnu23. Ruby
3.1 is in security maintenance mode upstream so it is unlikely that the
fixes from Ruby 3.2 will be backported. Ruby 3.1 is EOL in March 2025
and will be removed from Gentoo around that time.

Signed-off-by: Hans de Graaff <graaff@gentoo.org>
---
 eclass/ruby-fakegem.eclass | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/eclass/ruby-fakegem.eclass b/eclass/ruby-fakegem.eclass
index eb6257a50cf9..fc78428be714 100644
--- a/eclass/ruby-fakegem.eclass
+++ b/eclass/ruby-fakegem.eclass
@@ -23,6 +23,8 @@ case ${EAPI} in
 	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
 esac
 
+# flag-o-matic is only required for ruby31 support.
+inherit flag-o-matic
 inherit ruby-ng
 
 # @ECLASS_VARIABLE: RUBY_FAKEGEM_NAME
@@ -424,6 +426,16 @@ EOF
 each_fakegem_configure() {
 	debug-print-function ${FUNCNAME} "$@"
 
+	# Ruby 3.1 has a varargs implementation that is not compatible with
+	# gnu23. Ruby 3.1 is EOL in March 2025 and will be removed shortly
+	# after that.
+	case ${RUBY} in
+		*ruby31)
+			append-flags -std=gnu17
+			filter-flags -std=gnu23
+			;;
+	esac
+
 	tc-export PKG_CONFIG
 	for extension in "${RUBY_FAKEGEM_EXTENSIONS[@]}" ; do
 		CC=$(tc-getCC) ${RUBY} --disable=did_you_mean -C ${extension%/*} ${extension##*/} --with-cflags="${CFLAGS}" --with-ldflags="${LDFLAGS}" ${RUBY_FAKEGEM_EXTENSION_OPTIONS} || die
-- 
2.45.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [gentoo-dev] [PATCH] ruby-fakegem.eclass: compile ruby31 extensions with gnu17
  2024-12-08 10:53 [gentoo-dev] [PATCH] ruby-fakegem.eclass: compile ruby31 extensions with gnu17 Hans de Graaff
@ 2024-12-09  5:51 ` Sam James
  0 siblings, 0 replies; 2+ messages in thread
From: Sam James @ 2024-12-09  5:51 UTC (permalink / raw
  To: Hans de Graaff; +Cc: gentoo-dev

Hans de Graaff <graaff@gentoo.org> writes:

> The varargs implementation in Ruby 3.2 is not compatible with gnu23. Ruby
> 3.1 is in security maintenance mode upstream so it is unlikely that the
> fixes from Ruby 3.2 will be backported. Ruby 3.1 is EOL in March 2025
> and will be removed from Gentoo around that time.
>

LGTM if you've confirmed it fixes an extension build. Add a Closes
tag for https://bugs.gentoo.org/943988?

> Signed-off-by: Hans de Graaff <graaff@gentoo.org>
> ---
>  eclass/ruby-fakegem.eclass | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/eclass/ruby-fakegem.eclass b/eclass/ruby-fakegem.eclass
> index eb6257a50cf9..fc78428be714 100644
> --- a/eclass/ruby-fakegem.eclass
> +++ b/eclass/ruby-fakegem.eclass
> @@ -23,6 +23,8 @@ case ${EAPI} in
>  	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
>  esac
>  
> +# flag-o-matic is only required for ruby31 support.
> +inherit flag-o-matic
>  inherit ruby-ng
>  
>  # @ECLASS_VARIABLE: RUBY_FAKEGEM_NAME
> @@ -424,6 +426,16 @@ EOF
>  each_fakegem_configure() {
>  	debug-print-function ${FUNCNAME} "$@"
>  
> +	# Ruby 3.1 has a varargs implementation that is not compatible with
> +	# gnu23. Ruby 3.1 is EOL in March 2025 and will be removed shortly
> +	# after that.
> +	case ${RUBY} in
> +		*ruby31)
> +			append-flags -std=gnu17
> +			filter-flags -std=gnu23
> +			;;
> +	esac
> +
>  	tc-export PKG_CONFIG
>  	for extension in "${RUBY_FAKEGEM_EXTENSIONS[@]}" ; do
>  		CC=$(tc-getCC) ${RUBY} --disable=did_you_mean -C ${extension%/*} ${extension##*/} --with-cflags="${CFLAGS}" --with-ldflags="${LDFLAGS}" ${RUBY_FAKEGEM_EXTENSION_OPTIONS} || die


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-12-09  5:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-08 10:53 [gentoo-dev] [PATCH] ruby-fakegem.eclass: compile ruby31 extensions with gnu17 Hans de Graaff
2024-12-09  5:51 ` Sam James

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox