public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Alec Warner <antarus@gentoo.org>
To: Gentoo Dev <gentoo-dev@lists.gentoo.org>
Cc: Thomas Deutschmann <whissi@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 1/2] acct-user.eclass: Support ACCT_USER_ID override
Date: Wed, 6 Jan 2021 11:12:59 -0800	[thread overview]
Message-ID: <CAAr7Pr-dBcJz=2vYhNuj_ORsCfh4q7+7eGWH6qN_WfntwnggmA@mail.gmail.com> (raw)
In-Reply-To: <20210106110546.27f3848c@moya.linuxfreak.ca>

On Wed, Jan 6, 2021 at 11:05 AM Patrick McLean <chutzpah@gentoo.org> wrote:
>
> On Wed, 6 Jan 2021 15:02:12 +0100
> Thomas Deutschmann <whissi@gentoo.org> wrote:
>
> > Hi,
> >
> > is there a specific reason why we want to support dynamic variables
> > (ACCT_USER_$foo) at all?
> >
> > Isn't package.env support enough, i.e. use ACCT_USER_ID from environment
> > if set (which we should detect and log, maybe this will require a
> > different namespace for the variables at all to be able to differentiate
> > between values set by acct-* ebuild and user override)?
> >
> > Of course this won't allow something like `ACCT_USER_ID=42 emerge
> > <package which will pull in multiple acct-user/*>` but I am not sure if
> > this is an implementation goal.
>
> This is so ACCT_USER_$foo can be set in make.conf, and not have to
> be specified as an environment variable whenever portage is run. This
> helps when automated systems are building Gentoo images or systems.
>

Not sure I follow. Whether your automation sets a variable in
/etc/portage/make.conf or /etc/portage/package.env; it's basically the
same problem space; no?

-A


  reply	other threads:[~2021-01-06 19:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05 18:39 [gentoo-dev] [PATCH 1/2] acct-user.eclass: Support ACCT_USER_ID override Michał Górny
2021-01-05 18:39 ` [gentoo-dev] [PATCH 2/2] acct-group.eclass: Support ACCT_GROUP_ID override Michał Górny
2021-01-06 13:25 ` [gentoo-dev] [PATCH 1/2] acct-user.eclass: Support ACCT_USER_ID override Ulrich Mueller
2021-01-06 14:02   ` Thomas Deutschmann
2021-01-06 19:05     ` Patrick McLean
2021-01-06 19:12       ` Alec Warner [this message]
2021-01-06 19:31         ` Thomas Deutschmann
2021-01-06 19:43       ` Thomas Deutschmann
2021-01-06 19:11   ` Michał Górny
2021-01-06 20:09     ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAr7Pr-dBcJz=2vYhNuj_ORsCfh4q7+7eGWH6qN_WfntwnggmA@mail.gmail.com' \
    --to=antarus@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=whissi@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox