Re: [gentoo-dev] [PATCH 3/4] cvs.eclass: New eclass variable ECVS_SSH_EXTRA_OPTS

[Mike Gilbert <floppym@gentoo.org>]

On Thu, Oct 17, 2024 at 1:58 AM Ulrich Müller <ulm@gentoo.org> wrote:
>
> This allows passing additional options to ssh.
>
> Signed-off-by: Ulrich Müller <ulm@gentoo.org>
> ---
>  eclass/cvs.eclass | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/eclass/cvs.eclass b/eclass/cvs.eclass
> index 1289ee54cc3b..5148daa2d57d 100644
> --- a/eclass/cvs.eclass
> +++ b/eclass/cvs.eclass
> @@ -174,6 +174,12 @@ _CVS_ECLASS=1
>  # WARNING: If a SSH host key is not specified using this variable, the
>  # remote host key will not be verified.
>
> +# @ECLASS_VARIABLE: ECVS_SSH_EXTRA_OPTS
> +# @DEFAULT_UNSET
> +# @DESCRIPTION:
> +# If SSH is used for "ext" authentication, this array variable can be
> +# used to pass additional options to the SSH command.
> +
>  # @ECLASS_VARIABLE: ECVS_CLEAN
>  # @DEFAULT_UNSET
>  # @DESCRIPTION:
> @@ -387,6 +393,7 @@ cvs_fetch() {
>                                         -oUserKnownHostsFile="${known_hosts_file}" \\
>                                         -oForwardX11=no \\
>                                         -oClearAllForwardings=yes \\
> +                                       ${ECVS_SSH_EXTRA_OPTS[*]} \\

Why use an array if you're going to collapse it using the "*"
operator? Maybe use "${ECVS_SSH_EXTRA_OPTS[@]}" instead.