Re: [gentoo-dev] TIDAL ebuild

[Filip Kobierski <fkobi@pm.me>]

[-- Attachment #1.1: Type: text/plain, Size: 2188 bytes --]

Errata:
I have just looked up the upstream and I think the name is fine.
However I would mention somewhere that it's a third party app.
(AFAIR discord also is an electron app and 3rd party client
note that they are not official) 



On Tuesday, December 24th, 2024 at 15:26, Filip Kobierski <fkobi@pm.me> wrote:

> Hi Daniel,
> 

> I am no ebuild-master myself but I think I have some feedback;
> - since it's a -bin package make sure to have -* in KEYWORDS
> - use desktop.eclass[1]:
> - domenu for the desktop file
> - doicon for the icon
> - also I would use dobin for installing binaries
> - I would use ${PN} where possible (besides SRC_URI & HOMEPAGE
> 

> On the name though, is the -bin really nescessary if there is no
> source option? On one hand we have net-im/discord but on the other
> there's net-im/discord-canary-bin.
> Another thing is the -hifi part. For me it implies that before
> there was some non-hifi version. If that's the case than that is
> fine to me.
> I however would name the package tidal-desktop or just tidal.
> 

> 

> I hope that this helps
> Filip Kobierski
> 

> [1]: https://devmanual.gentoo.org/eclass-reference/desktop.eclass/
> 

> On Tuesday, December 24th, 2024 at 15:11, Daniel Buschke damage@devloop.de wrote:
> 

> > Hi all,
> > TIDAL is a music streaming service. As I missed a TIDAL desktop app on
> > gentoo I created an ebuild based on
> > https://github.com/Mastermindzh/tidal-hifi.
> > 

> > It's a node js application which drove me a bit crazy. I was today years
> > old when I realized that the gentoo emerge sandbox is cutting network
> > access :)
> > But the node js application, as every node js app, heavily relies on
> > dependencies, so I decided to go with the binary version.
> > 

> > Anyway, as I am not very firm with ebuilds it would be nice if someone
> > could do a review before I try to commit this ebuild to the official
> > portage via bugs.gentoo.org. Anyone? Thanks in advance.
> > 

> > https://source.devloop.de/damage/gentoo/src/branch/main/media-sound/tidal-hifi-bin
> > 

> > Stay healthy, everyone out there.
> > 

> > regards
> > Daniel

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 249 bytes --]